Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 688926 - x11-libs/pixman-0.38.4: ignore or incorrectly interpret MAKEOPTS
Summary: x11-libs/pixman-0.38.4: ignore or incorrectly interpret MAKEOPTS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: makeopts-ignored
  Show dependency tree
 
Reported: 2019-06-29 12:12 UTC by Toralf Förster
Modified: 2019-07-13 17:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
load.71.20190625-213237 (load.71.20190625-213237,39.35 KB, text/plain)
2019-06-29 12:13 UTC, Toralf Förster
Details
Set OMP_NUM_THREADS=$(makeopts_jobs) (0001-x11-libs-pixman-Limit-test-suite-makeopts_jobs-threa.patch,2.23 KB, patch)
2019-07-09 20:22 UTC, Matt Turner
Details | Diff
Set OMP_NUM_THREADS=$(makeopts_jobs) (0001-x11-libs-pixman-Limit-test-suite-makeopts_jobs-threa.patch,2.12 KB, patch)
2019-07-11 20:50 UTC, Matt Turner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2019-06-29 12:12:44 UTC
at least for the test phase (pls see attached pstree)
Comment 1 Toralf Förster gentoo-dev 2019-06-29 12:13:21 UTC
Created attachment 581356 [details]
load.71.20190625-213237

pstree
Comment 2 Matt Turner gentoo-dev 2019-07-09 18:18:08 UTC
Yes, you are right. Many of the tests use OpenMP. I'm not sure what to do.

We could run the tests sequentially and let OpenMP use -jX threads, but that would be inefficient for the tests that don't use OpenMP.

We could disable OpenMP support and run tests in parallel, but that would increase runtime of the long tests that use OpenMP.

I understand that this bug report is valid. We are definitely exceeding the -jX parameter in the src_test phase, but I don't know whether we should fix that when the fixes all have bad downsides.

Thoughts?
Comment 3 Matt Turner gentoo-dev 2019-07-09 20:22:55 UTC
Created attachment 582338 [details, diff]
Set OMP_NUM_THREADS=$(makeopts_jobs)

Give this a try.
Comment 4 Matt Turner gentoo-dev 2019-07-11 20:50:40 UTC
Created attachment 582590 [details, diff]
Set OMP_NUM_THREADS=$(makeopts_jobs)

Let's try this one instead. Uses 'export' which makes it work, I think. (I see OMP_NUM_THREADS=8 in /proc/$(pidof composite)/environ)
Comment 5 Larry the Git Cow gentoo-dev 2019-07-13 17:37:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=15997405f8f43bf97c753ffc1f259de5629345c0

commit 15997405f8f43bf97c753ffc1f259de5629345c0
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2019-07-09 20:16:41 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2019-07-13 17:37:04 +0000

    x11-libs/pixman: Limit test suite $(makeopts_jobs) threads
    
    Otherwise we would run as many OpenMP threads as there are CPU cores and
    ignore MAKEOPTS. Since we're running tests in parallel *and* the tests
    spawn multiple threads, we will still exceed $(makeopts_jobs) threads
    total, but I don't think that can be helped.
    
    Closes: https://bugs.gentoo.org/688926
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 x11-libs/pixman/pixman-0.38.4.ebuild | 3 ++-
 x11-libs/pixman/pixman-9999.ebuild   | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)