Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 686592 - sci-libs/dcmtk-3.6.3 fails to build with gcc-9.1.0
Summary: sci-libs/dcmtk-3.6.3 fails to build with gcc-9.1.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Science Biology related packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-23 10:44 UTC by Ingo Brunberg
Modified: 2019-07-29 08:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ingo Brunberg 2019-05-23 10:44:24 UTC
The build stops when trying to link against the icu libraries. According to the dcmtk documentation it should be possible to either use libiconv, icu or iconv from the standard library. So forcing icu does not seem to be a terribly good idea, since icu-64 now went stable.
Comment 1 Ingo Brunberg 2019-05-24 10:12:15 UTC
Sorry, I was too quick. The error is not caused by icu but stricter checking by gcc-9. Clang-8.0 also fails.
The offending code is in line 57 of file
ofstd/include/dcmtk/ofstd/variadic/helpers.h

So the title should be sci-libs/dcmtk-3.6.3 fails to build with gcc-9.1.0.
Comment 2 Ingo Brunberg 2019-05-26 08:27:28 UTC
Without fixing the code itself, the build succeeds when adding "-Wno-error=narrowing" to CXXFLAGS.
Comment 3 brothermechanic 2019-05-27 17:27:59 UTC
+1
Comment 4 Larry the Git Cow gentoo-dev 2019-06-22 13:16:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d648afac343e93926af5bfb7bf5a0ce31eb8a655

commit d648afac343e93926af5bfb7bf5a0ce31eb8a655
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2019-06-22 13:16:22 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2019-06-22 13:16:22 +0000

    sci-libs/dcmtk: Fix building against GCC 9
    
    Closes: https://bugs.gentoo.org/686592
    Package-Manager: Portage-2.3.67, Repoman-2.3.15
    Signed-off-by: David Seifert <soap@gentoo.org>

 sci-libs/dcmtk/dcmtk-3.6.3.ebuild               |  3 ++-
 sci-libs/dcmtk/files/dcmtk-3.6.3-fix-gcc9.patch | 29 +++++++++++++++++++++++++
 2 files changed, 31 insertions(+), 1 deletion(-)