Bug 685446 – app-misc/recoll-1.25.15 - In file included from common/rclconfig.cpp:44: /usr/lib/gcc/x86_64-pc-linux-gnu/9.1.0/include/g++-v9/bits/stl_tree.h:987:16: error: static assertion failed: comparison object must be invocable as const

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Helmut Jarausch 2019-05-09 11:09:17 UTC]

Created attachment 575586 [details, diff]
patch needed for gcc-9.1 (at least)

gcc-9 is pickier about the constness of comparison operators for sets.
The attached patch is necessary for gcc-9.1 and would have been good programming style for any C++ ever.

[Comment 1 Andreas Sturmlechner 2019-05-09 11:58:26 UTC]

Where's the build.log, and where is the patch from?

[Comment 2 Helmut Jarausch 2019-05-09 12:49:33 UTC]

(In reply to Andreas Sturmlechner from comment #1)
> Where's the build.log, and where is the patch from?

The patch is by me, it's just standard C++.

The relevant part of the build log is

In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/9.1.0/include/g++-v9/set:60,
                 from ./utils/pathut.h:22,
                 from common/rclconfig.cpp:44:
/usr/lib/gcc/x86_64-pc-linux-gnu/9.1.0/include/g++-v9/bits/stl_tree.h: In instantiation of 'std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::~_Rb_tree() [with _Key = SfString; _Val = SfString; _KeyOfValue = std::_Identity<SfString>; _Compare = SuffCmp; _Alloc = std::allocator<SfString>]':
/usr/lib/gcc/x86_64-pc-linux-gnu/9.1.0/include/g++-v9/bits/stl_multiset.h:277:7:   required from here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.1.0/include/g++-v9/bits/stl_tree.h:987:16: error: static assertion failed: comparison object must be invocable as const
  987 |  static_assert(is_invocable_v<const _Compare&, const _Key&, const _Key&>,
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[Comment 3 Andreas Sturmlechner 2019-06-01 19:39:48 UTC]

@ppurka, I see there is 1.25.18 available upstream, is it fixed in that version?

[Comment 4 P Purkayastha 2019-06-04 02:18:29 UTC]

This is still not fixed in the latest git sources. Thanks for the patch. I have created a bug report upstream: https://opensourceprojects.eu/p/recoll1/tickets/95

[Comment 5 Andreas Sturmlechner 2019-06-20 11:17:23 UTC]

Patch landed upstream.

[Comment 6 P Purkayastha 2019-06-22 11:39:25 UTC]

Created attachment 580418 [details]
recoll-1.25.19.ebuild

Thanks all. This has been fixed upstream in 1.25.19. Ebuild just needs to be renamed.

[Comment 7 Larry the Git Cow 2019-06-27 17:21:17 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1ea99e2907caaadf795004b01802b3245a73c9ab

commit 1ea99e2907caaadf795004b01802b3245a73c9ab
Author:     Punarbasu 'ppurka' Purkayastha <[e-mail]>
AuthorDate: 2019-06-27 13:11:57 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2019-06-27 17:18:01 +0000

    app-misc/recoll: 1.25.19 version bump
    
    Closes: https://bugs.gentoo.org/685446
    Package-Manager: Portage-2.3.67, Repoman-2.3.16
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 app-misc/recoll/Manifest              |   1 +
 app-misc/recoll/recoll-1.25.19.ebuild | 134 ++++++++++++++++++++++++++++++++++
 2 files changed, 135 insertions(+)