Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 685038 - net-print/cnijfilter-3.40-r2::bar - eclass/ecnij.eclass broken
Summary: net-print/cnijfilter-3.40-r2::bar - eclass/ecnij.eclass broken
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: tokiclover
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-05-04 10:08 UTC by Evert
Modified: 2019-05-04 23:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
eclass/ecnij.eclass.patch (ecnij.eclass.patch,724 bytes, patch)
2019-05-04 10:08 UTC, Evert
Details | Diff
modified ecnij.eclass for review (ecnij.eclass,9.22 KB, text/plain)
2019-05-04 17:11 UTC, Evert
Details
modified ecnij.eclass for review (ecnij.eclass,9.21 KB, text/plain)
2019-05-04 18:15 UTC, Evert
Details
modified eclass/ecnij.eclass - fix missing files & QA Notices (ecnij.eclass,9.26 KB, text/plain)
2019-05-04 22:58 UTC, Evert
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Evert 2019-05-04 10:08:42 UTC
Created attachment 575122 [details, diff]
eclass/ecnij.eclass.patch

After emerge =net-print/cnijfilter-3.40-r2::bar a lot of files are missing.
I tracked down the issue to eclass/ecnij.eclass
The broken part (2x) is dir_src_command "emake" "DESTDIR=\"${D}\" install"
where "DESTDIR=\"${D}\" install" is seen as one argument.
This must be specified 2 arguments.

I fixed the issue, see patch in attachment.
Comment 2 Evert 2019-05-04 17:11:02 UTC
Created attachment 575132 [details]
modified ecnij.eclass for review

I digged a bit further into ecnij.eclass and found some things which you may not have intended. Especially myeconfargs which keeps on growing and growing with any dir match. Other than that, I'm still puzzled by the purpose of ${license%${lingua:0:1}.txt}.txt which I reckon didn't work anyway. 

So I changed things here and there, see this attachment. If you have the time, you may want to take a look into this. If not, fine to me too. For mg5200 the final result is identical however I cannot speak about other models where it may improve or even break the final result.
Comment 3 Evert 2019-05-04 18:15:14 UTC
Created attachment 575162 [details]
modified ecnij.eclass for review

small QA fix
Comment 4 Evert 2019-05-04 22:58:07 UTC
Created attachment 575230 [details]
modified eclass/ecnij.eclass - fix missing files & QA Notices

Added QA comment into eclass/ecnij.eclass
Note: this modified eclass/ecnij.eclass
- restores the installation of previously missing files
- fixes QA Notices caused by incorrect myeconfargs assignments