Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 681344 - xfce-extra/xfce4-screensaver: No elogind support
Summary: xfce-extra/xfce4-screensaver: No elogind support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: elogind-support
  Show dependency tree
 
Reported: 2019-03-23 00:50 UTC by Andreas Sturmlechner
Modified: 2019-06-13 11:11 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-Add-support-for-elogind.patch (0001-Add-support-for-elogind.patch,10.19 KB, patch)
2019-03-23 07:06 UTC, Michał Górny
Details | Diff
0001-Add-support-for-elogind.patch (xfce4-screensaver-0.1.4-elogind.patch,10.15 KB, patch)
2019-03-24 15:46 UTC, Andreas Sturmlechner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2019-03-23 00:50:33 UTC
A quick search did not come up with an upstream issue about this. This package apparently has no revdeps, so may not be that important after all.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-03-23 06:37:22 UTC
Yeah, it's a fresh project.  Do I understand correctly that the only thing needing to be done here is 'replacing' -lsystemd with -lelogind?  Hmm, I should probably check if they need -lsystemd at all because I see a lot of direct dbus calls.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-03-23 07:06:14 UTC
Created attachment 570340 [details, diff]
0001-Add-support-for-elogind.patch

Please review and test the attached patch.  If it's ok, I'll submit it upstream.
Comment 3 Andreas Sturmlechner gentoo-dev 2019-03-24 15:46:38 UTC
Created attachment 570608 [details, diff]
0001-Add-support-for-elogind.patch

I had to fix one leftover `have_systemd` to `have_logind` in order for build to succeed.

Testing this in my Plasma-5 elogind session; ran xfce4-screensaver, locked, and was perfectly able to unlock the screensaver again.
Comment 4 Larry the Git Cow gentoo-dev 2019-06-13 11:11:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0468edec89303334c1e5dd7dc9b856a78d8ddc75

commit 0468edec89303334c1e5dd7dc9b856a78d8ddc75
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-06-13 11:01:17 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-06-13 11:11:22 +0000

    xfce-extra/xfce4-screensaver: Bump to 0.1.5
    
    Bump to 0.1.5 release.  Includes elogind support.
    
    Closes: https://bugs.gentoo.org/681344
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 xfce-extra/xfce4-screensaver/Manifest              |  1 +
 .../xfce4-screensaver-0.1.5.ebuild                 | 74 ++++++++++++++++++++++
 2 files changed, 75 insertions(+)