Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 681334 - mate-extra/mate-screensaver and mate-extra/mate-system-monitor: elogind support
Summary: mate-extra/mate-screensaver and mate-extra/mate-system-monitor: elogind support
Status: IN_PROGRESS
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo MATE Desktop
URL:
Whiteboard: need upstreaming
Keywords:
Depends on:
Blocks: elogind-support
  Show dependency tree
 
Reported: 2019-03-23 00:12 UTC by Andreas Sturmlechner
Modified: 2019-04-01 16:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
autoconf precious variable approach to adding elogind support (0001-mate-extra-mate-screensaver-add-elogind-support.patch,2.51 KB, patch)
2019-03-24 16:12 UTC, Mart Raudsepp
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2019-03-23 00:12:08 UTC
I could not find a related upstream issue for this. In this day and age, if it is not essential for a Mate desktop may as well hide it behind mate-base/mate[!elogind] if upstream does not move in time?
Comment 1 Andreas Sturmlechner gentoo-dev 2019-03-24 15:49:51 UTC
xfce4-screensaver has a working patch over at bug 681334 now, maybe it is adaptable to your needs?
Comment 2 Mart Raudsepp gentoo-dev 2019-03-24 16:12:13 UTC
Created attachment 570610 [details, diff]
autoconf precious variable approach to adding elogind support

Maybe just doing what I do in gdm is sufficient in parallel to upstreaming efforts? COMPLETELY blind patch to that effect attached.
Comment 3 Joakim Tjernlund 2019-03-27 21:26:10 UTC
(In reply to Mart Raudsepp from comment #2)
> Created attachment 570610 [details, diff] [details, diff]
> autoconf precious variable approach to adding elogind support
> 
> Maybe just doing what I do in gdm is sufficient in parallel to upstreaming
> efforts? COMPLETELY blind patch to that effect attached.

Did a build test with your patch and it worked :)

There is also a PR upstream at:
 https://github.com/mate-desktop/mate-screensaver/pull/188
which should go in soon as a similar patch for mate-session was accepted.
Comment 4 Larry the Git Cow gentoo-dev 2019-03-31 10:47:52 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ff46897d6fa08727f2f8b25f633aafacf854103b

commit ff46897d6fa08727f2f8b25f633aafacf854103b
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-03-31 09:33:42 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-03-31 10:47:31 +0000

    mate-extra/mate-system-monitor: Add USE elogind
    
    Bug: https://bugs.gentoo.org/681334
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../mate-system-monitor-1.22.0.ebuild              | 22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6a58f568520b5fedc9b81b9b5fa02f6c3bf9b4b2

commit 6a58f568520b5fedc9b81b9b5fa02f6c3bf9b4b2
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2019-03-24 16:10:55 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-03-31 10:47:22 +0000

    mate-extra/mate-screensaver: add elogind support
    
    Bug: https://bugs.gentoo.org/681334
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Mart Raudsepp <leio@gentoo.org>
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../mate-screensaver-1.22.0.ebuild                 | 41 ++++++++++++++--------
 1 file changed, 27 insertions(+), 14 deletions(-)
Comment 5 Andreas Sturmlechner gentoo-dev 2019-03-31 10:51:21 UTC
(In reply to Mart Raudsepp from comment #2)
> Created attachment 570610 [details, diff] [details, diff]
> autoconf precious variable approach to adding elogind support

Did the same for mate-extra/mate-system-monitor here.

A patch still needs to be made and upstreamed though.
Comment 6 Joakim Tjernlund 2019-04-01 14:10:24 UTC
(In reply to Andreas Sturmlechner from comment #5)
> (In reply to Mart Raudsepp from comment #2)
> > Created attachment 570610 [details, diff] [details, diff] [details, diff]
> > autoconf precious variable approach to adding elogind support
> 
> Did the same for mate-extra/mate-system-monitor here.
> 
> A patch still needs to be made and upstreamed though.

Did a quick test with MATE and elogind today and it worked well so far but
one thing: Choosing reboot in MATE only logs you out, returns to the SDDM login menu.

Do I need to change some config too?
Comment 7 Joakim Tjernlund 2019-04-01 16:16:29 UTC
(In reply to Joakim Tjernlund from comment #6)
> (In reply to Andreas Sturmlechner from comment #5)
> > (In reply to Mart Raudsepp from comment #2)
> > > Created attachment 570610 [details, diff] [details, diff] [details, diff] [details, diff]
> > > autoconf precious variable approach to adding elogind support
> > 
> > Did the same for mate-extra/mate-system-monitor here.
> > 
> > A patch still needs to be made and upstreamed though.
> 
> Did a quick test with MATE and elogind today and it worked well so far but
> one thing: Choosing reboot in MATE only logs you out, returns to the SDDM
> login menu.
> 
> Do I need to change some config too?

NM:
-session        optional        pam_elogind.so
got lost in system-auth, now it works