Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 678730 - >=media-libs/libvpx-1.8.0: "svc" USE flag obsolete
Summary: >=media-libs/libvpx-1.8.0: "svc" USE flag obsolete
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: media-video herd
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-25 05:17 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2020-08-23 08:47 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-02-25 05:17:21 UTC
>=media-libs/libvpx-1.8.0 probably should not have "svc" USE flag at all.
Support for SVC is probably enabled unconditionally by upstream.

In ebuilds:
--- libvpx-1.7.0.ebuild
+++ libvpx-1.8.0.ebuild
...
-               $(use_enable svc experimental) $(use_enable svc spatial-svc)
+               $(use_enable svc experimental)


In libvpx source code:
--- libvpx-1.7.0/configure 
+++ libvpx-1.8.0/configure
...
@@ -273,9 +269,10 @@
     unistd_h
 "
 EXPERIMENT_LIST="
-    spatial_svc
     fp_mb_stats
     emulate_hardware
+    non_greedy_mv
+    ml_var_partition
 "
 CONFIG_LIST="
     dependency_tracking


So --enable-experimental is not needed for support for SVC.

Ebuild does not pass any of --enable-fp-mb-stats, --enable-emulate-hardware, --enable-non-greedy-mv, --enable-ml-var-partition options, so there is no need to pass --enable-experimental option.
Comment 1 Stephan Hartmann gentoo-dev 2020-08-23 08:47:39 UTC
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #0)
> >=media-libs/libvpx-1.8.0 probably should not have "svc" USE flag at all.
> Support for SVC is probably enabled unconditionally by upstream.

It is not enabled unconditionally, but removed completly:
https://chromium.googlesource.com/webm/libvpx/+/0e97e704962390389cab01d7b37f2f97757487fe