Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 677058 - media-gfx/inkscape-0.92.4 needs patching for poppler-0.76.1 and poppler-0.82
Summary: media-gfx/inkscape-0.92.4 needs patching for poppler-0.76.1 and poppler-0.82
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Graphics Project
URL: https://gitlab.com/inkscape/inbox/iss...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-02-01 16:10 UTC by Helmut Jarausch
Modified: 2019-11-16 13:41 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for C++17 for compliance with C++17 (inkscape-0.92.4-c++17.patch,2.04 KB, patch)
2019-02-01 16:10 UTC, Helmut Jarausch
Details | Diff
ebuild applying the patch (inkscape-0.92.4.ebuild,3.73 KB, text/plain)
2019-02-01 16:11 UTC, Helmut Jarausch
Details
patch for gcc-9.1 (inkscape-0.92.4-gcc9.patch,3.96 KB, patch)
2019-05-14 15:51 UTC, Helmut Jarausch
Details | Diff
patch for poppler-0.76.1 (inkscape-0.92.4-poppler.patch,868 bytes, patch)
2019-05-14 15:52 UTC, Helmut Jarausch
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Helmut Jarausch 2019-02-01 16:10:51 UTC
Created attachment 563436 [details, diff]
patch for C++17 for compliance with C++17

When compiling with std=c++17 some errors a detected concerning const comparison operators when using a set.
Note, this always was in error, it just bails out now with C++17.
Comment 1 Helmut Jarausch 2019-02-01 16:11:21 UTC
Created attachment 563438 [details]
ebuild applying the patch
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-02-01 16:19:58 UTC
Would you mind sending this patch to upstream?

They have a gitlab project and are usually quite responsive to pull requests:
https://gitlab.com/inkscape/inkscape
Comment 3 DrSlony 2019-02-27 20:13:55 UTC
Is the addition of media-gfx/inkscape-0.92.4 to portage pending on this issue?
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-02-28 10:49:50 UTC
Once this patch has been accepted by upstream I gonna add it to our package...
Comment 5 DrSlony 2019-02-28 10:55:08 UTC
Great, could you link to the issue on upstream's bug tracker please?
Comment 6 Helmut Jarausch 2019-05-14 15:51:21 UTC
Created attachment 576660 [details, diff]
patch for gcc-9.1
Comment 7 Helmut Jarausch 2019-05-14 15:52:06 UTC
Created attachment 576662 [details, diff]
patch for poppler-0.76.1
Comment 8 Michael 'veremitz' Everitt 2019-06-30 12:54:52 UTC
(In reply to DrSlony from comment #5)
> Great, could you link to the issue on upstream's bug tracker please?

Any progress on this, Helmut?
Comment 9 Jonas Stein gentoo-dev 2019-06-30 22:18:35 UTC
add upstream ticket
Comment 10 Andreas Sturmlechner gentoo-dev 2019-11-11 22:54:12 UTC
How much of this bug is still relevant for 1.0_beta1, considering I am able to build it gcc-9.2 and poppler-0.82?
Comment 11 Andreas K. Hüttel archtester gentoo-dev 2019-11-16 12:47:27 UTC
(In reply to Andreas Sturmlechner from comment #10)
> How much of this bug is still relevant for 1.0_beta1, considering I am able
> to build it gcc-9.2 and poppler-0.82?

1.0_beta1 is *not* ready for stabilization.
Comment 12 Andreas K. Hüttel archtester gentoo-dev 2019-11-16 13:24:50 UTC
Actually, the const problem is caused by poppler-0.82, see upstream commit 324c7903d9fd62e74c042c31477299be3b980fd2
Comment 13 Larry the Git Cow gentoo-dev 2019-11-16 13:25:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e20f1daf5328ec3f6e512e927c892c247394020

commit 3e20f1daf5328ec3f6e512e927c892c247394020
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2019-11-16 13:25:31 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2019-11-16 13:25:43 +0000

    media-gfx/inkscape: Fix build with poppler-0.82
    
    Closes: https://bugs.gentoo.org/677058
    Package-Manager: Portage-2.3.79, Repoman-2.3.18
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 .../files/inkscape-0.92.4-poppler-0.82.0.patch     | 76 ++++++++++++++++++++++
 media-gfx/inkscape/inkscape-0.92.4.ebuild          |  1 +
 2 files changed, 77 insertions(+)