Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 675756 - For new-slot package installation, show USE flags added/deleted in comparison with highest installed other-slot package instance
Summary: For new-slot package installation, show USE flags added/deleted in comparison...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Interface (emerge) (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 671498
  Show dependency tree
 
Reported: 2019-01-18 08:41 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2019-04-10 04:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch (portage.patch,1.56 KB, patch)
2019-01-18 08:44 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-01-18 08:41:54 UTC
For new-slot package installation, I suggest that emerge show USE flags added/deleted in comparison with highest installed other-slot package instance.

Currently such USE flags are not marked in any way, which makes it much harder to notice new features in new versions in new slots. (Users have to manually compare ebuilds or carefully examine emerge output for both currently installed slot and new slot.)


Theoretically some complicated algorithm could be invented for choosing other slot in situations when an older version in separate slot would be installed (e.g. installing sys-devel/gcc:7.4.0 when already installed slots are [6.5.0, 7.3.0, 8.2.0]), but such situations are very rare, so I suggest to not complicate code.


Example output:

Before change:

[ebuild  NS    ] sys-devel/llvm-7.0.1:7::gentoo [5.0.2:5::gentoo, 6.0.1-r2:6::gentoo] USE="gold libffi ncurses xml -debug -doc -exegesis -libedit -test -xar" ABI_X86="32 (64) -x32" LLVM_TARGETS="(X86) -AArch64 -AMDGPU -ARM -BPF -Hexagon -Lanai -MSP430 -Mips -NVPTX -PowerPC -Sparc -SystemZ -XCore" 0 KiB

After change:

[ebuild  NS    ] sys-devel/llvm-7.0.1:7::gentoo [5.0.2:5::gentoo, 6.0.1-r2:6::gentoo] USE="gold libffi ncurses xml -debug -doc -exegesis% -libedit -test -xar" ABI_X86="32 (64) -x32" LLVM_TARGETS="(X86) -AArch64 -AMDGPU -ARM -BPF -Hexagon -Lanai -MSP430 -Mips -NVPTX -PowerPC -Sparc -SystemZ -XCore" 0 KiB

"-exegesis" has gained yellow color and "%" suffix.
Comment 1 Arfrever Frehtes Taifersar Arahesis 2019-01-18 08:44:35 UTC
Created attachment 561926 [details, diff]
Patch
Comment 2 Larry the Git Cow gentoo-dev 2019-01-20 07:24:32 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=9cce0dad3f45b15f8f069a552ac6c91b9dfdd769

commit 9cce0dad3f45b15f8f069a552ac6c91b9dfdd769
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2019-01-18 08:42:09 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2019-01-20 07:05:17 +0000

    emerge: compare new slot USE to installed slot
    
    For new-slot package installation, show USE flags added/deleted in
    comparison with highest installed other-slot package instance
    
    Bug: https://bugs.gentoo.org/675756
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 lib/_emerge/resolver/output.py | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2019-01-21 00:11:42 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7d999af4a47bf55e53e54713d98d145f935935c1

commit 7d999af4a47bf55e53e54713d98d145f935935c1
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2019-01-21 00:01:42 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2019-01-21 00:08:55 +0000

    sys-apps/portage: version bump to 2.3.57
    
     #675756 emerge: compare new SLOT USE to installed SLOT
     #675826 INSTALL_MASK scalability: minimize fnmatch calls
     #675828 pid-sandbox: fix child process signal disposition
    
    Bug: https://bugs.gentoo.org/671498
    Bug: https://bugs.gentoo.org/675756
    Bug: https://bugs.gentoo.org/675826
    Bug: https://bugs.gentoo.org/675828
    Package-Manager: Portage-2.3.57, Repoman-2.3.12
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-2.3.57.ebuild | 271 +++++++++++++++++++++++++++++++++
 2 files changed, 272 insertions(+)
Comment 4 Zac Medico gentoo-dev 2019-04-10 04:31:25 UTC
Fixed in portage-2.3.62.