Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 674994 - net-libs/nodejs-8.15.0 with net-libs/http-parser-2.8.1 - ../src/node_http_parser.cc:759:3: error: ‘http_parser_set_max_header_size’ was not declared in this scope
Summary: net-libs/nodejs-8.15.0 with net-libs/http-parser-2.8.1 - ../src/node_http_par...
Status: RESOLVED DUPLICATE of bug 673830
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-01-09 14:31 UTC by Stefan Strogin
Modified: 2019-01-09 16:24 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Strogin gentoo-dev 2019-01-09 14:31:04 UTC
../src/node_http_parser.cc: In function ‘void node::{anonymous}::InitMaxHttpHeaderSizeOnce()’:
../src/node_http_parser.cc:759:3: error: ‘http_parser_set_max_header_size’ was not declared in this scope
   http_parser_set_max_header_size(max_http_header_size);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The function http_parser_set_max_header_size() was introduced in http-parser-2.9.0:
https://github.com/nodejs/http-parser/commits/master/http_parser.h
(commit 0ae8d93f "support overriding HTTP_MAX_HEADER_SIZE at runtime").

Compilation fails if http-parser-2.8.1 is installed.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-01-09 16:00:48 UTC

*** This bug has been marked as a duplicate of bug 673830 ***
Comment 2 Stefan Strogin gentoo-dev 2019-01-09 16:10:21 UTC
Why duplicate? http-parser-2.8.1_p20181224 is removed from the tree. There are only 2.8.1 (stable) and 2.9.0 now.
http-parser-2.8.1 does not provide http_parser_set_max_header_size(), but on a system with http-parser-2.8.1 portage allows to install net-libs/nodejs-8.15.0 and it fails. Therefore it should depend on http-parser-2.9.0.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2019-01-09 16:19:56 UTC
commit 158698939a7986d533caa8ebdaadf3ca976398ea
Author: Jeroen Roovers <jer@gentoo.org>
Date:   Thu Dec 27 22:24:56 2018 +0100

    net-libs/nodejs: Depend on >net-libs/http-parser-2.8.1:=

    Bug: https://bugs.gentoo.org/673830
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>


That commit changed the dependency from

>=net-libs/http-parser-2.8.0:=

to

 >net-libs/http-parser-2.8.1:=

That is the version should be *greater than* 2.8.1, like 2.9.0.

Your PR requested 

 >net-libs/http-parser-2.9.0:=

which means greater than (but not including) 2.9.0, which doesn't begin to make sense to me.
Comment 4 Stefan Strogin gentoo-dev 2019-01-09 16:24:51 UTC
Oops. I'm not careful enough. Sorry :(