Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 673898 - net-firewall/firehol-3.1.6 kernel config check broken
Summary: net-firewall/firehol-3.1.6 kernel config check broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alon Bar-Lev (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 633688
  Show dependency tree
 
Reported: 2018-12-28 16:37 UTC by Sebastian Pipping
Modified: 2018-12-28 20:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Pipping gentoo-dev 2018-12-28 16:37:25 UTC
Hi!

The kernel config check in 3.1.6 is broken in two regards:

- It does not check anything (because variable KCONFIG_OPTS should be CONFIG_CHECK, instead)

- The list of options to check is incomplete, e.g. these are missing:
  - NETFILTER_XT_CONNMARK
  - NETFILTER_XT_MATCH_HELPER

This is the firehol.conf I'd hope to work out of the box with all checks passed:

  # cat /etc/firehol/firehol.conf
  version 6

  interface "enp+ wlp+" world
          client all accept

Thanks!
Comment 1 Larry the Git Cow gentoo-dev 2018-12-28 19:17:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8d420444471ab784195296b0468170f67af24a35

commit 8d420444471ab784195296b0468170f67af24a35
Author:     Alon Bar-Lev <alonbl@gentoo.org>
AuthorDate: 2018-12-28 19:16:37 +0000
Commit:     Alon Bar-Lev <alonbl@gentoo.org>
CommitDate: 2018-12-28 19:16:37 +0000

    net-firewall/firehol: add additional config options
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=673898
    Thanks: Sebastian Pipping
    Signed-off-by: Alon Bar-Lev <alonbl@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 net-firewall/firehol/firehol-3.1.6.ebuild | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 2 Sebastian Pipping gentoo-dev 2018-12-28 19:41:58 UTC
(In reply to Sebastian Pipping from comment #0)
>> The kernel config check in 3.1.6 is broken in two regards:
>> 
>> - It does not check anything (because variable KCONFIG_OPTS should be
>> CONFIG_CHECK, instead)

Thanks for the quick fix but this part^^ seems unfixed and is essential.

What I do for a test:

  rm /var/tmp/portage/net-firewall/firehol-3.1.6/.setuped
  ebuild firehol-3.1.6.ebuild setup

Thanks!
Comment 3 Alon Bar-Lev (RETIRED) gentoo-dev 2018-12-28 20:09:10 UTC
Oh! it was long broken.
Thanks!!!
Comment 4 Larry the Git Cow gentoo-dev 2018-12-28 20:09:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fb9f5884364430db600f8a2824c1ef2d9c14d0e7

commit fb9f5884364430db600f8a2824c1ef2d9c14d0e7
Author:     Alon Bar-Lev <alonbl@gentoo.org>
AuthorDate: 2018-12-28 20:04:21 +0000
Commit:     Alon Bar-Lev <alonbl@gentoo.org>
CommitDate: 2018-12-28 20:09:22 +0000

    net-firewall/firehol: use CONFIG_CHECK to actually check configuration
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=673898
    Thanks: Sebastian Pipping
    Signed-off-by: Alon Bar-Lev <alonbl@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 net-firewall/firehol/firehol-3.1.3-r1.ebuild | 2 +-
 net-firewall/firehol/firehol-3.1.3.ebuild    | 2 +-
 net-firewall/firehol/firehol-3.1.4.ebuild    | 2 +-
 net-firewall/firehol/firehol-3.1.6.ebuild    | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)