Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 672356 - media-video/vcdimager-0.7.24 fails to build against dev-libs/libcdio-2.0.0, both are stable
Summary: media-video/vcdimager-0.7.24 fails to build against dev-libs/libcdio-2.0.0, b...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: PullRequest
Depends on: CVE-2017-18201
Blocks:
  Show dependency tree
 
Reported: 2018-12-01 21:05 UTC by David Racine
Modified: 2019-01-09 21:36 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix build error with libcdio-2 (vcdimager-libcdio-2.0.0-compat.patch,11.31 KB, patch)
2018-12-01 21:08 UTC, David Racine
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Racine 2018-12-01 21:05:17 UTC
Build failed because some fonctions in libcdio-2 needs more/less arguments.

Reproducible: Always

Steps to Reproduce:
1. Update libcdio to version 2 (stable)
2. Build vcdimager
Actual Results:  
Build fails!

Expected Results:  
Builds and install!
Comment 1 David Racine 2018-12-01 21:08:16 UTC
Created attachment 556898 [details, diff]
Fix build error with libcdio-2

Here is a patch that fix the build error.
Comment 2 Alexander Bezrukov 2018-12-02 06:20:04 UTC
Alternative to applying this patch is to stabilize vcdimager-2.0.1 which compiles with libcdio-2.0.0-r1.
Comment 3 Eduardo Coutinho Scalabrin 2018-12-02 13:59:42 UTC
I have here the same error.
Comment 4 Israel G. Lugo 2018-12-02 20:34:58 UTC
Confirmed.

Context: Bug #641550 solved an incompatibility between media-video/vcdimager and >=dev-libs/libcdio-1.0. But it did so for new versions of media-video/vcdimager, not the current stable =media-video/vcdimager-0.7.24.

This went unnoticed until now because all versions of dev-libs/libcdio above 0.93 were marked testing. But dev-libs/libcdio-2.0.0-r1 was recently marked stable (bug #671964), and is now breaking stable =media-video/vcdimager-0.7.24.

Please change dependencies on =media-video/vcdimager-0.7.24 to depend on <dev-libs/libcdio-1.0. I am aware that =media-video/vcdimager-2.0.1 is being stabilized (bug #648954, security update), but that doesn't change the fact that 0.7.24 doesn't build with libcdio-2.
Comment 5 Craig Andrews gentoo-dev 2018-12-09 21:45:17 UTC
Not sure why this is assigned to me, I'm not maintainer of either dev-libs/libcdio or media-video/vcdimager.

Assigning to media-video@gentoo.org
Comment 6 Larry the Git Cow gentoo-dev 2019-01-09 21:36:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fba13345a93bd4ce6ee37db672b70209672aaa9d

commit fba13345a93bd4ce6ee37db672b70209672aaa9d
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2018-12-13 14:55:34 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2019-01-09 21:34:35 +0000

    media-video/vcdimager: 0.7.24 depends on <dev-libs/libcdio-1.0
    
    Closes: https://bugs.gentoo.org/672356
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 media-video/vcdimager/vcdimager-0.7.24.ebuild | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)