672028 – app-arch/zstd-1.3.7-r1 bundles a copy of dev-libs/xxhash-0.6.2

Bug 672028 - app-arch/zstd-1.3.7-r1 bundles a copy of dev-libs/xxhash-0.6.2

Summary: app-arch/zstd-1.3.7-r1 bundles a copy of dev-libs/xxhash-0.6.2

Status:	RESOLVED UPSTREAM

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Patrick Lauer

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	bundled-libs
	Show dependency tree

Reported:	2018-11-26 21:00 UTC by Jeroen Roovers (RETIRED)
Modified:	2019-01-22 12:25 UTC (History)
CC List:	2 users (show)

See Also:	672024
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jeroen Roovers (RETIRED) gentoo-dev

2018-11-26 21:00:25 UTC

See lib/common/xxhash.h:

/* *************************************
*  Version
***************************************/
#define XXH_VERSION_MAJOR    0
#define XXH_VERSION_MINOR    6
#define XXH_VERSION_RELEASE  2

Comment 1 Thomas Deutschmann (RETIRED) gentoo-dev

2018-12-01 19:57:34 UTC

I am closing this as UPSTREAM: It is correct that zstd contains xxhash source files (derived from v0.6.2). However, they are not *just* bundling xxhash -- they have renamed all symbols for example (see https://github.com/facebook/zstd/issues/570#issuecomment-283224279). So this is something upstream must solve but I doubt they are interested in that.