Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 671900 - games-emulation/dolphin-9999 fails to build due to upstream adding bundled minizip library
Summary: games-emulation/dolphin-9999 fails to build due to upstream adding bundled mi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sergei Trofimovich (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-25 20:44 UTC by Richard Yao (RETIRED)
Modified: 2022-10-02 03:06 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log showing failure (build.log,28.42 KB, text/x-log)
2018-11-25 20:44 UTC, Richard Yao (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Yao (RETIRED) gentoo-dev 2018-11-25 20:44:45 UTC
Created attachment 556262 [details]
build.log showing failure

Upstream added a new bundled library in the form of Externals/minizip:

https://github.com/dolphin-emu/dolphin/commit/e6b2758ab401975c0bde2b80bec5b05485c25c5a

Until  we can get it to use our minizip, we will need to add it to KEEP_SOURCES in the ebuild.
Comment 1 Larry the Git Cow gentoo-dev 2018-11-25 21:45:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2f26b496e55dddef5d8fce650becb4c3db4cc450

commit 2f26b496e55dddef5d8fce650becb4c3db4cc450
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2018-11-25 21:41:44 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-11-25 21:44:53 +0000

    games-emulation/dolphin: whitelist minizip, bug #671900
    
    Richard reports build failure against live ebuild after
    https://github.com/dolphin-emu/dolphin/commit/e6b2758ab401975c0bde2b80bec5b05485c25c5a
    upstream update:
      CMake Error at CMakeLists.txt:565 (add_subdirectory):
        add_subdirectory given source "Externals/minizip" which
        is not an existing directory.
    
    Allow using stripped down minizip.
    
    Reported-by: Richard Yao
    Closes: https://bugs.gentoo.org/671900
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 games-emulation/dolphin/dolphin-9999.ebuild | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 2 Sergei Trofimovich (RETIRED) gentoo-dev 2018-11-25 22:32:36 UTC
Thanks for the report!