Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 671258 - webapp.eclass is not EAPI=7 compatible
Summary: webapp.eclass is not EAPI=7 compatible
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Web-apps project
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2018-11-16 10:55 UTC by Ian Pickworth
Modified: 2019-02-21 10:29 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
webapps.eclass.patch (webapps.eclass.patch,637 bytes, patch)
2018-11-16 20:40 UTC, Conrad Kostecki
Details | Diff
0001-eclass-webapp.eclass-fix-ROOT-path-with-EAPI-7.patch (0001-eclass-webapp.eclass-fix-ROOT-path-with-EAPI-7.patch,2.50 KB, patch)
2018-11-16 21:32 UTC, Conrad Kostecki
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Pickworth 2018-11-16 10:55:51 UTC
Emerge of www-apps/phpsysinfo 3.2.10-r1 yielded this output:

* Package:    www-apps/phpsysinfo-3.2.10-r1
 * Repository: gentoo
 * Maintainer: ck+gentoo@bl4ckb0x.de proxy-maint@gentoo.org,web-apps@gentoo.org
 * Upstream:   https://github.com/phpsysinfo/phpsysinfo/issues
 * USE:        abi_x86_32 elibc_glibc kernel_linux userland_GNU x86
 * FEATURES:   sandbox userpriv usersandbox
/usr/portage/eclass/webapp.eclass: line 59: usr/sbin/webapp-config: No such file
 or directory
 * ERROR: www-apps/phpsysinfo-3.2.10-r1::gentoo failed (setup phase):
 *   Could not read settings from webapp-config!
 * 
 * Call stack:
 *       ebuild.sh, line 124:  Called pkg_setup
 *       ebuild.sh, line 371:  Called webapp_pkg_setup
 *   webapp.eclass, line 390:  Called webapp_read_config
 *   webapp.eclass, line  59:  Called die
 * The specific snippet of code:
 *              ENVVAR=$(${WEBAPP_CONFIG} --query ${PN} ${PVR}) || die "Could not read settings from webapp-config!"


this line:
  /usr/portage/eclass/webapp.eclass: line 59: usr/sbin/webapp-config

There is a missing "/" in front of "usr/sbin/webapp-config"
Comment 1 Conrad Kostecki gentoo-dev 2018-11-16 20:40:48 UTC
Created attachment 555362 [details, diff]
webapps.eclass.patch

Wouldn't that patch fix it?
Comment 2 Conrad Kostecki gentoo-dev 2018-11-16 21:32:20 UTC
Created attachment 555364 [details, diff]
0001-eclass-webapp.eclass-fix-ROOT-path-with-EAPI-7.patch
Comment 3 Ian Pickworth 2018-11-26 14:33:30 UTC
I applied the patch to my local copy of webapp.eclass
and emerged www-apps/phpsysinfo-3.2.10-r1

Worked OK, so patch cures the problem, thanks.

I see a pull request in the bug log - but my local copy (emerge --sync last night 26 Nov) was still in original form. I guess something else has to happen to distribute the fixed webapp.eclass ?
Comment 4 Conrad Kostecki gentoo-dev 2018-11-29 16:00:42 UTC
*** Bug 672232 has been marked as a duplicate of this bug. ***
Comment 5 Larry the Git Cow gentoo-dev 2019-02-21 10:29:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c317f1194eeb7e9b10fa7f8845b62d0d575a1733

commit c317f1194eeb7e9b10fa7f8845b62d0d575a1733
Author:     Conrad Kostecki <conrad@kostecki.com>
AuthorDate: 2019-02-19 21:03:09 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-02-21 10:29:09 +0000

    eclass/webapp.eclass: fix install with EAPI=7
    
    Starting with EAPI=7 the ROOT variable does not contain any trailing
    slash anymore, so it need's to be adjusted to work with EAPI=7, while
    maintaining compatibility with older EAPI.
    
    Closes: https://bugs.gentoo.org/671258
    Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
    Closes: https://github.com/gentoo/gentoo/pull/11112
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 eclass/webapp.eclass | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)