Sometimes ebuild using meson.eclass might need to pass additional arguments to ninja. It would be more convenient if it was possible to do: src_compile() { meson_src_compile some_argument } Instead of: src_compile() { eninja -C "${BUILD_DIR}" some_argument }
Created attachment 554702 [details, diff] Patch
I think we should create a variable, eninjaargs, that works like emesonargs to be consistent with how we pass arguments to meson. What do you think?
meson_src_configure() function supports 2 ways of passing arguments (which can be combined): 1. Passing arguments directly to meson_src_configure() function. meson_src_configure arg1 arg2 ... 2. Setting emesonargs array. emesonargs=(arg1 arg2 ...) meson_src_configure Arguments passed directly to meson_src_configure() function take precedence over arguments set in emesonargs array.
It does, but I don't remember the reason we supported passing arguments to the src_configure function like this. The documented method in the eclass is to use the e*args variable.
The emesonargs variable seems pretty redundant to me. The only benefit I can see is that it encourages developers to use array syntax instead of ugly backslash escapes for passing values on multiple lines. But that would be accomplished just as easily by passing an array as function arguments instead. Passing arguments to meson_src_compile and meson_src_install seems acceptable to me. This also has precedent in other similar eclasses like cmake-utils, which pass "$@" to either make or ninja in src_compile and src_install. I would rather not invent another variable for passing arguments to ninja.
In the meantime, meson_src_test() was changed to use 'meson test' instead of 'ninja test' and it now uses "$@" properly: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fe02c66d4b7638575778dcb7cbeb09c42a83c764 https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e9c146e4335d47d61e415efa81f002e600e226f6 Only meson_src_compile() and meson_src_install() still need to be fixed.
Created attachment 587064 [details, diff] Patch
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=16b26361305e37258317cae0b29327de732e83c7 commit 16b26361305e37258317cae0b29327de732e83c7 Author: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org> AuthorDate: 2018-11-09 20:39:48 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2019-08-19 19:24:51 +0000 meson.eclass: meson_src_{compile,install}: Pass "$@" to eninja. Closes: https://bugs.gentoo.org/670788 Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org> Signed-off-by: Mike Gilbert <floppym@gentoo.org> eclass/meson.eclass | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
