Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 669548 - www-client/firefox-63.0 fails to build ff/toolkit/library/x86_64-unknown-linux-gnu/release/build/style-94bc691f5157d254/out/gecko/bindings.rs:640:5 ^ unexpected token
Summary: www-client/firefox-63.0 fails to build ff/toolkit/library/x86_64-unknown-linu...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-25 00:49 UTC by Patrick McLean
Modified: 2018-10-25 17:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (xzipped) (build.log.xz,251.41 KB, application/octet-stream)
2018-10-25 00:49 UTC, Patrick McLean
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick McLean gentoo-dev 2018-10-25 00:49:11 UTC
Created attachment 552842 [details]
build.log (xzipped)

This is pretty reliable on 3 different machines. Here is my emerge --info, also attaching build.log

$ emerge --info firefox
Portage 2.3.51 (python 3.6.6-final-0, default/linux/amd64/17.1, gcc-8.2.0, glibc-2.27-r6, 4.18.11 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.18.11-x86_64-Intel-R-_Core-TM-_i9-7900X_CPU_@_3.30GHz-with-gentoo-2.6
KiB Mem:    65710128 total,  13193524 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Wed, 24 Oct 2018 23:45:01 +0000
Head commit of repository gentoo: 438d30637d54082fcfe3137ca8dd23636b6837f7
sh bash 4.4_p23
ld GNU ld (Gentoo 2.31.1 p3) 2.31.1
app-shells/bash:          4.4_p23::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.26.2::gentoo
dev-lang/python:          2.7.15::gentoo, 3.4.8-r1::gentoo, 3.6.6::gentoo, 3.7.0::gentoo
dev-util/cmake:           3.12.3::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.39.1::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.16.1-r1::gentoo
sys-devel/binutils:       2.31.1-r1::gentoo
sys-devel/gcc:            8.2.0-r3::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r5::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.19::gentoo (virtual/os-headers)
sys-libs/glibc:           2.27-r6::gentoo
Repositories:

gentoo
    location: /var/portage/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://gentoo.gaikai.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-extra-opts: 
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-max-age: 24

chutzpah
    location: /home/chutz/gentoo-overlay
    masters: gentoo
    priority: 0

mozilla
    location: /home/chutz/src/mozilla
    masters: gentoo

gentoo-local
    location: /home/chutz/gentoo-local
    masters: gentoo
    priority: 1

local-overlay
    location: /home/chutz/local-overlay
    masters: gentoo
    priority: 2

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=native -mindirect-branch=thunk -frecord-gcc-switches -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/chromium/pepper-flash /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -march=native -mindirect-branch=thunk -frecord-gcc-switches -pipe"
DISTDIR="/var/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -march=native -mindirect-branch=thunk -frecord-gcc-switches -pipe"
FEATURES="assume-digests binpkg-logs compressdebug config-protect-if-modified distlocks ebuild-locks fakeroot fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch preserve-libs protect-owned sandbox sfperms sign splitdebug strict strict-keepdir unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -march=native -mindirect-branch=thunk -frecord-gcc-switches -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
INSTALL_MASK="/usr/lib/systemd/system /lib/systemd/system"
LANG="en_CA.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en_CA en_GB en_US en"
MAKEOPTS="-j28 -l21"
PKGDIR="/var/portage/packages"
PORTAGE_COMPRESS="xz"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X aac acl acpi alsa amd64 apng bash-completion brotli bzip2 cairo caps cli consolekit crypt cups curl cxx dbus device-mapper dri exif ffmpeg fftw flac fuse gif git glamor gles2 gmp gnome-keyring gtk gtk3 iconv ipv6 ithreads jbit jpeg jpeg2k lcms libffi libinput libnotify libtirpc lzma lzo mad mmap mmx mmxext mng mp3 multilib ncurses networking nptl ogg openal opengl openmp openssl opus pam pdf png pnm policykit python readline seccomp sndfile spell sqlite sse sse2 sse3 sse4_1 ssl ssse3 startup-notification svg theora threads tiff truetype udev unicode usb vaapi vdpau vim vim-syntax vorbis vpx x264 xattr xcb xinerama xorg xv zlib zsh-completion" ABI_X86="64 32" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon plan sheets stage words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 avx512f avx512dq avx512cd avx512bw avx512vl f16c fma3 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" CURL_SSL="openssl" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64 pc" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en-CA en-GB en-US en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" NGINX_MODULES_HTTP="access auth_basic autoindex browser charset gzip proxy referer rewrite fancyindex" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-1" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_4 python3_6 python3_7" RUBY_TARGETS="ruby25" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi" XFCE_PLUGINS="clock" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

www-client/firefox-62.0.3::gentoo was built with the following:
USE="custom-cflags dbus gmp-autoupdate hwaccel screenshot startup-notification system-harfbuzz system-icu system-jpeg system-libevent system-libvpx system-sqlite -bindist -clang -custom-optimization -debug -eme-free -geckodriver -hardened -jack -lto (-neon) -pulseaudio (-selinux) -test -wifi" ABI_X86="(64)" L10N="en-GB -ach -af -an -ar -as -ast -az -bg -bn-BD -bn-IN -br -bs -ca -cak -cs -cy -da -de -dsb -el -en-ZA -eo -es-AR -es-CL -es-ES -es-MX -et -eu -fa -ff -fi -fr -fy -ga -gd -gl -gn -gu -he -hi -hr -hsb -hu -hy -id -is -it -ja -ka -kab -kk -km -kn -ko -lij -lt -lv -mai -mk -ml -mr -ms -nb -nl -nn -or -pa -pl -pt-BR -pt-PT -rm -ro -ru -si -sk -sl -son -sq -sr -sv -ta -te -th -tr -uk -uz -vi -xh -zh-CN -zh-TW"
CFLAGS="-march=native -mindirect-branch=thunk -frecord-gcc-switches -pipe"
CXXFLAGS="-march=native -mindirect-branch=thunk -frecord-gcc-switches -pipe -fno-delete-null-pointer-checks -fno-lifetime-dse -fno-schedule-insns -fno-schedule-insns2"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,-rpath=/usr/lib64/firefox,--enable-new-dtags"
Comment 1 Patrick McLean gentoo-dev 2018-10-25 00:49:56 UTC
The exact error:

 5:47.81 /var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/dom/canvas/OffscreenCanvas.cpp:344:3: note: in expansion of macro 'NS_INTERFACE_MAP_ENTRY'
 5:47.81    NS_INTERFACE_MAP_ENTRY(nsISupports)                  
 5:47.81    ^~~~~~~~~~~~~~~~~~~~~~                                                         
 5:51.33 gmake[4]: Leaving directory '/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/ff/dom/canvas'
 5:57.45    Compiling style v0.0.1 (file:///var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/servo/components/style)
 6:14.23 error: expected one of `crate`, `fn`, `pub`, `static`, `type`, or `}`, found `;`                             
 6:14.23    --> /var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/ff/toolkit/library/x86_64-unknown-linux-gnu/release/build/style-94bc691f5157d254/out/gecko/bindings.rs:640:5
 6:14.23     |                                                                                
 6:14.23 639 | extern "C" {                                                                  
 6:14.23     |             - expected one of `crate`, `fn`, `pub`, `static`, `type`, or `}` here  
 6:14.23 640 |     ;                                                                                                                                                                                                                                                                                                                                                                                                                                                                          
 6:14.23     |     ^ unexpected token                                             
 6:14.25 error: aborting due to previous error                                          
 6:14.26 error: Could not compile `style`.
 6:14.26 warning: build failed, waiting for other jobs to finish...        
 7:06.40 error: build failed                                                                                                                                                                                                                                                                                                                                                                                                                                                                  
 7:06.41 gmake[4]: *** [/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/config/rules.mk:1030: force-cargo-library-build] Error 101
 7:06.41 gmake[4]: Leaving directory '/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/ff/toolkit/library/rust'
 7:06.41 gmake[3]: *** [/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/config/recurse.mk:74: toolkit/library/rust/target] Error 2
 7:06.41 gmake[3]: Leaving directory '/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/ff'
 7:06.41 gmake[2]: *** [/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/config/recurse.mk:34: compile] Error 2
 7:06.41 gmake[2]: Leaving directory '/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/ff'
 7:06.41 gmake[1]: *** [/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/config/rules.mk:432: default] Error 2
 7:06.41 gmake[1]: Leaving directory '/var/tmp/portage/www-client/firefox-63.0/work/firefox-63.0/ff'
 7:06.41 gmake: *** [client.mk:150: build] Error 2       
 7:06.45 0 compiler warnings present.
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2018-10-25 09:36:14 UTC
I cannot reproduce and haven't seen this before. All I found was https://bugzilla.mozilla.org/show_bug.cgi?id=1432514 and the solution was to upgrade 'rustfmt'.

I don't have "rustfmt" on my system:
-bash: rustfmt: command not found

Do you have "rustfmt" somehow on your system? I am currently trying to build firefox again with dev-util/rustfmt-0.8.6 installed to see if this will cause any failures.
Comment 3 Thomas Deutschmann (RETIRED) gentoo-dev 2018-10-25 10:55:46 UTC
I can reproduce when dev-util/rustfmt-0.8.6 is installed.
Comment 4 Larry the Git Cow gentoo-dev 2018-10-25 12:38:21 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9a1471422a7efdeb89d7d561d54914197a543627

commit 9a1471422a7efdeb89d7d561d54914197a543627
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2018-10-25 12:37:52 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2018-10-25 12:38:12 +0000

    dev-util/rustfmt: bump to v0.9.0
    
    Bug: https://bugs.gentoo.org/669548
    Package-Manager: Portage-2.3.51, Repoman-2.3.11
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 dev-util/rustfmt/Manifest             |  1 +
 dev-util/rustfmt/rustfmt-0.9.0.ebuild | 62 +++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)
Comment 5 Thomas Deutschmann (RETIRED) gentoo-dev 2018-10-25 12:45:19 UTC
It looks like it works somehow with rustfmt-0.9.0 (which I don't understand because I think we need https://github.com/rust-lang-nursery/rustfmt/commit/97d29ff2e17ab1b259d9acc9010c72d2b6870f73 which is only present in rustfmt nightly I cannot create an ebuild for due to "nightly" in the name cargo eclass doesn't support). So please update...

At this step I don't really want to add rustfmt as dependency. I am trying to disable external rustfmt usage because it isn't required...
Comment 6 Larry the Git Cow gentoo-dev 2018-10-25 17:28:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e530a268c3003ad7455cad8fe0b5b8bf23f8f21a

commit e530a268c3003ad7455cad8fe0b5b8bf23f8f21a
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2018-10-25 17:27:25 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2018-10-25 17:28:00 +0000

    www-client/firefox: don't use rustfmt
    
    In addition, move eapply_user to the beginning of src_prepare to increase
    the chance to apply upstream patches without the need for changes.
    
    Closes: https://bugs.gentoo.org/669548
    Package-Manager: Portage-2.3.51, Repoman-2.3.11
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 www-client/firefox/firefox-63.0.ebuild | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)