Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 665058 - =app-editors/emacs-26.1 is compiled without imagemagick support when imagemagick 7 is installed
Summary: =app-editors/emacs-26.1 is compiled without imagemagick support when imagemag...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: GNU Emacs project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: imagemagick-7
  Show dependency tree
 
Reported: 2018-09-01 19:56 UTC by Gleb
Modified: 2018-09-17 19:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
02_all_imagemagick-7.patch (02_all_imagemagick-7.patch,3.81 KB, patch)
2018-09-02 07:25 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gleb 2018-09-01 19:56:26 UTC
emacs-26.1 currently supports imagemagick 6, v. 7 is not supported. 

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25967

the problem is there's no warning about it. it is also not possible to install both imagemagick 6 and 7, and the 7 is the default (if not masked).
Comment 1 Gleb 2018-09-01 20:02:18 UTC
support will be added in emacs 27:
https://github.com/emacs-mirror/emacs/commit/5729486951e6a60db55ea17ee3bac9baf8b54f6a
Comment 2 Larry the Git Cow gentoo-dev 2018-09-02 06:40:31 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0933d84219f537986a283bfae5f138a81eb5be4f

commit 0933d84219f537986a283bfae5f138a81eb5be4f
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2018-09-02 06:39:28 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2018-09-02 06:40:19 +0000

    app-editors/emacs-vcs: Depend on <media-gfx/imagemagick-7.
    
    Bug: https://bugs.gentoo.org/665058
    Package-Manager: Portage-2.3.48, Repoman-2.3.10

 app-editors/emacs-vcs/emacs-vcs-26.1.9999.ebuild           | 3 ++-
 app-editors/emacs-vcs/emacs-vcs-27.0.50_pre20180731.ebuild | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=208a29262c64fe6a3a1545a0be65bd78f77e9a63

commit 208a29262c64fe6a3a1545a0be65bd78f77e9a63
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2018-09-02 06:37:47 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2018-09-02 06:40:18 +0000

    app-editors/emacs: Depend on <media-gfx/imagemagick-7.
    
    Bug: https://bugs.gentoo.org/665058
    Package-Manager: Portage-2.3.48, Repoman-2.3.10

 app-editors/emacs/emacs-24.5-r5.ebuild | 3 ++-
 app-editors/emacs/emacs-24.5-r6.ebuild | 3 ++-
 app-editors/emacs/emacs-25.3-r4.ebuild | 3 ++-
 app-editors/emacs/emacs-25.3-r5.ebuild | 3 ++-
 app-editors/emacs/emacs-26.1-r1.ebuild | 3 ++-
 app-editors/emacs/emacs-26.1-r2.ebuild | 3 ++-
 6 files changed, 12 insertions(+), 6 deletions(-)
Comment 3 Ulrich Müller gentoo-dev 2018-09-02 06:50:02 UTC
I've added a dependency on <imagemagick-7 for now. Looks like the following upstream commits need to be backported to previous versions:

5729486951 Support ImageMagick version 7 (bug#25967)
bf1b147b55 * configure.ac, src/image.c: Tweak previous ImageMagick change.
42ed35c68b Pacify -Wdouble-promotion in ImageMagick code
3cc42bb600 * configure.ac: Fix goofs in my recent ImageMagick change.
Comment 4 Ulrich Müller gentoo-dev 2018-09-02 07:25:56 UTC
Created attachment 545762 [details, diff]
02_all_imagemagick-7.patch

Please test if attached patch fixes the problem.

Instructions:
- Save the patch in /etc/portage/patches/app-editors/emacs-26.1/
- Add "autotools" to the ebuild's "inherit" line
- Uncomment "AT_M4DIR=m4 eautoreconf" (last line in src_prepare)
Comment 5 Larry the Git Cow gentoo-dev 2018-09-02 11:16:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=599a1b010fa1ff7f0f88763840dfaa3d92a08273

commit 599a1b010fa1ff7f0f88763840dfaa3d92a08273
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2018-09-02 10:54:30 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2018-09-02 11:15:53 +0000

    app-editors/emacs: Fix support for >=media-gfx/imagemagick-7.
    
    Closes: https://bugs.gentoo.org/665058
    Package-Manager: Portage-2.3.48, Repoman-2.3.10

 app-editors/emacs/Manifest                                    |  3 +++
 .../emacs/{emacs-24.5-r6.ebuild => emacs-24.5-r7.ebuild}      |  5 ++---
 .../emacs/{emacs-25.3-r5.ebuild => emacs-25.3-r6.ebuild}      | 11 +++++------
 .../emacs/{emacs-26.1-r2.ebuild => emacs-26.1-r3.ebuild}      |  9 ++++-----
 4 files changed, 14 insertions(+), 14 deletions(-)
Comment 6 Ulrich Müller gentoo-dev 2018-09-02 11:17:13 UTC
(In reply to Ulrich Müller from comment #4)
> Please test if attached patch fixes the problem.

Or easier, test app-editors/emacs-26.1-r3.