Created attachment 545722 [details] gtkdiskfree-2.0.3.ebuild Updated SRC_URI: No need to inherit vcs-snapshot Use EAPI 7 Fix headers to make repoman happy
Thanks, please always attach unified diffs rather than full ebuilds to make easy review possible.
Created attachment 546804 [details, diff] /mnt/win/e/gtkdiskfree-2.0.3.ebuild.patch Patch to current gtkdiskfree-2.0.3 version The old-color-selector flag allows one to use gtk2 color selector with gtk3 For now it is a compile time option, it'll soon be a runtime option.
Comment on attachment 546804 [details, diff] /mnt/win/e/gtkdiskfree-2.0.3.ebuild.patch I'm sorry that nobody looked at this before. >--- /usr/portage/app-admin/gtkdiskfree/gtkdiskfree-2.0.3.ebuild 2017-03-01 18:35:46.000000000 +0100 >+++ /mnt/gentoo/overlay/sam/app-admin/gtkdiskfree/gtkdiskfree-2.0.3.ebuild 2018-09-13 14:54:22.778399526 +0200 >@@ -1,18 +1,16 @@ >-# Copyright 1999-2016 Gentoo Foundation >+# Copyright 1999-2018 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 > >-EAPI=6 >- >-inherit vcs-snapshot >+EAPI=7 > > DESCRIPTION="Graphical tool to show free disk space like df" > HOMEPAGE="https://gitlab.com/mazes_80/gtkdiskfree" >-SRC_URI="https://gitlab.com/mazes_80/${PN}/repository/archive.tar.bz2?ref=${PV} -> ${P}.tar.bz2" >+SRC_URI="https://gitlab.com/mazes_80/${PN}/-/archive/${PV}/${P}.tar.bz2" > > LICENSE="GPL-2+" > SLOT="0" > KEYWORDS="~amd64 ~ia64 ~ppc ~ppc64 ~sparc ~x86" >-IUSE="gtk2" >+IUSE="gtk2 old-color-selector" You also need to describe this flag in metadata.xml. > > RDEPEND=" > gtk2? ( x11-libs/gtk+:2 ) >@@ -24,5 +22,6 @@ > " > > src_configure() { >- econf $(use_with gtk2) >+ econf $(use_with gtk2) \ >+ $(! use gtk2 && use_enable old-color-selector) 'use gtk2 ||' is generally considered more obvious. > }
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=faca8e5bf131adecf368e32a329ac725c65ae307 commit faca8e5bf131adecf368e32a329ac725c65ae307 Author: Henrik Pihl <ahvenas@gmail.com> AuthorDate: 2020-08-01 09:53:53 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2020-08-15 09:29:45 +0000 app-admin/gtkdiskfree: version bump, move to EAPI 7 - Use the latest commit for this release, fixes lot of UI related visual issues not in a release yet. - Not using a separate USE flag for gtk 3 and the old color selector, as initially suggested in the bug. Closes: https://bugs.gentoo.org/665026 Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Henrik Pihl <ahvenas@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/16925 Signed-off-by: Joonas Niilola <juippis@gentoo.org> app-admin/gtkdiskfree/Manifest | 1 + .../gtkdiskfree/gtkdiskfree-2.0.4_p20200224.ebuild | 33 ++++++++++++++++++++++ 2 files changed, 34 insertions(+)
