Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 663924 - =sys-devel/m4-1.4.18: build failure against glibc-2.28: fseeko.c:110:4: error: #error "Please port gnulib fseeko.c to your platform! Look at the code in fseeko.c, then report this to bug-gnulib."
Summary: =sys-devel/m4-1.4.18: build failure against glibc-2.28: fseeko.c:110:4: error...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH
: 675290 (view as bug list)
Depends on:
Blocks: glibc-2.28
  Show dependency tree
 
Reported: 2018-08-17 22:09 UTC by Sergei Trofimovich (RETIRED)
Modified: 2020-05-12 17:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
sys-devel:m4-1.4.18:20180817-220710.log (sys-devel:m4-1.4.18:20180817-220710.log,154.77 KB, text/x-log)
2018-08-17 22:09 UTC, Sergei Trofimovich (RETIRED) 		Details
allow m4 to compile with glibc-2.28 (m4-glibc228.patch,13.37 KB, patch)
2018-09-22 15:42 UTC, milan hodoscek 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Trofimovich (RETIRED) gentoo-dev 2018-08-17 22:09:43 UTC 
Created attachment 543858 [details]
sys-devel:m4-1.4.18:20180817-220710.log

fseeko.c: In function 'rpl_fseeko':
fseeko.c:110:4: error: #error "Please port gnulib fseeko.c to your platform! Look at the code in fseeko.c, then report this to bug-gnulib."
   #error "Please port gnulib fseeko.c to your platform! Look at the code in fseeko.c, then report this to bug-gnulib."
    ^~~~~
Comment 1 cyrillic 2018-09-17 00:21:19 UTC 
I am seeing this same error in sys-devel/m4-1.4.18 , sys-apps/findutils-4.6.0-r1 , and app-arch/gzip-1.9 .

It is because the bundled gnulib is too old.

This has been fixed upstream for findutils and gzip, but m4 has not been touched in quite a long time.
Comment 2 milan hodoscek 2018-09-22 15:42:25 UTC 
Created attachment 547520 [details, diff]
allow m4 to compile with glibc-2.28

This allows to compile m4 with glibc-2.28 installed

add epatch_user in ebuild
and put the patch into /etc/portage/patches/sys-devel/m4-1.4.18
Comment 3 Sergei Trofimovich (RETIRED) gentoo-dev 2018-09-22 18:34:34 UTC 
Thanks for the patch!
Comment 4 cyrillic 2018-09-23 20:03:50 UTC 
Thank you, m4 compiles fine now.
Comment 5 Larry the Git Cow gentoo-dev 2018-10-13 17:50:49 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a31c6c21fb030d75256ff042e0352f90330545b2

commit a31c6c21fb030d75256ff042e0352f90330545b2
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2018-10-13 17:21:38 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-10-13 17:50:35 +0000

    sys-devel/m4: fix build against glibc-2.28, bug #663924
    
    Patch by milan hodoscek.
    
    While at it added 'epatch_user'.
    
    Closes: https://bugs.gentoo.org/663924
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 sys-devel/m4/files/m4-1.4.18-glibc228.patch | 310 ++++++++++++++++++++++++++++
 sys-devel/m4/m4-1.4.18.ebuild               |   4 +-
 2 files changed, 313 insertions(+), 1 deletion(-)
Comment 6 ernsteiswuerfel archtester 2019-01-12 22:08:08 UTC 
*** Bug 675290 has been marked as a duplicate of this bug. ***
Comment 7 Benda Xu gentoo-dev 2020-05-12 09:59:10 UTC 
Has anyone forwarded the patch upstream?
Comment 8 Sergei Trofimovich (RETIRED) gentoo-dev 2020-05-12 17:19:45 UTC 
(In reply to Benda Xu from comment #7)
> Has anyone forwarded the patch upstream?

I believe m4 uses gnulib and just needs to cut a new release against updated upstream gnulib. Probably worth mailing bug-m4@gnu.org to ask for one. Gentoo's m4 maintainer should be able to give more details.