Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 662816 - dev-db/mysql-5.7.23 missing include in regex/CMakeLists.txt: Unknown CMake command "ADD_COMPILE_FLAGS"
Summary: dev-db/mysql-5.7.23 missing include in regex/CMakeLists.txt: Unknown CMake co...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux MySQL bugs team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-08-05 03:37 UTC by Matt Whitlock
Modified: 2019-02-23 17:30 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to define ADD_COMPILE_FLAGS in regex/CMakeLists.txt (regex-CMakeLists-include-compile_flags.patch,441 bytes, patch)
2018-08-05 03:37 UTC, Matt Whitlock
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Whitlock 2018-08-05 03:37:55 UTC
Created attachment 542416 [details, diff]
patch to define ADD_COMPILE_FLAGS in regex/CMakeLists.txt

Evidently upstream didn't fully test the scenario in which the C compiler supports the -Wstringop-truncation flag. Building with sys-devel/gcc-8.2.0 elicits the following error during src_configure:

CMake Error at regex/CMakeLists.txt:20 (ADD_COMPILE_FLAGS):
  Unknown CMake command "ADD_COMPILE_FLAGS".

The attached patch corrects the problem by including the missing definition of CMake macro ADD_COMPILE_FLAGS into regex/CMakeLists.txt.
Comment 2 Sergey Galkin 2018-10-01 09:43:49 UTC
Fixed in  5.7.24 https://bugs.mysql.com/bug.php?id=91914 but in portage still 5.7.23
Comment 3 Jorge Manuel B. S. Vicetto (RETIRED) Gentoo Infrastructure gentoo-dev 2018-10-01 11:45:24 UTC
https://dev.mysql.com/downloads/mysql/5.7.html#downloads

There's no 5.7.24 release yet.
The comment in the bug likely means they've added the fix to the branch and that it will be available on the next release (5.7.24).
Comment 4 Larry the Git Cow gentoo-dev 2018-10-13 23:30:57 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/mysql-extras.git/commit/?id=87d6895e070ae14ebaf813c7884c8dd3210887d3

commit 87d6895e070ae14ebaf813c7884c8dd3210887d3
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2018-10-13 14:58:13 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2018-10-13 14:58:13 +0000

    Add 20018_all_mysql-5.7.23-add-missing-gcc-8-fix.patch
    
    Bug: https://bugs.gentoo.org/662816
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 20018_all_mysql-5.7.23-add-missing-gcc-8-fix.patch | 13 +++++++++++++
 1 file changed, 13 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2018-10-14 01:21:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=03afe8693d0935688fc27cf6b72b5c044645c9a8

commit 03afe8693d0935688fc27cf6b72b5c044645c9a8
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2018-10-14 01:21:08 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2018-10-14 01:21:24 +0000

    dev-db/mysql: rev bump
    
    - Add USE=mecab to build MeCab full-text parser plugin
    
    - Enable libevent support
    
    - Fix multiple build issues
    
    - Fix tests
    
    - Adjust ebuild style
    
    Bug: https://bugs.gentoo.org/658822
    Closes: https://bugs.gentoo.org/662816
    Closes: https://bugs.gentoo.org/662826
    Package-Manager: Portage-2.3.50, Repoman-2.3.11
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 dev-db/mysql/Manifest                              |   1 +
 dev-db/mysql/metadata.xml                          |   1 +
 ...{mysql-5.7.23.ebuild => mysql-5.7.23-r1.ebuild} | 421 ++++++++++++---------
 3 files changed, 242 insertions(+), 181 deletions(-)