Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 661994 - xfce-extra/xfce4-diskperf-plugin-2.6.1 fails to run when build with gcc-7.3.0-r3
Summary: xfce-extra/xfce4-diskperf-plugin-2.6.1 fails to run when build with gcc-7.3.0-r3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
: 668662 (view as bug list)
Depends on:
Blocks: gcc-7-stable
  Show dependency tree
 
Reported: 2018-07-24 17:05 UTC by Andrew Petelin
Modified: 2018-10-15 17:39 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge-info,6.47 KB, text/plain)
2018-07-24 17:08 UTC, Andrew Petelin
Details
emerge --info xfce-extra/xfce4-diskperf-plugin (emerge-info,6.91 KB, text/plain)
2018-08-05 15:16 UTC, Andrew Petelin
Details
build.log (xfce-extra:xfce4-diskperf-plugin-2.6.1:20180805-151332.log.xz,4.74 KB, application/x-xz)
2018-08-05 15:18 UTC, Andrew Petelin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Petelin 2018-07-24 17:05:47 UTC
Plugin cannot be added to xfce panel emerging the following error in ~/.xsession-errors:

  (process:20922): xfce4-panel-wrapper-CRITICAL **: Wrapper diskperf-9: Failed to open plugin module "/usr/lib64/xfce4/panel/plugins/libdiskperf.so": 
  /usr/lib64/xfce4/panel/plugins/
  libdiskperf.so: undefined symbol: major.
Comment 1 Andrew Petelin 2018-07-24 17:08:52 UTC
Created attachment 540728 [details]
emerge --info
Comment 2 Nikita Zlobin 2018-08-01 12:03:55 UTC
Though i'm not gentoo dev, i confirm - after last upgrade to gcc-7.3.0/binutils-2.30.1 diskperf plugin loading fails with this error. However, rebuilding it again with gcc-6.4.0 doesn't fix problem.

Btw, if you look plugin binary in mcview, 'major' symbol appears there, while in some other plugins (xfce powermanager) it absents.
Also "nm" says "no symbols".
Comment 3 Nikita Zlobin 2018-08-01 12:05:05 UTC
Hm... i said i confirm...
Caption is "fails to build", but actually it builds, while simply refuses to run, but with exactly same error.
Comment 4 Andrew Petelin 2018-08-01 12:57:55 UTC
(In reply to Nikita Zlobin from comment #3)
> Caption is "fails to build"...

The bug title is correct.
Comment 5 Jonas Stein gentoo-dev 2018-08-04 11:20:27 UTC
Thank you for the report. Please recompile and *attach* the logfiles as described on
https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket
The logs must be part of the ticket, but not on external websites.
Please reopen this ticket (Status:unconfirmed) afterwards.
Comment 6 Andrew Petelin 2018-08-05 15:16:59 UTC
Created attachment 542498 [details]
emerge --info  xfce-extra/xfce4-diskperf-plugin
Comment 7 Andrew Petelin 2018-08-05 15:18:07 UTC
Created attachment 542500 [details]
build.log
Comment 8 Andrew Petelin 2018-08-06 08:56:18 UTC
(In reply to Nikita Zlobin from comment #2)
> Btw, if you look plugin binary in mcview, 'major' symbol appears there,
> while in some other plugins (xfce powermanager) it absents.
> Also "nm" says "no symbols".
It appears, but it is undefined:

  $ nm -CD /usr/lib64/xfce4/panel/plugins/libdiskperf.so | grep major
                   U major

Here is a similar bug: https://github.com/hishamhm/htop/issues/663. Looks like source files lack including sysmacros.h: https://github.com/lattera/glibc/blob/master/sysdeps/unix/sysv/linux/sys/sysmacros.h#L66.
Comment 9 Andrew Petelin 2018-08-06 09:19:23 UTC
The fix from mgorny: https://github.com/xfce-mirror/xfce4-diskperf-plugin/commit/0787a8972be2b95fac26c502a82427299e7e48c0.

It was committed to the master branch, but not merged into any stable version (the latest -- 2.6.1 -- doesn't include it). :(
Comment 10 Andrew Petelin 2018-08-06 09:26:32 UTC
Possibly, we may now add a patch (until upstream is fixed in some stable version): https://bugzilla.xfce.org/show_bug.cgi?id=13940#c5.
Comment 11 Maxim P. Dementiev 2018-09-22 07:51:45 UTC
I confirm this bug on my AMD64, having gcc-7.3.0-r4.
Compiles, but cannot run.
Comment 12 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-09-24 16:46:07 UTC
I'm sorry that I've forgotten to deal with this earlier.  Upstream apparently isn't going to make a new release, so I'm going to apply the simpler version of my patch (one that doesn't require eautoreconf).
Comment 13 Larry the Git Cow gentoo-dev 2018-09-24 16:49:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a57c85880af3b8d5696dbf5a0067e28d3d70873d

commit a57c85880af3b8d5696dbf5a0067e28d3d70873d
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-09-24 16:45:24 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-09-24 16:49:38 +0000

    xfce-extra/xfce4-diskperf-plugin: Apply proper sysmacros.h fix
    
    Closes: https://bugs.gentoo.org/661994
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 .../xfce4-diskperf-plugin-2.6.1-sysmacros.patch    | 24 +++++++++++++
 .../xfce4-diskperf-plugin-2.6.1-r1.ebuild          | 40 ++++++++++++++++++++++
 2 files changed, 64 insertions(+)
Comment 14 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-10-15 17:39:16 UTC
*** Bug 668662 has been marked as a duplicate of this bug. ***