Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 661808 - dev-perl/Perl-Critic-Dynamic-0.50.0-r2: test failures: Failed 1/2 test programs
Summary: dev-perl/Perl-Critic-Dynamic-0.50.0-r2: test failures: Failed 1/2 test programs
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Perl team
URL: https://rt.cpan.org/Public/Bug/Displa...
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: 661778
  Show dependency tree
 
Reported: 2018-07-22 14:08 UTC by Thomas Deutschmann
Modified: 2019-10-16 12:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,6.12 KB, text/plain)
2018-07-22 14:08 UTC, Thomas Deutschmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Deutschmann gentoo-dev Security 2018-07-22 14:08:34 UTC
Created attachment 540502 [details]
build.log

> >>> Test phase: dev-perl/Perl-Critic-Dynamic-0.50.0-r2
>  * Test::Harness Jobs=5
> ===(       1;0  1/8  0/? )==============================================                                                                        t/00_basic.t ..... ok
> t/20_policies.t .. #  
> # NOTE: these tests will emit a "Compilation of ... failed" warning.
> # This is normal, and can be ignored.  Sorry about the noise.
> t/20_policies.t .. 1/33 t/20_policies.t .. 14/33 Dynamic::ValidateAgainstSymbolTable: Compilation of "unknown file" failed: Can't locate CGI.pm in @INC (you may need to install the CGI module) (@INC contains: /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work/Perl-Critic-Dynamic-0.05/blib/lib /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work/Perl-Critic-Dynamic-0.05/blib/arch /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work/Perl-Critic-Dynamic-0.05/_build/lib /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work/Perl-Critic-Dynamic-0.05/blib/lib /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work/Perl-Critic-Dynamic-0.05/blib/arch /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work/Perl-Critic-Dynamic-0.05/_build/lib /etc/perl /usr/local/lib/perl5/5.24.3/i686-linux-thread-multi /usr/local/lib/perl5/5.24.3 /usr/lib/perl5/vendor_perl/5.24.3/i686-linux-thread-multi /usr/lib/perl5/vendor_perl/5.24.3 /usr/local/lib/perl5 /usr/lib/perl5/vendor_perl /usr/lib/perl5/5.24.3/i686-linux-thread-multi /usr/lib/perl5/5.24.3 .) at (eval 76) line 9.
> BEGIN failed--compilation aborted at (eval 76) line 9.
> 
> 
> Child process had errors.  Status: 256 at /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work/Perl-Critic-Dynamic-0.05/blib/lib/Perl/Critic/DynamicPolicy.pm line 79.
> 	Perl::Critic::DynamicPolicy::violates(Perl::Critic::Policy::Dynamic::ValidateAgainstSymbolTable=HASH(0x2e6dfe0), Perl::Critic::Document=HASH(0x2e6e300), Perl::Critic::Document=HASH(0x2e6e300)) called at /usr/lib/perl5/vendor_perl/5.24.3/Perl/Critic.pm line 176
> 	Perl::Critic::_critique(Perl::Critic::Policy::Dynamic::ValidateAgainstSymbolTable=HASH(0x2e6dfe0), Perl::Critic::Document=HASH(0x2e6e300)) called at /usr/lib/perl5/vendor_perl/5.24.3/Perl/Critic.pm line 128
> 	Perl::Critic::_gather_violations(Perl::Critic=HASH(0x2e9da70), Perl::Critic::Document=HASH(0x2e6e300)) called at /usr/lib/perl5/vendor_perl/5.24.3/Perl/Critic.pm line 111
> 	Perl::Critic::critique(Perl::Critic=HASH(0x2e9da70), SCALAR(0x2e52bb0)) called at /usr/lib/perl5/vendor_perl/5.24.3/Perl/Critic/TestUtils.pm line 68
> 	Perl::Critic::TestUtils::pcritique_with_violations("Dynamic::ValidateAgainstSymbolTable", SCALAR(0x2e52bb0), HASH(0x2e52bc0)) called at /usr/lib/perl5/vendor_perl/5.24.3/Test/Perl/Critic/Policy.pm line 139
> 	eval {...} called at /usr/lib/perl5/vendor_perl/5.24.3/Test/Perl/Critic/Policy.pm line 141
> 	Test::Perl::Critic::Policy::_run_subtest("Dynamic::ValidateAgainstSymbolTable", HASH(0x2e52b50)) called at /usr/lib/perl5/vendor_perl/5.24.3/Test/Perl/Critic/Policy.pm line 69
> 	Test::Perl::Critic::Policy::all_policies_ok() called at t/20_policies.t line 33
>  at /usr/lib/perl5/vendor_perl/5.24.3/Test/Perl/Critic/Policy.pm line 155.
> 	Test::Perl::Critic::Policy::_evaluate_test_results(HASH(0x2e52b50), "Child process had errors.  Status: 256 at /var/tmp/portage/de"..., ARRAY(0x1ad4560)) called at /usr/lib/perl5/vendor_perl/5.24.3/Test/Perl/Critic/Policy.pm line 70
> 	Test::Perl::Critic::Policy::all_policies_ok() called at t/20_policies.t line 33
> # Looks like you planned 33 tests but ran 15.
> # Looks like your test exited with 1 just after 15.
>                           t/20_policies.t .. Dubious, test returned 1 (wstat 256, 0x100)
> Failed 18/33 subtests 
> 
> Test Summary Report
> -------------------
> t/20_policies.t (Wstat: 256 Tests: 15 Failed: 0)
>   Non-zero exit status: 1
>   Parse errors: Bad plan.  You planned 33 tests but ran 15.
> Files=2, Tests=23,  2 wallclock secs ( 0.02 usr  0.01 sys +  1.00 cusr  0.32 csys =  1.35 CPU)
> Result: FAIL
> Failed 1/2 test programs. 0/23 subtests failed.
>  * ERROR: dev-perl/Perl-Critic-Dynamic-0.50.0-r2::gentoo failed (test phase):
>  *   test failed


Portage 2.3.40 (python 3.6.5-final-0, default/linux/x86/17.0, gcc-7.3.0, glibc-2.26-r7, 4.14.52-gentoo i686)
=================================================================
System uname: Linux-4.14.52-gentoo-i686-Intel-R-_Core-TM-_i7-3770K_CPU_@_3.50GHz-with-gentoo-2.4.1
KiB Mem:     3107600 total,    839464 free
KiB Swap:     488276 total,    488276 free
Timestamp of repository gentoo: Sun, 22 Jul 2018 13:04:19 +0000
Head commit of repository gentoo: 7ff2a158a842b3bc9e5db5cb0c6028273815fda9

sh bash 4.4_p12
ld GNU ld (Gentoo 2.30 p2) 2.30.0
app-shells/bash:          4.4_p12::gentoo
dev-lang/perl:            5.24.3-r1::gentoo
dev-lang/python:          2.7.14-r1::gentoo, 3.6.5::gentoo
dev-util/cmake:           3.9.6::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/openrc:          0.34.11::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.15.1-r2::gentoo
sys-devel/binutils:       2.30-r2::gentoo
sys-devel/gcc:            7.3.0-r3::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.13::gentoo (virtual/os-headers)
sys-libs/glibc:           2.26-r7::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000

ABI="x86"
ABI_X86="32"
ACCEPT_KEYWORDS="x86"
ACCEPT_LICENSE="* -@EULA"
ACCEPT_PROPERTIES="*"
ACCEPT_RESTRICT="*"
ARCH="x86"
BROOT=""
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=pentium4m -mtune=pentium4m"
CHOST="i686-pc-linux-gnu"
CHOST_x86="i686-pc-linux-gnu"
COLLISION_IGNORE="/lib/modules/* *.py[co] *$py.class */dropin.cache"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CPU_FLAGS_X86="mmx mmxext sse sse2"
CXXFLAGS="-O2 -pipe -march=pentium4m -mtune=pentium4m"
DEFAULT_ABI="x86"
EDITOR="/usr/bin/mcedit"
ELIBC="glibc"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
EPREFIX=""
EROOT="/"
ESYSROOT="/"
FCFLAGS="-O2 -march=i686 -pipe"
FEATURES="assume-digests binpkg-logs cgroup config-protect-if-modified distlocks downgrade-backup ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -march=i686 -pipe"
GCC_SPECS=""
GRUB_PLATFORMS="efi-32 pc"
GSETTINGS_BACKEND="dconf"
HOME="/root"
INFOPATH="/usr/share/gcc-data/i686-pc-linux-gnu/7.3.0/info:/usr/share/binutils-data/i686-pc-linux-gnu/2.30/info:/usr/share/info"
INPUT_DEVICES="libinput keyboard mouse"
IUSE_IMPLICIT="abi_x86_32 prefix prefix-chain prefix-guest"
KERNEL="linux"
L10N="en en-US de de-DE"
LADSPA_PATH="/usr/lib/ladspa"
LANG="en_US.UTF-8"
LC_ALL="en_US.UTF-8"
LC_MESSAGES="C"
LC_PAPER="de_DE.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LIBDIR_x86="lib"
LINGUAS="en de"
LOGNAME="root"
MAIL="/var/mail/root"
MAKEOPTS="--jobs 5 --load-average 7.95"
MOZ_GMP_PATH="/usr/lib/nsbrowser/plugins/gmp-gmpopenh264/system-installed"
MULTILIB_ABIS="x86"
NOCOLOR="true"
OFFICE_IMPLEMENTATION="libreoffice"
OLDPWD="/tmp/stable"
OPENCL_PROFILE="mesa"
OPENGL_PROFILE="xorg-x11"
PAGER="/usr/bin/less"
PATH="/usr/i686-pc-linux-gnu/gcc-bin/7.3.0:/usr/lib/llvm/5/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin"
PHP_TARGETS="php5-6 php7-0"
POSTGRES_TARGETS="postgres9_5 postgres10"
PWD="/usr/portage/app-i18n/uim"
PYTHONDONTWRITEBYTECODE="1"
PYTHON_SINGLE_TARGET="python3_6"
PYTHON_TARGETS="python2_7 python3_6"
QT_GRAPHICSSYSTEM="raster"
ROOT="/"
ROOTPATH="/usr/i686-pc-linux-gnu/gcc-bin/7.3.0:/usr/lib/llvm/5/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin"
RUBY_TARGETS="ruby22 ruby23"
SHELL="/bin/bash"
SHLVL="2"
SSH_TTY="/dev/pts/0"
SYSROOT="/"
TERM="tmux-256color"
TMUX="/tmp/tmux-0/default,5559,0"
TMUX_PANE="%2"
TWISTED_DISABLE_WRITING_OF_PLUGIN_CACHE="1"
USER="root"
USERLAND="GNU"
VIDEO_CARDS="vmware"
XDG_CONFIG_DIRS="/etc/xdg"
XDG_DATA_DIRS="/usr/local/share:/usr/share"
Comment 1 Matt Turner gentoo-dev 2018-08-20 04:47:15 UTC
Noticing the CGI.pm message, I installed dev-perl/CGI-4.360.0. After that's installed dev-perl/Perl-Critic-Dynamic-0.50.0-r2 passes its tests on alpha.

Are we just missing a dep?
Comment 2 Kent Fredric (IRC: kent\n) gentoo-dev 2019-07-17 06:32:17 UTC
(In reply to Matt Turner from comment #1)
> Noticing the CGI.pm message, I installed dev-perl/CGI-4.360.0. After that's
> installed dev-perl/Perl-Critic-Dynamic-0.50.0-r2 passes its tests on alpha.
> 
> Are we just missing a dep?

Looks more complicated than that, upstream bugs suggest certain versions of CGI create this issue, and others don't. 

But will add a dep on CGI just-incase.
Comment 3 Kent Fredric (IRC: kent\n) gentoo-dev 2019-07-17 06:36:38 UTC
Hmm, we have patches in -r2 that should have killed off the use of CGI.pm entirely... *flips table*

But I guess our patch wasn't extensive enough:

$ ebuild Perl-Critic-Dynamic-0.50.0-r2.ebuild clean prepare
Appending /usr/local/gentoo to PORTDIR_OVERLAY...
 * Perl-Critic-Dynamic-0.05.tar.gz BLAKE2B SHA512 size ;-) ...                                                   [ ok ]
>>> Unpacking source...
>>> Unpacking Perl-Critic-Dynamic-0.05.tar.gz to /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work
>>> Source unpacked in /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work
>>> Preparing source in /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work/Perl-Critic-Dynamic-0.05 ...
 * Applying Perl-Critic-Dynamic-0.05-test-cgi.patch ...                                                          [ ok ]
>>> Source prepared.
$ sudo grep CGI -r /var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work/Perl-Critic-Dynamic-0.05
/var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work/Perl-Critic-Dynamic-0.05/t/Dynamic/ValidateAgainstSymbolTable.run:use CGI;  #also uses Carp
/var/tmp/portage/dev-perl/Perl-Critic-Dynamic-0.50.0-r2/work/Perl-Critic-Dynamic-0.05/t/Dynamic/ValidateAgainstSymbolTable.run:use CGI;  #also uses Carp


*sigh*
Comment 4 Larry the Git Cow gentoo-dev 2019-07-17 06:42:15 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5ef6864dc88e9e5288fd5563155c0e2ee1ef8fb4

commit 5ef6864dc88e9e5288fd5563155c0e2ee1ef8fb4
Author:     Kent Fredric <kentnl@gentoo.org>
AuthorDate: 2019-07-17 06:40:57 +0000
Commit:     Kent Fredric <kentnl@gentoo.org>
CommitDate: 2019-07-17 06:41:59 +0000

    dev-perl/Perl-Critic-Dynamic: Add dev-perl/CGI into test deps bug #661808
    
    Bug: https://bugs.gentoo.org/661808
    Bug: https://bugs.gentoo.org/662294
    Package-Manager: Portage-2.3.66, Repoman-2.3.16
    Signed-off-by: Kent Fredric <kentnl@gentoo.org>

 .../Perl-Critic-Dynamic-0.50.0-r3.ebuild           | 26 ++++++++++++++++++++++
 1 file changed, 26 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2019-10-16 12:35:35 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6797621a48aba27249d1a063714e1a0208404469

commit 6797621a48aba27249d1a063714e1a0208404469
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2019-10-16 11:51:38 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2019-10-16 12:35:03 +0000

    dev-perl/Perl-Critic-Dynamic: Port stable keywords (only dep additions)
    
    Bug: https://bugs.gentoo.org/661808
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 dev-perl/Perl-Critic-Dynamic/Perl-Critic-Dynamic-0.50.0-r3.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)