Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 661442 - dev-lang/clojure-1.9.0.397 version bump
Summary: dev-lang/clojure-1.9.0.397 version bump
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2018-07-17 21:25 UTC by crocket
Modified: 2019-04-21 17:06 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
clojure-1.9.0.381.ebuild (clojure-1.9.0.381.ebuild,790 bytes, text/plain)
2018-07-18 12:14 UTC, crocket
Details
clojure-1.9.0.381.ebuild (clojure-1.9.0.381.ebuild,791 bytes, text/plain)
2018-07-21 00:35 UTC, crocket
Details

Note You need to log in before you can comment on or make changes to this bug.
Description crocket 2018-07-17 21:25:59 UTC
https://clojure.org/guides/getting_started says

```
curl -O https://download.clojure.org/install/linux-install-1.9.0.381.sh
chmod +x linux-install-1.9.0.381.sh
sudo ./linux-install-1.9.0.381.sh
```

https://download.clojure.org/install/linux-install-1.9.0.381.sh contains instructions on how to install clojure 1.9.0.381
Comment 1 crocket 2018-07-17 21:27:25 UTC
https://git.archlinux.org/svntogit/community.git/tree/trunk?h=packages/clojure contains information on how to package clojure 1.9.0.381
Comment 2 crocket 2018-07-18 12:14:39 UTC
Created attachment 539944 [details]
clojure-1.9.0.381.ebuild

I created this ebuild and tested it on my system. It works.

Please add this ebuild to gentoo overlay.
Comment 3 Jonas Stein gentoo-dev 2018-07-20 18:38:10 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

SRC_URI="https://download.clojure.org/install/clojure-tools-1.9.0.381.tar.gz"
You can use variables here
https://devmanual.gentoo.org/ebuild-writing/variables/


sed -i -e "s|PREFIX|$CLOJURE_LIB_DIR|g" clojure
needs || die
Comment 4 crocket 2018-07-21 00:35:12 UTC
Created attachment 540300 [details]
clojure-1.9.0.381.ebuild

Like this?
Comment 5 crocket 2019-01-02 06:09:58 UTC
Take dev-lang/clojure-1.10.0.403 from crocket-overlay. It works well on my system.
Comment 6 Miroslav Šulc gentoo-dev 2019-01-14 13:33:24 UTC
i just came across this bug because 1.9.0 that is in tree does not compile for me. can somebody please enlighten me where the x.x.x.x versions come from? i can't see anything like this on their download page:

https://clojure.org/community/downloads

i can bump it to both versions mentioned, i just need clarification for this.
Comment 7 crocket 2019-01-15 05:55:31 UTC
In my crocket-overlay, you can find clojure-1.10.0.403.ebuild

In https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/clojure
you can find "_toolver=408" which is the last part of my clojure package's version.

You can drop toolver if you like.
Comment 8 Miroslav Šulc gentoo-dev 2019-01-17 16:19:17 UTC
ok, i looked at the ebuilds and there are several issues:
1) this is a binary download, not from source, it should be built from source instead
2) it installs versioned jar file and in unsupported path (should be /usr/share/clojure-${SLOT}/clojure.jar and so the path to the jar in clojure executable must be updated)
3) as ve have clojure slotted, slot number must be prepended to the executables and man pages, and the deps files, if really needed, should be put in /usr/share/clojure-{SLOT}, otherwise it will cause conflicts when more than one version is installed

could you please fix these issues?
Comment 9 crocket 2019-01-18 06:23:25 UTC
1) Jar files are cross-platform assets. They will work on any platform that java supports. Also, it's difficult to replicate the structure of https://download.clojure.org/install/${PN}-tools-${PV}.tar.gz when I build clojure from source. I don't see a good reason to not use clojure-tools-XXX.tar.gz
2 and 3) Maybe. But, I am short of time these days. It will take several months for me to work on it again.
Comment 10 Dennis Schridde 2019-04-19 08:26:46 UTC
As I understand, this builds the Clojure CLI tooling (`clj` binary), while our current ebuild only builds the language JAR (and a thin custom wrapper around `clojure.main`).  Is this correct?
Comment 11 crocket 2019-04-21 09:07:23 UTC
My ebuild doesn't build anything. It just copies the contents of an archive file to appropriate places.
Comment 12 Dennis Schridde 2019-04-21 17:06:35 UTC
(In reply to crocket from comment #11)
> My ebuild doesn't build anything. It just copies the contents of an archive
> file to appropriate places.

In that case the package name should be dev-lang/clojure-bin and not dev-lang/clojure.  From the ebuild it seems that a good name might also be dev-util/clojure-tools-bin, since it seems to contain the "clj" Clojure CLI tool.