Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 661200 - <dev-perl/Getopt-Long-Descriptive-0.101.0 breaks dev-perl/Dist-Zilla tests on perl 5.28 ( Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32) )
Summary: <dev-perl/Getopt-Long-Descriptive-0.101.0 breaks dev-perl/Dist-Zilla tests on...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Perl team
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: perl-5.28-unmask
  Show dependency tree
 
Reported: 2018-07-15 03:51 UTC by Kent Fredric (IRC: kent\n) (RETIRED)
Modified: 2018-11-27 21:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2018-07-15 03:51:39 UTC 
This produces a warning message that ends up causing dev-perl/Dist-Zilla to fail tests:

t/00-report-prereqs.t ........... ok                                    
    #   Failed test 'all prereqs listed as output'
    #   at t/commands/listdeps.t line 72.
    # Comparing $data as a Bag
    # Extra: 'Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/(?:[:=][\d\w\+]+[%@]?({ <-- HERE \d*,\d*})?|[!+])$/ at /usr/lib64/perl5/vendor_perl/5.28.0/Getopt/Long/Descriptive.pm line 307.'
t/diagnostics/main-module.t ..... ok                                    
#   Failed test 'default output'
#   at t/commands/listdeps.t line 130.
t/commands/listdeps.t ........... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Given this damage happens at runtime, should fix everything that requires it before unleashing Perl 5.28 on people, as the side-effects might be quite diverse.
Comment 1 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2018-07-21 06:52:14 UTC 
Getopt-Long-Descriptive also fails tests for all versions, with:

Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/(?:[:=][\d\w\+]+[%@]?({ <-- HERE \d*,\d*})?|[!+])$/ at /var/tmp/portage/dev-perl/Getopt-Long-Descriptive-0.100.0/work/Getopt-Long-Descriptive-0.100/blib/lib/Getopt/Long/Descriptive.pm line 307.
t/00-report-prereqs.t .. ok
#   Failed test 'no (unexpected) warnings (via done_testing)'
#   at t/shortcircuit.t line 84.
# Looks like you failed 1 test of 11.
t/shortcircuit.t ....... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/11 subtests
Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/(?:[:=][\d\w\+]+[%@]?({ <-- HERE \d*,\d*})?|[!+])$/ at /var/tmp/portage/dev-perl/Getopt-Long-Descriptive-0.100.0/work/Getopt-Long-Descriptive-0.100/blib/lib/Getopt/Long/Descriptive.pm line 307.
t/descriptive.t ........ ok
t/zzz-check-breaks.t ... ok

Test Summary Report
-------------------
t/shortcircuit.t     (Wstat: 256 Tests: 11 Failed: 1)
  Failed test:  11
  Non-zero exit status: 1
Files=4, Tests=71,  1 wallclock secs ( 0.04 usr  0.01 sys +  0.62 cusr  0.06 csys =  0.73 CPU)
Result: FAIL

And version 0.97.0 fails with:

t/shortcircuit.t .............. Can't locate Test/Fatal.pm in @INC (you may need to install the Test::Fatal module) (@INC contains: /var/tmp/portage/dev-perl/Getopt-Long-Descriptive-0.97.0/work/Getopt-Long-Descriptive-0.097/blib/lib /var/tmp/portage/dev-perl/Getopt-Long-Descriptive-0.97.0/work/Getopt-Long-Descriptive-0.097/blib/arch /etc/perl /usr/local/lib64/perl5/5.28.0/x86_64-linux-thread-multi /usr/local/lib64/perl5/5.28.0 /usr/lib64/perl5/vendor_perl/5.28.0/x86_64-linux-thread-multi /usr/lib64/perl5/vendor_perl/5.28.0 /usr/local/lib64/perl5 /usr/lib64/perl5/vendor_perl/5.27.8 /usr/lib64/perl5/vendor_perl/5.27.7 /usr/lib64/perl5/vendor_perl/5.27.6 /usr/lib64/perl5/vendor_perl/5.22.3 /usr/lib64/perl5/vendor_perl /usr/lib64/perl5/5.28.0/x86_64-linux-thread-multi /usr/lib64/perl5/5.28.0) at t/shortcircuit.t line 7.
BEGIN failed--compilation aborted at t/shortcircuit.t line 7.
t/shortcircuit.t .............. Dubious, test returned 2 (wstat 512, 0x200

However, its cleanup is blocked by bug #657634
Comment 2 Larry the Git Cow gentoo-dev 2018-09-01 16:59:39 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ccde7f0195a1a3b7959941fb950d92ae9d9880a3

commit ccde7f0195a1a3b7959941fb950d92ae9d9880a3
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2018-09-01 16:58:23 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2018-09-01 16:58:23 +0000

    dev-perl/Getopt-Long-Descriptive: Version bump
    
    Bug: https://bugs.gentoo.org/661200
    Package-Manager: Portage-2.3.48, Repoman-2.3.10

 .../Getopt-Long-Descriptive-0.103.0.ebuild         | 37 ++++++++++++++++++++++
 dev-perl/Getopt-Long-Descriptive/Manifest          |  1 +
 2 files changed, 38 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2018-11-27 21:35:43 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2560d32e8733cf7618ca8487ab1878535f44ea33

commit 2560d32e8733cf7618ca8487ab1878535f44ea33
Author:     Kent Fredric <kentnl@gentoo.org>
AuthorDate: 2018-11-27 21:35:12 +0000
Commit:     Kent Fredric <kentnl@gentoo.org>
CommitDate: 2018-11-27 21:35:32 +0000

    dev-perl/Getopt-Long-Descriptive: Cleanup old re bug #661200
    
    Closes: https://bugs.gentoo.org/661200
    Package-Manager: Portage-2.3.51, Repoman-2.3.11
    Signed-off-by: Kent Fredric <kentnl@gentoo.org>

 .../Getopt-Long-Descriptive-0.100.0.ebuild         | 37 ----------------------
 dev-perl/Getopt-Long-Descriptive/Manifest          |  1 -
 2 files changed, 38 deletions(-)