Created attachment 539134 [details] This is JRomManager first ebuild Hello! Please find attached jrommanager-1.6-r1.ebuild, this a prebuilt ebuild since gradle-bin>=4.3 would be needed to compile it JRomManager is a Rom manager made to work mostly anywhere, with decent performance and minimal memory footprint, some attention was also made to work correctly over shared networks. It has also been made available open source to permit enhancements from the retro gaming community. The main focus is to support MAME and derivatives, but should work well with any Dat file from other roms sets. This ebuild rdepends on >=virtual/jre-1.8
nice for a start, but the ebuild can be improved, for example * DEPEND="${DEPEND} * missing ||die behind sed * use EAPI=7 * use version number from ebuild name * test with repoman * rename the SRC_URI with -> ${P} * find a more specific description see also https://devmanual.gentoo.org/ebuild-writing/eapi/
Created attachment 539300 [details] ebuild second try I think this one should be better, but still have issues : - How can I "use version from ebuild", without changing versioning on github? - There is things in the review of the github pulling review that I still don't understand : remarks about "wrong variables order" + inability to git squash
Except for git squashing problem, did I miss something else? If not, is it possible to accept the pull request without squashing? Thanks in advance
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a94b03d774063ceea0a6d7b4a25787429665c612 commit a94b03d774063ceea0a6d7b4a25787429665c612 Author: optyfr <17027109+optyfr@users.noreply.github.com> AuthorDate: 2018-07-11 10:05:26 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2018-07-28 11:32:15 +0000 games-emulation/jrommanager: new package based on v1.6b20 release Package-Manager: Portage-2.3.40, Repoman-2.3.9 Closes: https://github.com/gentoo/gentoo/pull/9177 Closes: https://bugs.gentoo.org/660900 games-emulation/jrommanager/Manifest | 1 + .../jrommanager/jrommanager-1.6_p20-r1.ebuild | 41 ++++++++++++++++++++++ games-emulation/jrommanager/metadata.xml | 21 +++++++++++ 3 files changed, 63 insertions(+)
