Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 658086 - app-emulation/open-vm-tools-10.2.5: version bump
Summary: app-emulation/open-vm-tools-10.2.5: version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mike Gilbert
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-14 11:07 UTC by Xiami
Modified: 2018-07-05 03:07 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xiami 2018-06-14 11:07:28 UTC
Request to bump open-vm-tools to the latest version 10.2.5

As it seems there are some changes that ebuild should update, for example, 10.2.5 no longer build kernel modules on linux,
I have written an ebuild w/ a lot changes based on the currect 10.1.5.ebuild

View at https://github.com/Xiami2012/spear_of_adun/blob/master/app-emulation/open-vm-tools/open-vm-tools-10.2.5.ebuild
(metadata(use.desc), files are updated also. Diff with dirs)

All dependencies information are rewritten by reading configure.ac and Makefile.am
And a (ugly) patch for building against libtirpc is written to replace 10.1.0-Werror.patch .

10.1.0-vgauth.patch is removed because I didn't find a problem when using C linker (maybe runtime issues?)

This may also close https://bugs.gentoo.org/548874 since deploypkg (which depends on libmspack) plugin support is added.
Comment 1 Mike Gilbert gentoo-dev 2018-07-04 01:08:24 UTC
If you want credit for this work, please open a PR on github or attach a patch via git-format-patch.
Comment 2 Xiami 2018-07-04 10:57:31 UTC
Have sent a PR at https://github.com/gentoo/gentoo/pull/9039 :)
Comment 3 Larry the Git Cow gentoo-dev 2018-07-04 14:56:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=27cf8b83fbf2cb9394d1c123a4ab237caa5d0d2c

commit 27cf8b83fbf2cb9394d1c123a4ab237caa5d0d2c
Author:     Xiami <i@f2light.com>
AuthorDate: 2018-07-04 09:54:00 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2018-07-04 14:56:16 +0000

    app-emulation/open-vm-tools: Bump to 10.2.5 and update the ebuild
    
    - Update LICENSE
    - According to configure.ac:
      - Introducing more features
      - Update IUSE, REQUIRED_USE and DEPENDs
    - Patches for migrate to libtirpc (and keep -Werror)
    
    Package-Manager: Portage-2.3.40, Repoman-2.3.9
    Closes: https://github.com/gentoo/gentoo/pull/9039
    Closes: https://bugs.gentoo.org/658086

 app-emulation/open-vm-tools/Manifest               |   1 +
 .../open-vm-tools/files/10.2.5-libtirpc.patch      |  45 ++++++
 app-emulation/open-vm-tools/files/vgauthd.service  |  14 ++
 app-emulation/open-vm-tools/files/vmtoolsd.service |   2 +-
 .../open-vm-tools/files/vmtoolsd.vgauth.service    |  14 ++
 app-emulation/open-vm-tools/metadata.xml           |  16 +-
 .../open-vm-tools/open-vm-tools-10.2.5.ebuild      | 172 +++++++++++++++++++++
 7 files changed, 260 insertions(+), 4 deletions(-)
Comment 4 Mike Gilbert gentoo-dev 2018-07-04 14:59:02 UTC
Thanks for the work!

I reverted a couple of the changes:

1. I don't want to support building against gtk2.

2. I restored the -Werror patch to avoid breakage when some random gcc release causes new warnings to appear.
Comment 5 Xiami 2018-07-05 03:07:29 UTC
Thanks for the review and merging!