Created attachment 535342 [details] vscode-1.24.0 ebuild Hi, I didn't find vscode (visual-studio-code) on portage, and everything I could find on the overlays was the propietary/binary version of it. This motivated me to write the ebuild for the open-source version of visual studio code (although mostly is a copy-paste from https://aur.archlinux.org/packages/code/ ). I never wrote an ebuild before, so feel free to let me know what can I improve. What specially bothers me are some QA messages appear which I don't really know how to fix: QA Notice: The following files contain writable and executable sections QA Notice: Pre-stripped files found Kind regards,
In the description, why "multiplatform"?
(In reply to fosslinux from comment #1) > In the description, why "multiplatform"? It supports x86, x86_64 and some kind of arm, but since I can't test it on arm, the ebuild only supports x86 and x86_64.
Cool that you are interested in writing ebuilds. Here are some ideas: test it with repoman Have you read https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers There are many useful links add upstream to metadata https://devmanual.gentoo.org/ebuild-writing/misc-files/metadata/ do you need eutils? You need "|| die" for all lines where you call somethings which is not an ebuild helper. for example behind sed -e "s/@COMMIT@/${_commit}/" -e "s/@DATE@/${_datestamp}/" -i product.json || die drop the echo. what is this good for? It will break crosscompiling: case `uname -m` in i?86) archs=ia32 ;; x86_64) archs=x64 ;; esac read also: https://wiki.gentoo.org/wiki/Notes_on_ebuilds_with_GUI
Been working on this myself for a few months now here and there. Wanted to get a collection of node.js dependencies together so that it could all be managed by portage rather than yarn (https://github.com/herbmillerjr/gentoo-nodejs/tree/master/dev-nodejs), however this has been requested a few times so might as well get the PR open. It's 1.22.2 since 1.24.0 seems to abort with weird git tag errors. When I look at the tags on upstream, 1.22.0 is the last "verified" one and the 1.22.x series are the latest that build successfully from a release archive so I'm thinking it has something to do with that.
In progress: https://github.com/gentoo/gentoo/pull/8924
Created attachment 538098 [details] vscode-1.24.1 ebuild
(In reply to Jonas Stein from comment #3) > Cool that you are interested in writing ebuilds. > Here are some ideas: > > test it with repoman > > Have you read > https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers > There are many useful links > > add upstream to metadata > https://devmanual.gentoo.org/ebuild-writing/misc-files/metadata/ > > do you need eutils? > > You need "|| die" for all lines where you call somethings which is not an > ebuild helper. > > for example behind > sed -e "s/@COMMIT@/${_commit}/" -e "s/@DATE@/${_datestamp}/" -i product.json > || die > > drop the echo. > > > what is this good for? It will break crosscompiling: > > case `uname -m` in > i?86) archs=ia32 ;; > x86_64) archs=x64 ;; > esac > > > read also: > https://wiki.gentoo.org/wiki/Notes_on_ebuilds_with_GUI I've tried to take your comments into account. Regarding the crosscompiling: for what I've seen, you need to pass the architecture to yarn to properly compile it. Don't know if I can solve it somehow....
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f611be487a31ee398da4275c436a761c5d59511a commit f611be487a31ee398da4275c436a761c5d59511a Author: Adel KARA SLIMANE <adel@karaslimane.com> AuthorDate: 2021-05-07 00:43:58 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2021-05-27 07:26:50 +0000 app-editors/vscode: New package Visual Studio Code is a lightweight but powerful source code editor which runs on your desktop and is available for Windows, macOS and Linux. It comes with built-in support for JavaScript, TypeScript and Node.js and has a rich ecosystem of extensions for other languages (such as C++, C#, Java, Python, PHP, Go) and runtimes (such as .NET and Unity). Closes: https://bugs.gentoo.org/657628 Closes: https://github.com/gentoo/gentoo/pull/20710 Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com> Signed-off-by: Joonas Niilola <juippis@gentoo.org> app-editors/vscode/Manifest | 3 + .../vscode/files/vscode-url-handler.desktop | 12 +++ app-editors/vscode/files/vscode.desktop | 18 ++++ app-editors/vscode/metadata.xml | 23 +++++ app-editors/vscode/vscode-1.56.2.ebuild | 105 +++++++++++++++++++++ 5 files changed, 161 insertions(+)
