Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 656818 - x11-themes/gtk-engines-flat-2.0 bugs(memleak, crash on load)
Summary: x11-themes/gtk-engines-flat-2.0 bugs(memleak, crash on load)
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-05-29 01:13 UTC by tigsid
Modified: 2018-06-01 11:38 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
out patch for fix desc bugs (patches.tar.bz2,1.71 KB, application/x-bzip-compressed-tar)
2018-05-29 01:13 UTC, tigsid
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tigsid 2018-05-29 01:13:42 UTC
Created attachment 533910 [details]
out patch for fix desc bugs

I like old flat gtk2 engine.
But code quality is not excellent.

1.
When libflat.so loading stand-alone, it is crash,
because not linked "libgtk".
It's affected in libreoffice, qt4-gtkstyle, may be in bug 632237.
I fix it by gtk-engines-flat-2.0-addgtklib.patch

2.
Engine have serious memleak,
because have not finalize func in "flat_style" class
and not free pre-created images.
It's rare affected,
but some times eats all available memory and crash xorg-server.
I fix it by gtk-engines-flat-2.0-memleak.01.patch
Also in this patch,
i disabled pre-render images creation when it's not necessary. 

Our patchs attached.