Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 655556 - www-client/firefox-bin-60.0 fails to set the default locale
Summary: www-client/firefox-bin-60.0 fails to set the default locale
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Thomas Deutschmann (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-05-12 06:16 UTC by Bastien Armand
Modified: 2018-06-27 06:33 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Default locale correction patch (firefox-bin-60-intl.diff,587 bytes, patch)
2018-05-12 06:16 UTC, Bastien Armand
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bastien Armand 2018-05-12 06:16:52 UTC
Created attachment 530966 [details, diff]
Default locale correction patch

Hi,

Since v60 (probably v59), firefox-bin ebuild does not set the default locale anymore.

STR:
- merge firefox-bin-60.0.ebuild with LINGUAS=fr;
- run firefox-bin;
- interface of firefox is in english where it should be in french.

It seems to come from two issues:
- a typo in the ebuild ("linguas" instead of "LINGUAS");
- the configuration setting to set the locale has changed inside firefox since v59 ("intl.locale.requested" instead of "general.useragent.locale").

A patch is attached.

Regards.
Comment 1 Fab 2018-05-15 07:53:42 UTC
Confirmed.

After migrating from firefox 52.x to firefox-bin-60.0, I have to create the "intl.locale.requested" string preference into about:config to get firefox-bin in the right language.
Comment 2 Vyacheslav 2018-05-16 12:48:44 UTC
Confirmed.

I added a string "intl.locale.requested" into about:config with desired language, after that I have right language.
Comment 3 Ole Christensen 2018-06-03 17:51:30 UTC
Confirmed.

Same here. After setting intl.locale.requested to string "de" it works again as before. Suffering from the issue for several weeks (not too bad), but I'm happy there is a solution. Should go into the ebuild imho.
Comment 4 Larry the Git Cow gentoo-dev 2018-06-27 00:58:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=94cb5aed61d1e77ba1781ae5a5cdba4eb3f98f9c

commit 94cb5aed61d1e77ba1781ae5a5cdba4eb3f98f9c
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2018-06-27 00:50:31 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2018-06-27 00:57:53 +0000

    www-client/firefox-bin: bump
    
    - Fix locale: LINGUAS variable should now work again. [Bug 655556]
    
    - Update QA_IGNORE_* variable. [Bug 618830]
    
    Closes: https://bugs.gentoo.org/655556
    Closes: https://bugs.gentoo.org/618830
    Package-Manager: Portage-2.3.40, Repoman-2.3.9

 www-client/firefox-bin/Manifest                  | 172 +++++++++++++++++++++
 www-client/firefox-bin/firefox-bin-52.9.0.ebuild | 183 +++++++++++++++++++++++
 www-client/firefox-bin/firefox-bin-60.1.0.ebuild | 181 ++++++++++++++++++++++
 3 files changed, 536 insertions(+)
Comment 5 Thomas Deutschmann (RETIRED) gentoo-dev 2018-06-27 01:05:11 UTC
Thanks for the patch.

I think this already stopped working for 52.x when we switched to mozlinguas-v2 eclass/L10N.

I am not 100% happy about how this works, i.e. when you run

`L10N="fr de" LINGUAS="fr de" ebuild firefox-bin-60.1.0.ebuild clean install`

you will see

>  * Selected language packs (first will be default): de fr

in build.log which comes from mozlinguas-v2 eclass but later you see

>  * Setting default locale to fr

which doesn't match the previous message. However, it looks like you cannot control the order of the first list (order is controlled by MOZ_LANGS) so we will have to use LINGUAS variable...

Something for the future. For now, default language should take LINGUAS environment variable into account again(?).
Comment 6 Bastien Armand 2018-06-27 06:33:21 UTC
Hi,

I confirm that it is fixed in firefox-bin-60.1.0.

Thanks !

Regards.