hello! I am working on https://bugs.gentoo.org/572170 and it depends on brotlipy, so I am requesting to add it into gentoo repository. I will provide a pull request in a moment.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=413d2406cb7ed7ce1171d8692a9cd2c7a5b6b1df commit 413d2406cb7ed7ce1171d8692a9cd2c7a5b6b1df Author: Oleksandr Trotsenko <oleksandr.trotsenko@gmail.com> AuthorDate: 2018-06-07 18:06:52 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2018-06-24 14:55:26 +0000 dev-python/brotlipy: Introducing the package Introduce the dev/python/brotlipy package into Gentoo. Closes: https://bugs.gentoo.org/654854 Closes: https://github.com/gentoo/gentoo/pull/8261 Package-Manager: Portage-2.3.40, Repoman-2.3.9 dev-python/brotlipy/Manifest | 2 ++ dev-python/brotlipy/brotlipy-0.7.0.ebuild | 48 +++++++++++++++++++++++++++++++ dev-python/brotlipy/metadata.xml | 12 ++++++++ 3 files changed, 62 insertions(+)
Hi, can someone explain why this BROTLI_BUNDLED_COMMIT woo-doo is required? I have compared the outcome of two ebuilds: the one which went to Gentoo with an ebuild available in Pentoo. The results seems exactly the same. Thank you.
oh, I see. It's just for "test". Can the ebuild be enhanced then by adding "test?" condition flag in SRC_URI and src_prepare sections?
hello! In gentoo this ebuild pulls in GitHub release (I believe in Pentoo it's Pypi mirror what is in SRC_URI). In github tarball the libbrotli folder is entirely empty. So we need to download both tarballs in SRC_URI independently of whether tests are enabled. The reason I had to switch away from Pypi to github was because in Pypi for some reason the tarball was missing "test/conftest.py" file and it was necessary for running tests. If you go through the comments in this pull request https://github.com/gentoo/gentoo/pull/8261 you will see the logic which pushed me to this. (Do expand the outdated sections because that's where the discussions were happening). The "BROTLI_BUNDLED_COMMIT" woodoo is nothing else but just the exact commit SHA1 which is bundled within Pypi release already. Even though the 2 ebuilds may look different, I do not think they produce a different result (Do they? Did you find any discrepancy?)
