Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 654814 - app-office/dia still uses freetype-config which is deprecated
Summary: app-office/dia still uses freetype-config which is deprecated
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://gitlab.gnome.org/GNOME/dia/me...
Whiteboard: Waiting for upstream approval
Keywords: PATCH
: 657700 657960 (view as bug list)
Depends on:
Blocks: freetype-config
  Show dependency tree
 
Reported: 2018-05-04 09:38 UTC by Lars Wendler (Polynomial-C) (RETIRED)
Modified: 2018-07-02 09:48 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dia-0.97.3-freetype_pkgconfig.patch (dia-0.97.3-freetype_pkgconfig.patch,2.51 KB, patch)
2018-05-04 09:38 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-05-04 09:38:22 UTC
Created attachment 529716 [details, diff]
dia-0.97.3-freetype_pkgconfig.patch

checking for FT_Init_FreeType in -lfreetype... ./configure: line 17442: freetype
-config: command not found
yes
checking if FreeType version is 2.0.9 or higher... ./configure: line 17482: free
type-config: command not found
configure: error: Need FreeType library version 2.0.9 or higher


The attached patch changes configure.in to use pkg-config instead.
Comment 1 Mart Raudsepp gentoo-dev 2018-05-05 20:44:00 UTC
Can you upstream this?
https://bugzilla.gnome.org/enter_bug.cgi?product=dia

Though they have configure.ac there in git (git.gnome.org/browse/dia), but looks to still be using freetype-config. Mostly stalled project though, unfortunately.
Comment 2 cyrillic 2018-05-13 20:31:53 UTC
This patch works for me, thank you.
Comment 3 Chris Smith 2018-05-14 13:49:14 UTC
Can the ebuild be updated to EAPI=6 with an eapply_user directive?
My brief attempt left me with a GCONF_DEBUG error.
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-06-10 08:19:13 UTC
*** Bug 657700 has been marked as a duplicate of this bug. ***
Comment 5 Massimo Burcheri 2018-06-12 09:43:22 UTC
*** Bug 657960 has been marked as a duplicate of this bug. ***
Comment 6 Massimo Burcheri 2018-06-12 10:11:12 UTC
(In reply to Mart Raudsepp from comment #1)
> Can you upstream this?
> https://bugzilla.gnome.org/enter_bug.cgi?product=dia

Done: https://gitlab.gnome.org/GNOME/dia/issues/9
Comment 7 Mart Raudsepp gentoo-dev 2018-06-27 18:50:58 UTC
If you are confident of the patch, you may merge it in now. Make sure to point at the upstream bug report in bash comments alongside the PATCHES or eapply entry.
Comment 8 Larry the Git Cow gentoo-dev 2018-07-02 09:48:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b743707ba1ffaaaadfbf44f1bd9ad0accd61334a

commit b743707ba1ffaaaadfbf44f1bd9ad0accd61334a
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2018-07-02 09:48:12 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2018-07-02 09:48:12 +0000

    app-office/dia: Use pkg-config instead of freetype-config
    
    Commit permission kindly granted by leio.
    
    Closes: https://bugs.gentoo.org/654814
    Package-Manager: Portage-2.3.41, Repoman-2.3.9

 app-office/dia/dia-0.97.3.ebuild                   |  3 +-
 .../dia/files/dia-0.97.3-freetype_pkgconfig.patch  | 66 ++++++++++++++++++++++
 2 files changed, 68 insertions(+), 1 deletion(-)