Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 652142 - net-p2p/bitcoin-qt-0.16.0 compile fails (with qt 5.10.1)
Summary: net-p2p/bitcoin-qt-0.16.0 compile fails (with qt 5.10.1)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Luke-Jr
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 649026
  Show dependency tree
 
Reported: 2018-04-01 14:31 UTC by Herbert Wantesh
Modified: 2018-04-07 20:49 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
compile log (log.xz,9.29 KB, application/x-xz)
2018-04-01 23:48 UTC, Herbert Wantesh 		Details
emerge --info (emerge.info.xz,3.38 KB, application/x-xz)
2018-04-02 10:16 UTC, Herbert Wantesh 		Details
compile fix (compile.patch,297 bytes, patch)
2018-04-02 11:45 UTC, Herbert Wantesh 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Herbert Wantesh 2018-04-01 14:31:38 UTC 
bitcoin-qt-0.16 fails with this error

In file included from ./qt/walletmodel.h:15:0,
                 from qt/askpassphrasedialog.cpp:13:     
./qt/walletmodeltransaction.h:45:10: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type
     std::unique_ptr<CReserveKey> keyChange;                     
          ^~~~~~~~~~
make[2]: *** [Makefile:6853: qt/qt_libbitcoinqt_a-askpassphrasedialog.o] Error 1
Comment 1 Jonas Stein gentoo-dev 2018-04-01 21:08:29 UTC 
Thank you for the report. Please recompile and *attach* the logfiles,
https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket
and reopen this ticket (Status:unconfirmed).
Comment 2 Herbert Wantesh 2018-04-01 23:48:14 UTC 
Created attachment 526282 [details]
compile log
Comment 3 Jonas Stein gentoo-dev 2018-04-02 09:24:45 UTC 
Thank you for the build log, the emerge --info is still missing.
Comment 4 Herbert Wantesh 2018-04-02 10:16:09 UTC 
Created attachment 526310 [details]
emerge --info
Comment 5 Herbert Wantesh 2018-04-02 11:45:08 UTC 
Created attachment 526324 [details, diff]
compile fix

this patch fixes the compile failure for me
Comment 6 Luke-Jr 2018-04-02 18:59:17 UTC 
Upstream PR: https://github.com/bitcoin/bitcoin/pull/12859

Limited patch added to the overlay, based on the attachment. Are you sure it doesn't need any further includes?

(P.S. Any idea what's unusual about your build environment?)
Comment 7 Herbert Wantesh 2018-04-05 00:33:26 UTC 
qt 5.10.1
Comment 8 Herbert Wantesh 2018-04-05 00:36:27 UTC 
yes with this one include added it compiles
Comment 9 Herbert Wantesh 2018-04-05 00:44:42 UTC 
please add the patch you commited here https://github.com/bitcoin/bitcoin/pull/12859 or my patch to the ebuild
Comment 10 Herbert Wantesh 2018-04-05 00:47:06 UTC 
(In reply to Herbert Wantesh from comment #9)
> please add the patch you commited here
> https://github.com/bitcoin/bitcoin/pull/12859 or my patch to the ebuild

i mean in the official portage tree
Comment 11 Larry the Git Cow gentoo-dev 2018-04-07 20:49:22 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1040395f2b3a9951e450b81b1da096a1118d122f

commit 1040395f2b3a9951e450b81b1da096a1118d122f
Author:     Luke Dashjr <luke-jr+git@utopios.org>
AuthorDate: 2018-04-02 18:35:30 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-04-07 20:48:46 +0000

    net-p2p/bitcoin-qt-0.16.0*: Add missing <memory> include
    
    Closes: https://bugs.gentoo.org/652142
    Closes: https://github.com/gentoo/gentoo/pull/7833

 net-p2p/bitcoin-qt/bitcoin-qt-0.16.0-r1.ebuild              |  2 ++
 .../files/bitcoin-qt-0.16.0-fix_memory_include.patch        | 13 +++++++++++++
 2 files changed, 15 insertions(+)