Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 651646 - net-analyzer/smokeping-2.7.3 files/smokeping.init.5 rrd dump and xml restore not working
Summary: net-analyzer/smokeping-2.7.3 files/smokeping.init.5 rrd dump and xml restore ...
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
Depends on:
Blocks: CVE-2017-20147
  Show dependency tree
Reported: 2018-03-26 20:19 UTC by nic
Modified: 2022-09-18 21:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

smokeping-init (smokeping-init,1.20 KB, text/plain)
2018-04-02 21:59 UTC, nic

Note You need to log in before you can comment on or make changes to this bug.
Description nic 2018-03-26 20:19:28 UTC
The smokeping.init.5 file with unstable net-analyzer/smokeping-2.7.1 incorrectly has the extra commands "dump" and "restore" in the started command list. Both sub commands also incorrectly reference ${myservice} in checking if we are running.

Please split these commands out:

 extra_stopped_commands="dump restore"

And remove the 'if service_started' checks from the dump and restore functions (changing to RC_SVCNAME doesn't make sense here for these commands should only execute when smokeping is not writing to the rrd files)

Thanks ;)
Comment 1 nic 2018-04-02 21:59:56 UTC
Created attachment 526378 [details]

This also restores the logging issue in Bug #651212
Comment 2 nic 2018-04-02 22:10:34 UTC
Clarification; This has actually been an issue with the init script for a while, not just the latest file as originally noted.
smokeping.init.3 dated May 2016 also has the issue in checking the non-existent variable $myservice

These extra commands are very convenient when migrating RRD files between architectures (ie i686 to x86_64).