Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 651616 - net-im/gajim-1.1.3 version bump
Summary: net-im/gajim-1.1.3 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 2 votes (vote)
Assignee: Amadeusz Żołnowski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 663732 663734 663736 675908 684332 685814
Blocks: 629198 640024 669406
  Show dependency tree
 
Reported: 2018-03-26 17:33 UTC by gerion
Modified: 2019-05-29 15:14 UTC (History)
14 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gajim-1.0.0.ebuild (gajim-1.0.0.ebuild,2.12 KB, text/plain)
2018-04-13 15:17 UTC, Alex
Details
logfile from starting gajim (gajim-1.0.1.log,15.37 KB, text/plain)
2018-05-05 18:08 UTC, tastytea
Details
gajim-1.0.3.ebuild (gajim-1.0.3.ebuild,2.28 KB, text/plain)
2018-06-04 23:50 UTC, Alex
Details
gajim-1.0.3.ebuild (gajim-1.0.3.ebuild,2.22 KB, text/plain)
2018-08-15 21:31 UTC, Amadeusz Żołnowski (RETIRED)
Details
metadata.xml (metadata.xml,1.28 KB, text/xml)
2018-08-15 21:31 UTC, Amadeusz Żołnowski (RETIRED)
Details
gajim-1.0.3.ebuild (gajim-1.0.3.ebuild,2.32 KB, text/plain)
2018-08-21 22:51 UTC, Vadim Dyadkin
Details
gajim-1.0.3-r3.ebuild (gajim-1.0.3-r3.ebuild,2.46 KB, text/plain)
2018-10-09 22:57 UTC, Dmitry Suloev
Details
disable-gspell.patch (disable-gspell.patch,798 bytes, patch)
2018-10-09 22:58 UTC, Dmitry Suloev
Details | Diff
disable-gspell-1.1.0.patch (disable-gspell-1.1.0.patch,679 bytes, patch)
2018-11-07 00:53 UTC, tastytea
Details | Diff
gajim-1.1.3.ebuild (gajim-1.1.3.ebuild,2.14 KB, text/plain)
2019-05-13 09:57 UTC, Hanno Böck
Details
gajim-1.1.3.ebuild (gajim-1.1.3.ebuild,2.17 KB, text/plain)
2019-05-16 09:24 UTC, Hanno Böck
Details

Note You need to log in before you can comment on or make changes to this bug.
Description gerion 2018-03-26 17:33:20 UTC
The new GTK3 and Python 3 based Gajim version is out:
https://dev.gajim.org/gajim/gajim/tags
Comment 1 Shiba 2018-04-09 08:37:00 UTC
1.0.1 is out.
Comment 2 Alex 2018-04-13 15:17:56 UTC
Created attachment 527266 [details]
gajim-1.0.0.ebuild

I tried to bump this one not a while ago and got to this:
It builds, it runs, but as soon you do something related to gspell, it segfaults. 
Upstream devs were unable to reproduce that so I don't know if this is my local breakage or else. 

I've included missing deps (like dev-python/precis_i18n or newer nbxmpp) in my overlay (pzskc383). The only thing I couldn't package is python3 libraries for avahi - didn't figure out how to build both multilib and multi-python versions.

Also, regarding PYTHON_COMPAT - it sometimes breaks on start with 3.5 too, more testing neeeded.

I'll try updating it to 1.0.1 and see if it gets better with gspell, etc.

Hope this helps.
Comment 3 tastytea 2018-05-05 18:07:21 UTC
I tried installing gajim 1.0.0 from the pzskc383-overlay. It segfaults shortly after starting, before the GUI shows up.
Enabled useflags: crypt dbus idle jingle rst upnp webp.

I copied the ebuild into my local overlay and renamed it to gajim-1.0.1. It installs, but still segfaults. I tried starting Gajim with a new user, still the same.
I'm attaching a logfile produced with gajim -v. Hope this helps.
Comment 4 tastytea 2018-05-05 18:08:34 UTC
Created attachment 530030 [details]
logfile from starting gajim
Comment 5 Maxim Britov 2018-05-07 08:23:11 UTC
(In reply to tastytea from comment #3)
> It segfaults shortly after starting, before the GUI shows up.

gspell?
On my desktop gajim segfaults on startup if gspell installed, on notebook it works fine with gspell :|
Comment 6 Christian 2018-05-07 11:28:49 UTC
I deleted gspell, restart gajim and still got a segfault, after i updated gst-plugins-gdkpixbuf and rebuild the gajim ebuild. Then it works.

Before that i rebuild every dependency like

dev-python/pygobject-3.24.1
dev-python/pycairo-1.16.3-r1
dev-python/pip-9.0.1-r1
dev-libs/gobject-introspection-1.52.1
dev-python/pyopenssl-17.5.0
dev-python/pyasn1-0.2.3

to ensure that the Python-Target is active on every package, since gajim-1.0.1 use Python3.5.

Since gajim 1.0.x integrate OMEMO encryption i am not sure if its necessary to install python-axolotl locally for the gaim user:

pip3.6 install --user python-axolotl
pip3.5 install --user python-axolotl

Did not run further testing, here some notes to the ebuild:

dev-python/pyopenssl has a new notation now its like 17.5.0.

Thank you Alex, for your ebuild!

I will try later to rebuild with gspell again to ensure it cause the segmentation fault. By the way i did not install precis_i18n. Not on Desktop and on the Laptop. But i did not try to create a user account.
Comment 7 tastytea 2018-05-07 17:20:09 UTC
I deleted app-text/gspell and got no segfault so far. media-plugins/gst-plugins-gdkpixbuf is not installed on my system. I did not rebuild anything manually, just installed the ebuild from the pzskc383-overlay.

For OMEMO, you need to install axolotl and axolotl-curve25519 with python3 support. I changed PYTHON_COMPAT to ( python{2_7,3_4,3_5,3_6} ) in the ebuilds from the pzskc383-overlay and updated(renamed) them to the newest version, that worked.
Comment 8 Alex 2018-05-08 19:23:12 UTC
Thank you Christian and testingtea for trying this and testing.

regarding gspell: I reported bug with gspell on upstream tracker: https://dev.gajim.org/gajim/gajim/issues/8966 
It got closed because I wasn't sure if its mine misconfiguration or something else — I don't have full gnome environment installed and never used anything with gspell before, it might be missing some important options in gnome's dconf registry (or whatever it is). 
If you get segfault with gspell too, please report it on upstream bugtracker, it will help more than here ;)

precis_i18n is not _required_ but it enables proper parsing of malformed or invalid JIDs. I have one person with emoji in their resource and pre-1.0 gajim showed exception dialog every time I log in, was very annoying.

not sure about gst-plugins-gdkpixbuf, probably get pulled by gst-plugins-base.
I don't think it actually needed for gajim, but requirements section in readme ( https://dev.gajim.org/gajim/gajim#runtime-requirements ) lists gst-plugins-base as dependency and I don't want to figure out which ones are actually used. At least for now.

Thanks for pointing out pyopenssl versioning change, I'll update that.
And will re-check deps on python-axolotl{,-curve25519}.

Expect all this some time next week or send patches.
Comment 9 Vadim Dyadkin 2018-05-14 11:39:08 UTC
I was able to install gajim-1.0.2 using this ebuild, thanks for it!
I also have a segfault when gspell is installed, removing it solves the problem.
Unfortunately, gajim-1.0.2 does not seem to better than 0.16. For example, when I close the roster, it does not disappear from the task bar in plasma. It is very irritating.
Comment 10 Alex 2018-06-04 23:50:53 UTC
Created attachment 534872 [details]
gajim-1.0.3.ebuild

Bumped gajim ebuild, attached.

Now it should have correct dependencies.
Changed use flags and their description to be more accurate (e.g. dbus -> remote)

Spellchecking is still broken for me. So is Jingle, but I'm not yet sure what causes this one.
Comment 11 Alexander Tsoy 2018-07-03 09:39:39 UTC
I have some news regarding spellcheck. I tested it in VM and there is no crash if world is compiled with generic CFLAGS (just "-O2 -pipe"). But when I recompile with "-march=core2", then I get the crash due to heap corruption. The next step is to identify the package that causes this (no, it is not a gspell).
Comment 12 Alexander Tsoy 2018-07-03 09:43:31 UTC
This also explains why binary distros doesn't hit this bug.
Comment 13 Amadeusz Żołnowski (RETIRED) gentoo-dev 2018-07-25 22:19:32 UTC
Guys, good job on improving ebuild and narrowing down the spellchecker issue.

Alex, could you include the ebuilds for deps here, please? I cannot access your overlay.
Comment 14 Shiba 2018-07-26 10:46:00 UTC
We definitely have app-text/enchant-1.6.1 broken. I don't know if it's our problem or upstream, but upgrading to 2.1.2 (API change, rebuild gspell as well) or downgrading to 1.6.0 (here if you wanna test https://github.com/gentoo-mirror/gentoo/blob/56bd759df1d0c750a065b8c845e93d5dfa6b549d/app-text/enchant/enchant-1.6.0.ebuild) stops the SIGSEGVs for Gspell.

I'm not sure if a bug report should be opened for enchant or gspell though...
Comment 15 Shiba 2018-07-26 10:48:49 UTC
Sorry for the double post.
Meanwhile I'm reporting this upstream and see if they can reproduce this.
Comment 16 Shiba 2018-07-27 10:01:09 UTC
Enchant's Zemberek component causes the crash and as of 1.6.1 having dbus-glib installed is a sufficient requirement to build it. I reported this particular bug here: https://github.com/AbiWord/enchant/issues/199
If someone knows his way around autotools this could easily be patched and upstreamed.

Because of how our dependencies tree is, dbus-glib gets build AFTER enchant, so that's why Alex is not experiencing this in his -march-"less" build. I'm sure if you rebuild enchant after having dbus-glib installed, you'll get the same error despite not setting -march.
Comment 17 Alexander Tsoy 2018-07-30 17:09:53 UTC
Shiba, thanks for tracking this down to zemberek provider. I also noticed that the problem was caused by enchant, but failed to debug it further.
Comment 18 Amadeusz Żołnowski (RETIRED) gentoo-dev 2018-07-31 23:05:31 UTC
dev-python/precis-i18n (NOT dev-python/precis_i18n) is in the tree.
Comment 19 Amadeusz Żołnowski (RETIRED) gentoo-dev 2018-07-31 23:10:11 UTC
Actually is not, pushed denied because my clock got out of sync. I'll fix it tomorrow.
Comment 20 Amadeusz Żołnowski (RETIRED) gentoo-dev 2018-08-01 21:03:08 UTC
precis-i18n - pushed.
Comment 21 Amadeusz Żołnowski (RETIRED) gentoo-dev 2018-08-14 21:29:35 UTC
Why do we have omemo flag? OMEMO is not mentioned anywhere in Gajim README file.
Comment 22 Amadeusz Żołnowski (RETIRED) gentoo-dev 2018-08-15 21:31:19 UTC
Created attachment 543638 [details]
gajim-1.0.3.ebuild

I have updated dependencies. Use flags are renamed to either match some from global use flags or to relate more to the feature name.
Comment 23 Amadeusz Żołnowski (RETIRED) gentoo-dev 2018-08-15 21:31:59 UTC
Created attachment 543640 [details]
metadata.xml

I have described the use flags.
Comment 24 manwe 2018-08-20 18:24:04 UTC
1. There's a conflict - gajim 1.0.x requires dev-python/pycrypto with USE=crypto. With USE=addns net-fs/samba depends on dev-python/dnspython which requires dev-python/pycryptodome. And dev-python/pycryptodome blocks dev-python/pycrypto.

2. Gajim 1.0.3 ends up with segfault for me:
[ 3768.552987] gajim[17036]: segfault at 7fa4517a9d00 ip 00007fa4618a55fc sp 00007ffe889ed840 error 4 in libglib-2.0.so.0.5400.3[7fa46185b000+112000] (somewhere between creating all necessary directories in $HOME and showing up GUI).
Comment 25 Thomas Beinicke 2018-08-20 18:42:16 UTC
(In reply to manwe from comment #24)
> 1. There's a conflict - gajim 1.0.x requires dev-python/pycrypto with
> USE=crypto. With USE=addns net-fs/samba depends on dev-python/dnspython
> which requires dev-python/pycryptodome. And dev-python/pycryptodome blocks
> dev-python/pycrypto.
> 
> 2. Gajim 1.0.3 ends up with segfault for me:
> [ 3768.552987] gajim[17036]: segfault at 7fa4517a9d00 ip 00007fa4618a55fc sp
> 00007ffe889ed840 error 4 in libglib-2.0.so.0.5400.3[7fa46185b000+112000]
> (somewhere between creating all necessary directories in $HOME and showing
> up GUI).

If you follow the advice in comment https://bugs.gentoo.org/651616#c16 gajim-1.0.3 will not segfault anymore.
Comment 26 Vadim Dyadkin 2018-08-20 18:43:09 UTC
(In reply to manwe from comment #24)
> 1. There's a conflict - gajim 1.0.x requires dev-python/pycrypto with
> USE=crypto. With USE=addns net-fs/samba depends on dev-python/dnspython
> which requires dev-python/pycryptodome. And dev-python/pycryptodome blocks
> dev-python/pycrypto.

app-text/calibre also depends on dev-python/pycryptodome and blocks dev-python/pycrypto.
Comment 27 Amadeusz Żołnowski (RETIRED) gentoo-dev 2018-08-20 20:42:05 UTC
Can someone test gajim-1.0.3 with pycryptodome instead, please? Gajim should be switched to pycryptodome anyway. I have bumped nbxmpp in the tree, so you just need to drop gajim-1.0.3 ebuild in local overlay. Thanks.
Comment 28 Vadim Dyadkin 2018-08-21 15:50:20 UTC
(In reply to Amadeusz Żołnowski from comment #27)
> Can someone test gajim-1.0.3 with pycryptodome instead, please? Gajim should
> be switched to pycryptodome anyway. I have bumped nbxmpp in the tree, so you
> just need to drop gajim-1.0.3 ebuild in local overlay. Thanks.

It works for me, I just changed in the ebuild pycrypto to pycryptodome, rebuilt gajim and it is running as before, no complains about 'import error' and so on.
Comment 29 Amadeusz Żołnowski (RETIRED) gentoo-dev 2018-08-21 20:32:16 UTC
Thanks, Vadim. Please feel free to update the "gajim-1.0.3.ebuild" attachment.
Comment 30 Vadim Dyadkin 2018-08-21 22:51:23 UTC
Created attachment 544424 [details]
gajim-1.0.3.ebuild
Comment 31 Gleb 2018-10-06 18:56:44 UTC
Can anyone please post "0001-Disable-spell-checking.patch"?
Comment 32 Dmitry Suloev 2018-10-09 22:57:30 UTC
Created attachment 550300 [details]
gajim-1.0.3-r3.ebuild
Comment 33 Dmitry Suloev 2018-10-09 22:58:02 UTC
Created attachment 550302 [details, diff]
disable-gspell.patch
Comment 34 Alexander Tsoy 2018-10-26 15:01:51 UTC
I've opened pull request to fix enchant some time ago. See bug 662484
Comment 35 tastytea 2018-11-07 00:07:41 UTC
Version 1.1.0 is out. I still get a segmentation fault with spell enabled.

The code that checks for gspell has changed, so I wrote a new patch: https://schlomp.space/tastytea/overlay/raw/branch/master/net-im/gajim/files/disable-gspell-1.1.0.patch

Gajim wouldn't start without dev-python/keyring installed, I fixed it with "use keyring || sed -i 's/keyring//' setup.cfg" in src_prepare() in my ebuild. I'm sure there is a better way but I'm not familiar with python and python ebuilds.

There is also the problem that the buildscript compresses the manpages with gzip but portage wants to compress manpages itself.

Anyway, here is my ebuild: https://schlomp.space/tastytea/overlay/raw/branch/master/net-im/gajim/gajim-1.1.0-r1.ebuild It is quick & dirty but it works. :-)
Comment 36 tastytea 2018-11-07 00:53:45 UTC
Created attachment 554330 [details, diff]
disable-gspell-1.1.0.patch
Comment 37 Alex 2018-12-21 13:41:04 UTC
For what it worth, it seems that gspell-related crash is not unique to gajim, it happened to me when I tried to bump games-mud/kildclient to 3.2.0. Crash happens with very similar looking stack trace.
Comment 38 Hanno Böck gentoo-dev 2019-01-02 15:51:06 UTC
I tracked down the gspell crash. It's actually a very bad API design in libX11 and subsequently a wrong API use by Gtk+. I reported it upstream:
https://gitlab.gnome.org/GNOME/gtk/issues/1556
Comment 39 Hanno Böck gentoo-dev 2019-01-20 13:07:26 UTC
I have to add something my previous comment.

The crash I reported to gtk+ upstream was straightforward and is now fixed in 3.24.3. However I get another crash that is much more tricky to analyze.

I'll open a separate bug and will try to get some help from other devs.
Comment 40 Paweł Ciechomski 2019-02-03 11:56:10 UTC
Actually there is 1.1.3 available
https://dev.gajim.org/gajim/gajim/tags
Comment 41 Paweł Ciechomski 2019-02-03 11:56:40 UTC
(In reply to Paweł Ciechomski from comment #40)
> Actually there is 1.1.3 available
> https://dev.gajim.org/gajim/gajim/tags

Mistake - 1.1.2 is the newest version
Comment 42 Mart Raudsepp gentoo-dev 2019-03-10 13:35:41 UTC
Meanwhile I will remove USE=jingle from the old gajim version soon, as it is the last blocker for getting rid of highly security vulnerable gstreamer:0.10 stuff, and can't justify any more waits for that.
Comment 43 Larry the Git Cow gentoo-dev 2019-03-24 22:10:37 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8b1a498ff7872a284408f58634ccb4a75368935a

commit 8b1a498ff7872a284408f58634ccb4a75368935a
Author:     Amadeusz Piotr Żołnowski <aidecoe@gentoo.org>
AuthorDate: 2019-03-24 22:07:20 +0000
Commit:     Amadeusz Piotr Żołnowski <aidecoe@gentoo.org>
CommitDate: 2019-03-24 22:10:27 +0000

    net-im/gajim: Bump version
    
    Drop x86-fbsd keyword because new deps are missing those keyword.
    
    Bug: https://bugs.gentoo.org/651616
    Signed-off-by: Amadeusz Piotr Żołnowski <aidecoe@gentoo.org>

 net-im/gajim/Manifest                              |  1 +
 net-im/gajim/files/1.0.3-0001-disable-gspell.patch | 23 ++++++
 net-im/gajim/gajim-1.0.3.ebuild                    | 84 ++++++++++++++++++++++
 net-im/gajim/metadata.xml                          | 12 ++++
 4 files changed, 120 insertions(+)
Comment 44 Hanno Böck gentoo-dev 2019-05-13 09:57:14 UTC
Created attachment 576404 [details]
gajim-1.1.3.ebuild

Attaching an updated ebuild for gajim 1.1.3.

This is based on the 1.0.3-r1 ebuild in the tree, with the following changes:
* ported to EAPI 7 and avoid versionator eclass.
* keyring dependency is no longer optional (gajim doesn't run without it).
* new required cssutils dependency
* Updated nbxmpp and secretstorage dependency.

The latter two require version bumps, secretstorage is tracked in #684332 (simple copy-over bump), I'll open another bug for nbxmpp.
Comment 45 tastytea 2019-05-13 15:46:59 UTC
keyring can be made optional again with
    use keyring || sed -i 's/keyring//' setup.cfg || die
in src_prepare(). Gajim runs fine without it.
Comment 46 Alexander Tsoy 2019-05-15 16:26:29 UTC
(In reply to Hanno Boeck from comment #44)
> Created attachment 576404 [details]
> gajim-1.1.3.ebuild
Shouldn't it depend on >=dev-python/cssutils-1.0.2[${PYTHON_USEDEP}] ?
Comment 47 Hanno Böck gentoo-dev 2019-05-16 09:23:47 UTC
(In reply to Alexander Tsoy from comment #46)
> (In reply to Hanno Boeck from comment #44)
> > Created attachment 576404 [details]
> > gajim-1.1.3.ebuild
> Shouldn't it depend on >=dev-python/cssutils-1.0.2[${PYTHON_USEDEP}] ?

true, I'll upload a new one.
Comment 48 Hanno Böck gentoo-dev 2019-05-16 09:24:24 UTC
(In reply to tastytea from comment #45)
> keyring can be made optional again with
>     use keyring || sed -i 's/keyring//' setup.cfg || die
> in src_prepare(). Gajim runs fine without it.

I'd rather not do something that is unsupported by upstream. If you feel strongly try to convince upstream to make it optional again.
Comment 49 Hanno Böck gentoo-dev 2019-05-16 09:24:53 UTC
Created attachment 576908 [details]
gajim-1.1.3.ebuild
Comment 50 Larry the Git Cow gentoo-dev 2019-05-29 15:14:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8fef1e209df685b309b625dd8fe1978509d36d3c

commit 8fef1e209df685b309b625dd8fe1978509d36d3c
Author:     Hanno <hanno@gentoo.org>
AuthorDate: 2019-05-29 15:14:03 +0000
Commit:     Hanno <hanno@gentoo.org>
CommitDate: 2019-05-29 15:14:03 +0000

    net-im/gajim: Version bump.
    
    Update dependencies, remove keyring USE flag (no longer optional upstream).
    Update EAPI to 7, avoid versionator eclass.
    Add myself as maintainer.
    
    Closes: https://bugs.gentoo.org/651616
    Signed-off-by: Hanno Boeck <hanno@gentoo.org>
    Package-Manager: Portage-2.3.67, Repoman-2.3.13

 net-im/gajim/Manifest           |  1 +
 net-im/gajim/gajim-1.1.3.ebuild | 78 +++++++++++++++++++++++++++++++++++++++++
 net-im/gajim/metadata.xml       |  2 +-
 3 files changed, 80 insertions(+), 1 deletion(-)