Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 650578 - sys-cluster/util-vserver-0.30.216_pre3120-r1 : /.../fs.h:366:23: error: expected = , , , ; , asm or _attribute_ before _kernel_rwf_t
Summary: sys-cluster/util-vserver-0.30.216_pre3120-r1 : /.../fs.h:366:23: error: expec...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrice Clement
URL:
Whiteboard:
Keywords: PMASKED, PullRequest
Depends on:
Blocks:
 
Reported: 2018-03-15 17:12 UTC by Toralf Förster
Modified: 2019-03-25 21:41 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,15.79 KB, text/plain)
2018-03-15 17:12 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,72.32 KB, text/plain)
2018-03-15 17:12 UTC, Toralf Förster
Details
environment (environment,78.03 KB, text/plain)
2018-03-15 17:12 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,11.31 KB, application/x-bzip)
2018-03-15 17:12 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,12.83 KB, application/x-bzip)
2018-03-15 17:12 UTC, Toralf Förster
Details
sys-cluster:util-vserver-0.30.216_pre3120-r1:20180315-030939.log (sys-cluster:util-vserver-0.30.216_pre3120-r1:20180315-030939.log,91.49 KB, text/plain)
2018-03-15 17:12 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,26.74 KB, application/x-bzip)
2018-03-15 17:12 UTC, Toralf Förster
Details
Use dietlibc header files (util-vserver-0.30.216-pre3120-dietlibc.patch,977 bytes, patch)
2019-02-19 09:03 UTC, Sandino Araico Sanchez
Details | Diff
ebuild with dietlibc patch (util-vserver-0.30.216_pre3120-r2.ebuild,2.58 KB, text/plain)
2019-02-19 09:13 UTC, Sandino Araico Sanchez
Details
dietlibc headers patch for 0.30.216_pre3131 (util-vserver-0.30.216-pre3131-dietlibc.patch,1.08 KB, patch)
2019-02-19 09:24 UTC, Sandino Araico Sanchez
Details | Diff
ebuild for 0.30.216_pre3131 (util-vserver-0.30.216_pre3131.ebuild,2.58 KB, text/plain)
2019-02-19 09:25 UTC, Sandino Araico Sanchez
Details
Ebuild for 0.30.216_pre3120 with dietlibc and runtime paths patches (util-vserver-0.30.216_pre3120-r3.ebuild,2.67 KB, text/plain)
2019-02-19 11:24 UTC, Sandino Araico Sanchez
Details
ebuild for 0.30.216_pre3131 (util-vserver-0.30.216_pre3131.ebuild,2.67 KB, text/plain)
2019-02-19 11:34 UTC, Sandino Araico Sanchez
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2018-03-15 17:12:02 UTC
diet -Os x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I.  -I ./lib -I ./ensc_wrappers -D_GNU_SOURCE -D_REENTRANT  -DNDEBUG   -O2 -pipe -march=native -std=c99 -Wall -pedantic -W -funit-at-a-time -c -o lib_internal/lib_internal_libinternal_diet_a-util-cleanupmount.o `test -f 'lib_internal/util-cleanupmount.c' || echo './'`lib_internal/util-cleanupmount.c
In file included from lib_internal/util-cleanupmount.c:25:0:
/usr/include/linux/fs.h:366:23: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘__kernel_rwf_t’
 typedef int __bitwise __kernel_rwf_t;
                       ^~~~~~~~~~~~~~
make[2]: *** [Makefile:7531: lib_internal/lib_internal_libinternal_diet_a-util-cleanupmount.o] Error 1

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.0-desktop-gnome-systemd_libressl_20180312-192912

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.3.0 *

Available Python interpreters, in order of preference:
  [1]   python3.5
  [2]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby22 (with Rubygems)
  [2]   ruby23 (with Rubygems) *



emerge -qpv sys-cluster/util-vserver
[ebuild  N    ] sys-cluster/util-vserver-0.30.216_pre3120-r1
Comment 1 Toralf Förster gentoo-dev 2018-03-15 17:12:05 UTC
Created attachment 524046 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2018-03-15 17:12:09 UTC
Created attachment 524048 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2018-03-15 17:12:12 UTC
Created attachment 524050 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2018-03-15 17:12:15 UTC
Created attachment 524052 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2018-03-15 17:12:18 UTC
Created attachment 524054 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2018-03-15 17:12:21 UTC
Created attachment 524056 [details]
sys-cluster:util-vserver-0.30.216_pre3120-r1:20180315-030939.log
Comment 7 Toralf Förster gentoo-dev 2018-03-15 17:12:24 UTC
Created attachment 524058 [details]
temp.tbz2
Comment 8 Tor Rune Skoglund 2019-01-22 16:16:23 UTC
This issue is probably not related to gcc itself, but the linux-headers used when compiling util-vserver. 

At least when compiling util-vserver with linux-headers 4.14 on a vserver kernel 4.9, the problem appears. When installing linux-headers that match the running kernel version, i.e. linux-headers-4.9, the problem goes away on my systems, with both gcc 6.4 and gcc 7.3.
Comment 9 Tor Rune Skoglund 2019-01-24 17:11:28 UTC
Actually, based on this debian bug report, it seems to be a dietlibc shortcoming: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=885961
Comment 10 Sandino Araico Sanchez 2019-02-19 09:03:20 UTC
Created attachment 565830 [details, diff]
Use dietlibc header files

This patch replaces the conflicting glibc headers with dietlibc's. 
Can you give it a try?
Comment 11 Sandino Araico Sanchez 2019-02-19 09:13:29 UTC
Created attachment 565832 [details]
ebuild with dietlibc patch

This ebuild applies the attached (565830) dietlibc headers patch
Comment 12 Sandino Araico Sanchez 2019-02-19 09:24:01 UTC
Created attachment 565834 [details, diff]
dietlibc headers patch for 0.30.216_pre3131

This patch is for version 0.30.216_pre3131. Include dietlibc headers instead of /usr/include/linux kernel headers.
Comment 13 Sandino Araico Sanchez 2019-02-19 09:25:37 UTC
Created attachment 565836 [details]
ebuild for 0.30.216_pre3131

ebuild for util-vserver 0.30.216_pre3131 with dietlibc headers patch
Please try.
Comment 14 Sandino Araico Sanchez 2019-02-19 11:24:05 UTC
Created attachment 565850 [details]
Ebuild for 0.30.216_pre3120 with dietlibc and runtime paths patches

Updated ebuild with dietlibc headers patch and fixes for runtime paths in bug 632586 with patch in attachment 565846 [details, diff]
Comment 15 Sandino Araico Sanchez 2019-02-19 11:34:02 UTC
Created attachment 565852 [details]
ebuild for 0.30.216_pre3131
Comment 16 Patrice Clement gentoo-dev 2019-02-19 22:52:00 UTC
Sandino thank you for your contribution. Could you please file a PR on Github instead? Please for the time being include only the patch. We will deal with the version bump later. Thanks!
Comment 17 Sandino Araico Sanchez 2019-03-21 12:38:31 UTC
PR #11117 was never merged.
I have filed a new PR #11442 with dietlibc patch.
Comment 18 Patrice Clement gentoo-dev 2019-03-22 22:52:50 UTC
(In reply to Sandino Araico Sanchez from comment #17)
> PR #11117 was never merged.
> I have filed a new PR #11442 with dietlibc patch.

PRs must be signed off. You never did. For the record, here's the comment I left on PR#11117:
"Thanks @KenjiBrown. You must sign off your contribution for me to merge it."
Comment 19 Sandino Araico Sanchez 2019-03-25 10:18:46 UTC
New, clieaner pull request  #11493, with the signed-off tag and only one commit.
Comment 20 Larry the Git Cow gentoo-dev 2019-03-25 21:41:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7b3fe2e4f69b3fc950ecadc3eb10eb91d7a977a1

commit 7b3fe2e4f69b3fc950ecadc3eb10eb91d7a977a1
Author:     Sandino Araico Sanchez <sandino@sandino.net>
AuthorDate: 2019-03-25 10:12:13 +0000
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: 2019-03-25 21:40:50 +0000

    sys-cluster/util-vserver: fix dietlibc headers patch.
    
    This patch replaces the conflicting glibc headers with dietlibc's.
    
    Closes: https://bugs.gentoo.org/650578
    Closes: https://github.com/gentoo/gentoo/pull/11493
    Signed-off-by: Sandino Araico Sanchez <sandino@sandino.net>
    Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

 .../util-vserver-0.30.216_pre3120-dietlibc.patch   | 23 ++++++++++++++++++++++
 .../util-vserver-0.30.216_pre3120-r1.ebuild        |  6 +++---
 2 files changed, 26 insertions(+), 3 deletions(-)