Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 648758 - <sys-devel/binutils-2.30-r2 lost TEXTREL warning on non-shared objects
Summary: <sys-devel/binutils-2.30-r2 lost TEXTREL warning on non-shared objects
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL: https://sourceware.org/PR22909
Whiteboard:
Keywords: PATCH
Depends on: binutils-2.30-stable
Blocks:
  Show dependency tree
 
Reported: 2018-02-25 11:54 UTC by Sergei Trofimovich (RETIRED)
Modified: 2019-03-24 20:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
binutils-2.30-restore-TEXTREL-warnings.patch (binutils-2.30-restore-TEXTREL-warnings.patch,665 bytes, patch)
2018-02-28 23:40 UTC, Sergei Trofimovich (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Trofimovich (RETIRED) gentoo-dev 2018-02-25 11:54:59 UTC 
Noticed it when was debugging bug #566118. gcc is unconditionally built with -fno-PIE -no-pie which means we lose TEXTREL warning.

Last full patch:
    https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo/src/patchsets/binutils/2.25.1/66_all_binutils-2.22.52.0.1-warn-textrel.patch?revision=1.1&view=markup

First partial patch:
    https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo/src/patchsets/binutils/2.26.1/00_all_0004-ld-always-warn-about-textrels-in-files.patch?view=markup

Note how it used to report warning for both shared objects and executables.
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2018-02-28 23:40:57 UTC 
Created attachment 521522 [details, diff]
binutils-2.30-restore-TEXTREL-warnings.patch
Comment 2 Andreas K. Hüttel archtester gentoo-dev 2018-03-01 20:50:35 UTC 
Added to gentoo/binutils-2.29.1, gentoo/binutils-2.30, and gentoo/binutils-9999 branch
Comment 3 Sergei Trofimovich (RETIRED) gentoo-dev 2018-03-01 22:14:07 UTC 
Filed upstream bug to upstream our extension: https://sourceware.org/PR22909