Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 647616 - net-libs/c-client: fails to compile with openssl 1.1
Summary: net-libs/c-client: fails to compile with openssl 1.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Net-Mail Packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: openssl-1.1
  Show dependency tree
 
Reported: 2018-02-14 16:43 UTC by Hanno Böck
Modified: 2023-02-06 03:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (net-libs:c-client-2007f-r6:20180214-164037.log,11.67 KB, text/plain)
2018-02-14 16:43 UTC, Hanno Böck
Details
imap-2007f-openssl-1.1.patch (imap-2007f-openssl-1.1.patch,2.79 KB, patch)
2018-09-24 13:02 UTC, Johannes Hirte
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hanno Böck gentoo-dev 2018-02-14 16:43:47 UTC
Created attachment 519414 [details]
build log

I'll attach the build log.
Comment 1 Johannes Hirte 2018-09-24 13:02:27 UTC
Created attachment 547768 [details, diff]
imap-2007f-openssl-1.1.patch

patch based on: https://github.com/openwrt/packages/commit/b087da8530a8889bd7c765dddbbe218116d11643
Comment 2 Larry the Git Cow gentoo-dev 2018-10-24 15:07:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c2626757b304cbe1ba5da551b0db496989e95cc0

commit c2626757b304cbe1ba5da551b0db496989e95cc0
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2018-10-24 15:07:24 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2018-10-24 15:07:39 +0000

    net-libs/c-client: Fixed build with openssl-1.1
    
    Closes: https://bugs.gentoo.org/647616
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 net-libs/c-client/c-client-2007f-r6.ebuild         | 33 ++++++-----
 .../files/c-client-2007f-openssl-1.1.patch         | 66 ++++++++++++++++++++++
 2 files changed, 86 insertions(+), 13 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2023-02-06 03:59:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bcd6b6d96343c2a56ed7f0df97dc9ec13daa94c9

commit bcd6b6d96343c2a56ed7f0df97dc9ec13daa94c9
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-02-06 03:56:03 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-02-06 03:58:50 +0000

    net-libs/c-client: add 2007f_p7
    
    One of our patches (c-client-2007f-openssl-1.1.patch, which seems
    to have been from - or derived from at least - openwrt at
    https://github.com/openwrt/packages/commit/b087da8530a8889bd7c765dddbbe218116d11643)
    has been causing issues with OpenSSL 1.1 by not giving proper regard
    to the return value of ssl_validate_cert.
    
    There's a suggested alternative fixed patch in the bug, but given that
    c-client is one of those zombie packages we need to keep but isn't
    active upstream, let's try switching to Debian's patchset, as it
    works for them, and the effective diff comparing prepared sources before/after
    is pretty small overall.
    
    (We also end up cleaning up a few things, like the library stops exporting
    'Gethostbyname' (with a capital G) and such.)
    
    Scott Tester <scott@smbc.edu.au> deserves a special mention for being persistent
    here. Thank you!
    
    Bug: https://bugs.gentoo.org/647616
    Closes: https://bugs.gentoo.org/683708
    Signed-off-by: Sam James <sam@gentoo.org>

 net-libs/c-client/Manifest                         |   1 +
 net-libs/c-client/c-client-2007f_p7.ebuild         | 172 +++++++++++++++++++++
 .../files/c-client-2007f_GENTOO_amd64-so-fix.patch |  12 ++
 ...-client-2007f_p7-implicit-declaration-fix.patch |  46 ++++++
 .../c-client/files/c-client-2007f_p7-ldflags.patch |  33 ++++
 5 files changed, 264 insertions(+)