Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 647222 - net-misc/dropbox-cli should depend on dev-python/pygpgme?
Summary: net-misc/dropbox-cli should depend on dev-python/pygpgme?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andrey Grozin
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-10 13:47 UTC by Andrew
Modified: 2022-05-23 10:06 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew 2018-02-10 13:47:35 UTC
When Dropbox daemon installation is started with dropbox-cli start -i the launcher warns that the download won't be verified because pygpgme is not found which is fixed by installing dev-python/pygpgme. I believe it should be declared as a dependency, maybe optional but enabled by default.

dropbox-cli version is 1.6.0
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2018-02-10 13:51:24 UTC
If it does not fail then why should it be a dependency? If it is optional then the build doesn't actually change, so you'd be recompiling the package just to pull in the dependency.
Comment 2 Andrey Grozin gentoo-dev 2018-02-10 16:22:12 UTC
(In reply to Jeroen Roovers from comment #1)
> If it does not fail then why should it be a dependency? If it is optional
> then the build doesn't actually change, so you'd be recompiling the package
> just to pull in the dependency.
Well, in this particular package nothing is compiled, just a python script is installed. So, re-emerging it is cheap. Still, I see no point in introducing this dependency because it is a purely optional runtime one. Any user can install it later if [s]he wants.
Comment 3 Andreas Sturmlechner gentoo-dev 2018-12-13 23:16:39 UTC
So, should the ebuild maybe mention this optional runtime dependency in an elog message?
Comment 4 Andrew 2018-12-15 11:28:36 UTC
If an optional feature would have the dependency than I would agree about not adding it. In this case missing pygpgme leads to the downloaded binary not being verified which is a security matter and should be treated as such. As of now the package is less secure by default which is no good.
Comment 5 Larry the Git Cow gentoo-dev 2019-03-14 16:18:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d7b090b997c59b12f2762be59902c51821af1ae9

commit d7b090b997c59b12f2762be59902c51821af1ae9
Author:     Andrey Grozin <grozin@gentoo.org>
AuthorDate: 2019-03-14 16:16:46 +0000
Commit:     Andrey Grozin <grozin@gentoo.org>
CommitDate: 2019-03-14 16:17:35 +0000

    net-misc/dropbox-cli: bump to 19
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=678958
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=647222
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Andrey Grozin <grozin@gentoo.org>

 net-misc/dropbox-cli/Manifest                      |  1 +
 net-misc/dropbox-cli/dropbox-cli-19.ebuild         | 31 ++++++++++++++++++++++
 .../dropbox-cli/files/dropbox-cli-19-completion    |  2 ++
 3 files changed, 34 insertions(+)