Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 646566 - media-sound/pulseaudio-11.1 needs a patch for glibc-2.27-r1
Summary: media-sound/pulseaudio-11.1 needs a patch for glibc-2.27-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://bugs.freedesktop.org/show_bug...
Whiteboard:
Keywords: PATCH
: 650858 (view as bug list)
Depends on:
Blocks: glibc-2.27
  Show dependency tree
 
Reported: 2018-02-04 11:17 UTC by Helmut Jarausch
Modified: 2018-06-02 17:08 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch that allow pulseaudio to be built with glibc-2.27 (glibc-2.27.patch,1.54 KB, patch)
2018-02-11 15:02 UTC, Cănărău Constantin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Helmut Jarausch 2018-02-04 11:17:56 UTC
glibc-2.27-r1 defines the function memfd_create;
therefore it mustn't be redefined in pulseaudio

Insert the following lines into the src-prepare function

	# glibc-2.27 defines memfd_create
	sed -i -e'/static inline int memfd_create/,+2 d' src/pulsecore/memfd-wrappers.h
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2018-02-07 21:50:20 UTC
Please provide a patch as unified diff. You might want to submit this issue upstream as well.
Comment 2 Cănărău Constantin 2018-02-11 15:02:35 UTC
Created attachment 519088 [details, diff]
patch that allow pulseaudio to be built with glibc-2.27

It seems that upstream is already aware of the issue.
Comment 3 Sergei Trofimovich (RETIRED) gentoo-dev 2018-02-21 22:51:15 UTC
(In reply to Cănărău Constantin from comment #2)
> It seems that upstream is already aware of the issue.

Is there a link to upstream bug report? (or even patch applied)
Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev 2018-02-21 22:53:50 UTC
> Is there a link to upstream bug report? (or even patch applied)
Ah, found it:

https://bugs.freedesktop.org/show_bug.cgi?id=104733
https://github.com/pulseaudio/pulseaudio/commit/dfb0460fb4743aec047cdf755a660a9ac2d0f3fb
Comment 5 Ulenrich 2018-05-23 10:51:59 UTC
Appearently also Debian-unstable applied this patch on 2018-04-05, ChangeLog:
---
 Backport upstream patch to use memfd_create wrapper provided by glibc                                         
    if available.                                                                                                 
    (Closes: #894104) 
---
Comment 6 Andreas Sturmlechner gentoo-dev 2018-05-28 22:27:15 UTC
*** Bug 650858 has been marked as a duplicate of this bug. ***
Comment 7 Larry the Git Cow gentoo-dev 2018-06-02 17:08:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=80fdc7def4a6fefb711f282435ebc14f10078422

commit 80fdc7def4a6fefb711f282435ebc14f10078422
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-05-28 22:16:41 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-06-02 17:06:37 +0000

    media-sound/pulseaudio: Fix build with glibc-2.27
    
    Closes: https://bugs.gentoo.org/646566
    Package-Manager: Portage-2.3.40, Repoman-2.3.9

 .../files/pulseaudio-11.1-glibc-2.27.patch         | 59 ++++++++++++++++++++++
 media-sound/pulseaudio/pulseaudio-11.1-r1.ebuild   |  5 +-
 2 files changed, 63 insertions(+), 1 deletion(-)