Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 644284 - net-libs/webkit-gtk: Unknown CMake command "WEBKIT_PREPEND_GLOBAL_COMPILER_FLAG" on arm64
Summary: net-libs/webkit-gtk: Unknown CMake command "WEBKIT_PREPEND_GLOBAL_COMPILER_FL...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: ARM64 Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-12 07:13 UTC by Alexander 'E-Razor' Krause
Modified: 2018-07-23 22:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
rpi3_64.patch (file_644284.txt,501 bytes, patch)
2018-04-15 15:30 UTC, acidhell
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander 'E-Razor' Krause 2018-01-12 07:13:29 UTC
I'm trying to compile webkit-gtk natively on a Raspberry PI 3.

The ebuild stops in the cmake test phase:

-- Performing Test CXX_COMPILER_SUPPORTS_-fdiagnostics-color=always - Success
CMake Error at Source/cmake/OptionsCommon.cmake:39 (WEBKIT_PREPEND_GLOBAL_COMPILER_FLAG):
  Unknown CMake command "WEBKIT_PREPEND_GLOBAL_COMPILER_FLAG".
Call Stack (most recent call first):
  Source/cmake/WebKitCommon.cmake:58 (include)
  CMakeLists.txt:168 (include)

Cmake checks for the current CPU
  if (WTF_CPU_ARM64_CORTEXA53)

and then tries to add another compiler flag:
  WEBKIT_PREPEND_GLOBAL_COMPILER_FLAG(-mfix-cortex-a53-835769)

I've had a look at Source/cmake/WebKitCompilerFlags.cmake and it seems the name should be WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS
Comment 1 Mart Raudsepp gentoo-dev 2018-01-12 07:43:03 UTC
Looks like they had this bug ever since adding the compile tested flag adding in https://bugs.webkit.org/show_bug.cgi?id=174490 or something.
Note that this compile flag and another errata one can be useful globally to avoid issues on at least the earlier Cortex A53's like RPi3.
Should get this reported upstream if it isn't yet at bugs.webkit.org, feel free to help with doing that yourself sooner and linking with See also, URL or comment (in that order of preference, depending on what you can edit)
Comment 2 acidhell 2018-02-28 20:43:33 UTC
Any news about this bug? Inside this "https://bugs.webkit.org/show_bug.cgi?id=174490" there is a patch that I can't use
Comment 3 acidhell 2018-04-15 08:01:36 UTC
I 've managed to find the root of the problem here.
https://trac.webkit.org/changeset/229155/webkit
Comment 4 acidhell 2018-04-15 15:30:37 UTC
Created attachment 527478 [details, diff]
rpi3_64.patch
Comment 5 Larry the Git Cow gentoo-dev 2018-07-23 22:29:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8803068b11340f0bc7c1d0b9f157c3605ec84a9b

commit 8803068b11340f0bc7c1d0b9f157c3605ec84a9b
Author:     Virgil Dupras <vdupras@gentoo.org>
AuthorDate: 2018-07-18 12:59:55 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2018-07-23 22:23:35 +0000

    net-libs/webkit-gtk: bump to 2.20.3
    
    * New dependency on media-libs/woff2 require us to drop keywords
    * Drop redundant python dependency under tests
    * The ia64 patch is no longer needed: the fatal build error on unknown
      CPUs has been removed.
    * arm64 compilation is fixed upstream.
    
    Closes: https://bugs.gentoo.org/655550
    Closes: https://bugs.gentoo.org/644284
    Closes: https://github.com/gentoo/gentoo/pull/9271
    Package-Manager: Portage-2.3.40, Repoman-2.3.9

 net-libs/webkit-gtk/Manifest                 |   1 +
 net-libs/webkit-gtk/webkit-gtk-2.20.3.ebuild | 283 +++++++++++++++++++++++++++
 2 files changed, 284 insertions(+)