Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 643616 - dev-python/hacking: Forces old versions of dev-python/pep8 & dev-python/testtools; impossible dependency on dev-python/flake8
Summary: dev-python/hacking: Forces old versions of dev-python/pep8 & dev-python/testt...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Matthew Thode ( prometheanfire )
URL: https://bugs.launchpad.net/gentoo/+bu...
Whiteboard:
Keywords: PullRequest
Depends on: 706412
Blocks:
  Show dependency tree
 
Reported: 2018-01-05 21:54 UTC by Michał Górny
Modified: 2020-01-26 21:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-01-05 21:54:45 UTC
hacking-0.10.3.ebuild:	~dev-python/pep8-1.5.7[${PYTHON_USEDEP}]
hacking-0.13.0.ebuild:	~dev-python/pep8-1.5.7[${PYTHON_USEDEP}]
hacking-0.9.2.ebuild:RDEPEND="~dev-python/pep8-1.5.6[${PYTHON_USEDEP}]
hacking-0.9.6.ebuild:RDEPEND="~dev-python/pep8-1.5.6[${PYTHON_USEDEP}]


This is a really awful design that not only blocks cleanup of other packages but also forces people to downgrade. Please look into fixing this horrible package not to force specific old versions of other packages. Thank you.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-01-06 13:05:48 UTC
Also:

hacking-0.10.3.ebuild:		>=dev-python/testtools-0.9.36[${PYTHON_USEDEP}]
hacking-0.10.3.ebuild:		<dev-python/testtools-1.2.0[${PYTHON_USEDEP}]
hacking-0.13.0.ebuild:		>=dev-python/testtools-0.9.36[${PYTHON_USEDEP}]
hacking-0.13.0.ebuild:		<dev-python/testtools-1.2.0[${PYTHON_USEDEP}]
Comment 2 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2018-01-06 21:46:58 UTC
yep, hacking is kinda bad about it, I've taken to patching it out of the ebuilds test-requirements.txt as a mater of course.

Even in 1.0.0 hacking still sets some stuff to only work with a certain version of various libraries.  https://github.com/openstack-dev/hacking/blob/1.0.0/requirements.txt

If upstream doesn't update the requirements (and preferably uncap/lock them) then I think moving to remove it from tree makes sense.
Comment 3 Andreas Sturmlechner gentoo-dev 2020-01-26 13:23:27 UTC
This is fun.


> $ grep flake8 hacking-1.1.0.ebuild
>	>=dev-python/flake8-2.6.0[${PYTHON_USEDEP}]
>	<dev-python/flake8-2.7.0[${PYTHON_USEDEP}]

Keywords for dev-python/flake8:
      |                               |   u   |  
      | a a   a     p           s r   |   n   |  
      | l m   r i   p   h m s   p i m | e u s | r
      | p d a m a p c x p 6 3   a s i | a s l | e
      | h 6 r 6 6 p 6 8 p 8 9 s r c p | p e o | p
      | a 4 m 4 4 c 4 6 a k 0 h c v s | i d t | o
------+-------------------------------+-------+-------
2.1.0 | ~ + ~ ~ ~ ~ ~ + ~ o ~ o o o o | 5 # 0 | gentoo
2.2.5 | ~ + + o + + + + + o + o + o o | 5 #   | gentoo
2.5.4 | ~ + + ~ + + + + + o o o o o o | 5 #   | gentoo
3.5.0 | ~ + + ~ + + + + + o + o + o ~ | 6 o   | gentoo
3.6.0 | ~ ~ ~ ~ ~ ~ ~ ~ ~ o ~ o ~ o ~ | 6 o   | gentoo
3.7.9 | o + ~ + ~ ~ ~ ~ o o o o o o o | 7 o   | gentoo

So, naturally:

> !!! Multiple package instances within a single package slot have been pulled
> !!! into the dependency graph, resulting in a slot conflict:
> 
> dev-python/flake8:0
> 
>   (dev-python/flake8-2.5.4:0/0::gentoo, ebuild scheduled for merge) USE="-test" ABI_X86="(64)" PYTHON_TARGETS="python3_6 -python2_7 (-python3_7)" pulled in by
>     <dev-python/flake8-2.7.0[python_targets_python3_6(-)?,python_targets_python3_7(-)?,-python_single_target_python3_6(-),-python_single_target_python3_7(-)] required by (dev-python/hacking-1.1.0:0/0::gentoo, ebuild scheduled for merge) USE="-doc -test" ABI_X86="(64)" PYTHON_TARGETS="python3_6 (-python3_7)"
>     ^                  ^^^^^                                                                                                                                                                                                                                                                                                                                                                                                                                              
> 
>   (dev-python/flake8-3.7.9:0/0::gentoo, ebuild scheduled for merge) USE="-test" ABI_X86="(64)" PYTHON_TARGETS="python3_6 (-pypy3) -python2_7 (-python3_7) (-python3_8)" pulled in by
>     >=dev-python/flake8-2.6.0[python_targets_python3_6(-)?,python_targets_python3_7(-)?,-python_single_target_python3_6(-),-python_single_target_python3_7(-)] required by (dev-python/hacking-1.1.0:0/0::gentoo, ebuild scheduled for merge) USE="-doc -test" ABI_X86="(64)" PYTHON_TARGETS="python3_6 (-python3_7)"
>     ^^                  ^^^^^
Comment 4 Andreas Sturmlechner gentoo-dev 2020-01-26 13:35:04 UTC
Please describe your process of stabilising 1.1.0 in commit a1c41da8f24305702c1e29b4fc3b69b78d6977ec.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-01-26 14:39:25 UTC
The real fun is that flake8/pep8 has no value for gentoo users.
Comment 6 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2020-01-26 20:23:55 UTC
install/test, commit, same as always.
Comment 7 Larry the Git Cow gentoo-dev 2020-01-26 20:24:20 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5f55303cb083c8dd5bcef6efdebcf75407f9bf07

commit 5f55303cb083c8dd5bcef6efdebcf75407f9bf07
Author:     Matthew Thode <prometheanfire@gentoo.org>
AuthorDate: 2020-01-26 20:23:46 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2020-01-26 20:24:14 +0000

    dev-python/hacking: 2.0.0 bump
    
    Bug: https://bugs.gentoo.org/643616
    Package-Manager: Portage-2.3.84, Repoman-2.3.20
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 dev-python/hacking/Manifest              |  4 +-
 dev-python/hacking/hacking-0.10.3.ebuild | 71 --------------------------------
 dev-python/hacking/hacking-0.9.2.ebuild  | 61 ---------------------------
 dev-python/hacking/hacking-0.9.6.ebuild  | 61 ---------------------------
 dev-python/hacking/hacking-2.0.0.ebuild  | 59 ++++++++++++++++++++++++++
 5 files changed, 60 insertions(+), 196 deletions(-)
Comment 8 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2020-01-26 21:25:03 UTC
need bug 706412 so we can remove 1.1.0
Comment 9 Larry the Git Cow gentoo-dev 2020-01-26 21:25:17 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b5418484968bf3e16a2feb4257a2ed24cce56d72

commit b5418484968bf3e16a2feb4257a2ed24cce56d72
Author:     Matthew Thode <prometheanfire@gentoo.org>
AuthorDate: 2020-01-26 21:19:53 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2020-01-26 21:25:11 +0000

    dev-python/hacking: 2.0.0 stable amd64 / x86 fast
    
    Bug: https://bugs.gentoo.org/643616
    Package-Manager: Portage-2.3.84, Repoman-2.3.20
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 dev-python/hacking/hacking-2.0.0.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 10 Larry the Git Cow gentoo-dev 2020-01-26 21:46:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c8d88a067fce0fb2b2c696ac93534a177efb056f

commit c8d88a067fce0fb2b2c696ac93534a177efb056f
Author:     Matthew Thode <prometheanfire@gentoo.org>
AuthorDate: 2020-01-26 21:45:37 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2020-01-26 21:46:22 +0000

    dev-python/hacking: 1.1.0 removed
    
    Closes: https://bugs.gentoo.org/643616
    Package-Manager: Portage-2.3.84, Repoman-2.3.20
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 dev-python/hacking/Manifest             |  1 -
 dev-python/hacking/hacking-1.1.0.ebuild | 59 ---------------------------------
 2 files changed, 60 deletions(-)