Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 640218 - net-libs/libnftnl-1.0.7: test failures
Summary: net-libs/libnftnl-1.0.7: test failures
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: 569254 CVE-2017-5716 641228
  Show dependency tree
 
Reported: 2017-12-07 22:00 UTC by Rolf Eike Beer
Modified: 2018-09-17 20:56 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (libnftnl-build.log,138.24 KB, text/plain)
2017-12-07 22:01 UTC, Rolf Eike Beer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Eike Beer archtester 2017-12-07 22:00:53 UTC
Portage 2.3.8 (python 3.5.4-final-0, default/linux/sparc/13.0, gcc-6.4.0, glibc-2.25-r9, 4.14.2 sparc64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.14.2-sparc64-sun4v-with-gentoo-2.3
KiB Mem:    33133616 total,  13272192 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Thu, 07 Dec 2017 01:15:01 +0000
Head commit of repository gentoo: 101d27e6e1b1959353d6ce41eb154aeac450c0df
sh bash 4.3_p48-r1
ld GNU ld (Gentoo 2.28.1 p1.0) 2.28.1
app-shells/bash:          4.3_p48-r1::gentoo
dev-lang/perl:            5.24.3::gentoo
dev-lang/python:          2.7.14::gentoo, 3.4.5::gentoo, 3.5.4-r1::gentoo
dev-util/cmake:           3.8.2::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.3::gentoo
sys-apps/openrc:          0.34.11::gentoo
sys-apps/sandbox:         2.10-r4::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69::gentoo
sys-devel/automake:       1.11.6-r2::gentoo, 1.15.1-r1::gentoo
sys-devel/binutils:       2.28.1::gentoo, 2.29.1-r1::gentoo
sys-devel/gcc:            5.4.0-r3::gentoo, 6.4.0::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.4::gentoo (virtual/os-headers)
sys-libs/glibc:           2.25-r9::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000

ACCEPT_KEYWORDS="sparc"
ACCEPT_LICENSE="* -@EULA"
CBUILD="sparc-unknown-linux-gnu"
CFLAGS="-O2 -mcpu=niagara2 -pipe"
CHOST="sparc-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.6/ext-active/ /etc/php/apache2-php7.1/ext-active/ /etc/php/cgi-php5.6/ext-active/ /etc/php/cgi-php7.1/ext-active/ /etc/php/cli-php5.6/ext-active/ /etc/php/cli-php7.1/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -mcpu=niagara2 -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS=""
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS=""
GENTOO_MIRRORS="ftp://ftp.wh2.tu-dresden.de/pub/mirrors/gentoo ftp://ftp.join.uni-muenster.de/pub/linux/distributions/gentoo"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j20"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl berkdb big-endian bzip2 cli cracklib crypt cxx dri fortran gdbm iconv ipv6 modules ncurses nls nptl openmp pam pcre readline session sparc ssl tcpd unicode xattr zlib" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_5" PYTHON_TARGETS="python2_7 python3_5" RUBY_TARGETS="ruby22" USERLAND="GNU" VIDEO_CARDS="fbdev glint mga r128 radeon dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS


=================================================================
                        Package Settings
=================================================================

net-libs/libnftnl-1.0.7::gentoo was built with the following:
USE="examples json static-libs threads -test"


Reproducible: Always
Comment 1 Rolf Eike Beer archtester 2017-12-07 22:01:18 UTC
Created attachment 508758 [details]
build.log
Comment 2 Sergei Trofimovich (RETIRED) gentoo-dev 2017-12-24 23:34:07 UTC
Same failure on ppc and ppc64.
Comment 3 Rolf Eike Beer archtester 2018-01-01 10:12:12 UTC
Same on hppa, even for 1.0.8-r1.
Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev 2018-03-30 23:32:07 UTC
Similar for ppc and ppc64. Looks like full Big Endian house.
Comment 5 Sergei Trofimovich (RETIRED) gentoo-dev 2018-03-31 14:45:21 UTC
Found endianness problem (manifests in json parser):
    https://git.netfilter.org/libnftnl/tree/src/utils.c#n82

    int nftnl_get_value(enum nftnl_type type, void *val, void *out)
    {
	int64_t sval;
	uint64_t uval;

	switch (type) {
	case NFTNL_TYPE_U8:
	case NFTNL_TYPE_U16:
	case NFTNL_TYPE_U32:
	case NFTNL_TYPE_U64:
		uval = *((uint64_t *)val);
		if (uval > basetype[type].max) {
			errno = ERANGE;
			return -1;
		}
		memcpy(out, &uval, basetype[type].len);
		break;

As a result 'out' does not contain any data if, say 'type' is NFTNL_TYPE_U32:
- memcpy copies first four bytes
- actual value is in last 4 bytes (big-endian leyout)
Comment 6 Rolf Eike Beer archtester 2018-03-31 15:07:37 UTC
And the cast before is probably also wrong. The value is casted to an uint64_t*, so the compiler can assume it has the proper alignment, and optimize the following memcopy away. It's in fact not needed at all if it is only passed to memcpy, this is fine with void*.
Comment 7 Rolf Eike Beer archtester 2018-08-29 20:34:37 UTC
This looks like it could be the fix: https://git.netfilter.org/libnftnl/commit/src/utils.c?id=9737856067b97cbb869e04fc6b6e65c1d859f521
Comment 8 Larry the Git Cow gentoo-dev 2018-09-17 20:56:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3907aa4b9821fc607aa7838202010bb5cc044cb1

commit 3907aa4b9821fc607aa7838202010bb5cc044cb1
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2018-09-17 20:53:09 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2018-09-17 20:56:41 +0000

    net-libs/libnftnl: add upstream patches to fix endianness issues
    
    Also drop the unused USE=threads at the same time for bug 643958.
    
    Closes: https://bugs.gentoo.org/640218
    Closes: https://bugs.gentoo.org/643958

 .../files/libnftnl-1.1.1-big-endian-1.patch        | 93 ++++++++++++++++++++++
 .../files/libnftnl-1.1.1-big-endian-2.patch        | 37 +++++++++
 .../files/libnftnl-1.1.1-big-endian-3.patch        | 33 ++++++++
 net-libs/libnftnl/libnftnl-1.1.1-r1.ebuild         | 67 ++++++++++++++++
 4 files changed, 230 insertions(+)