Please find attached gpsbabel-1.2.3.ebuild. GpsBabel is utility to convert tracks, routes and waypoints to varying gps binary formats for upload / download from a GPS device. I suggest app-misc/gpsbabel since that is where all the other GPS related software is ending up. Also, this ebuild depends on expat. Charles Reproducible: Always Steps to Reproduce:
Created attachment 39537 [details] gpsbabel-1.2.3.ebuild There is no automake included w/ this program. The ebuild compiles things okay and I've attempted to sanely handle the documentation.
I just tested this on an x86 (manually downloaded tarball to /usr/portage/distfiles) and everything looks good to me. Let's get this one up on portage eh?
My only recommendation is a better DESCRIPTION: (From sf.net homepage of gpsbabel) "GPSBabel reads and writes GPS waypoints in a variety of forms. Backends include GPX, Magellan and Garmin serial protocols, Geocaching.com *.loc, GPSMan, Garmin Mapsource *.mps, Magellan Mapsend *.wpt, and many others." (Quite lengthy but is more descriptive in detailing the aspect of transmitting & recieving via garmin serial/usb cable -- as I do!)
Worked fine for me after I changed SRC_URI to http://voxel.dl.sourceforge.net/sourceforge/gpsbabel/${P}.tar.gz I recall that portage has a better way of handling SF urls though. Also, HOMEPAGE should be changed to www.gpsbabel.org
Created attachment 59615 [details] gpsbabel-1.2.5.ebuild Following the Comment #3 I've added the complete description in the ebuild. Following the Comment #4 I've set the correct homepage and I simply use mirror://sourceforge/ to handle the sourceforge's mirroring system. Any feedbacks are welcome.
Works OK. This _should_ be in Portage.
Created attachment 63104 [details] gpsbabel-1.2.5 ebuild (actually working) No it doesn't. Obviously nobody tested it with usb unset. This one does.
Created attachment 65740 [details] gpsbabel-1.2.6.ebuild Version bump -> 1.2.6
Hi djay, Here are a few things that need to be looked into before this package can be added to Portage: - The "doc" USE flag is only for developer documentation. Please verify that it is appropriate in this case. - The ebuild does not honor the user's CC and CFLAGS. Have a look at how it is done in the PHYLIP ebuilds if you are unsure. - Some variable assignments are not quoted. Variable assignments must always be quoted. This is especially important when they contain variable substitutions. - Some variable substitutions must be quoted. This is the case as soon as you reference a directory whose name you do not know for sure. All Portage paths being customisable, variable substitutions referring to them must be quoted. - Installation fails on my system when trying to install the documentation (install: cannot stat `contrib/*': No such file or directory). - Version 1.2.7 is now available. Good luck, ;-)
Created attachment 67338 [details] gpsbabel-1.2.7.ebuild Following the Comment #9 some modifications have been made on the old ebuild and the new one for version 1.2.7 which I put here (the old one could be found here : http://gentoo.01map.net/sci-geosciences/gpsbabel/). For CFLAGS, I've choosen to let the default optimization available in the makefile by default and to append its with the user specific ones. Indeed the last -0 option is the one that is effective, then if no optimization are set in make.conf the default optimization will be used. For the documentation, I've decided to do nothing for the moment, even if I don't think that documentation is specificaly for developer. I think this ebuild don't need to make this documentation in its dvi version, feedbacks concerning this part are welcome. NEW : optional efence debugging support.
Created attachment 67339 [details] gpsbabel-1.2.7.ebuild Following the Comment #9 some modifications have been made on the old ebuild and the new one for version 1.2.7 which I put here (the old one could be found here : http://gentoo.01map.net/sci-geosciences/gpsbabel/). For CFLAGS, I've choosen to let the default optimization available in the makefile by default and to append its with the user specific ones. Indeed the last -0 option is the one that is effective, then if no optimization are set in make.conf the default optimization will be used. For the documentation, I've decided to do nothing for the moment, even if I don't think that documentation is specificaly for developer. I think this ebuild don't need to make this documentation in its dvi version, feedbacks concerning this part are welcome. NEW : optional efence debugging support.
1/ S="${WORKDIR}/${P}" is default, no need for that. 2/ ${S} should be quoted. 3/ Either shorten the DESCRIPTION or remove the line breaks and put it on one line.
djay: Nearly there. ;-) Still needs a bit of work, tough: - Description is way too verbose. We need only know it "reads and writes GPS waypoints in a variety of forms". The rest is superfluous, but could be added to the long description that is sometimes available in the "metadata.xml" file. Perhaps you could try writting an appropriate "metadata.xml" for this package? - S="${WORKDIR}/${P}", as Jakub said, is redundant, since that is the default. - The "${S}" variable substitution must always be quoted. - You should not leave "-O" in the Makefile, even if that is the default optimisation. Other packages in the tree do not behave like that (or should not, anyway). - The DVI document is the printable user manual. It is not developer documentation and, since upstream provides it, it is our job to always make it available to our users. The "doc" USE flag is not appropriate here. - You should only use the "dodoc" function for text files, since the files end up gzipped. You definitely do not want to gzip HTML, PDF or DVI files. - There is a missing figure in the DVI manual. I suggest installing both the manual and the relevant EPS file togheter in a "manual" directory inside "/usr/share/doc/${PF}/". Good luck,
Created attachment 67479 [details] gpsbabel-1.2.7.ebuild Hi, I send a corrected ebuild version. I've tried to create a patch to ensure the inclusion of the efence header, but now I don't think it's a good idea (it's look like the util.c is the only faulty file, it contains some memory allocation functions). I think it's could be enaugh to use this as is (without the patch) even if it's look like to me as simple as an export LD__PRELOAD=libefence.so.0.0" before running gpsbabel (but I could make a mistake..). Any feedback or purpose for this are welcome. I would like to know if I need to continue to patch the sources which I'm not realy falimliar with. (The epatch call is out of the src_unpack function just because it's not active by now.). The patch could be found on this page : http://postgis.fr/gentoo/sci-geosciences/gpsbabel/files/efence.patch. I've added the testc script and I decide to put it in a samples/scripts directory in the default documentation path for this package. Concerning the metadata.xml file, you could find the original version I've made on this link : http://www.postgis.fr/gentoo/sci-geosciences/gpsbabel/, it's laybe enough. To be honnest, I've just get the description on the gpsbabel home page :]
Hi djay, This version is a lot better. Almost ready for inclusion in Portage, in fact. ;-) Only a few things still need improvement: - It is necessary to use the "die" function to handle the exit return code everytime a command must succeed for the package to be installed properly. Some functions, like epatch, will automatically "die" if they fail. Others, such as dobin, dodoc or doins, will not (and, of course, UNIX tools such as sed know nothing about "die" or other Portage functions). For instance, you should use 'sed -e "s/foo/bar/" -i Makefile || die' rather than just 'sed -e "s/foo/bar/" -i Makefile'. - "app-text/tetex" is not a correct dependency. It should rather be "virtual/tetex". The reason is users of alternative TeTeX implementations such as cstetex have no interest in installing another TeX distribution when they already have one. Familiarity with the virtual implementations offered by Gentoo is important to write correct ebuilds. Have a look at "profiles/base/virtuals" to see how many there are. :) If you provide me with a fixed ebuild, I'll add the package to Portage this week. Thanks for your work.
Created attachment 67840 [details] gpsbabel-1.2.7.ebuild Hi, I hope that I've made all the necessaries changes in the ebuild. I've also removed the so silly patch (or I could say : "I've removed from my mind this stupid idea of applying an irrelevant patch" :] ) ... Thanks for your help.
In CVS. Many thanks for your work, djay. I added a "die" check for a sed command and removed leading/trailing spaces. A very good ebuild on the whole, probably better than many that are already in Portage. ;-) You can use repoman (man repoman) to check for minor syntax errors.
