Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 638632 - games-emulation/dolphin USE="-wxwidgets" does not disable wxwidgets checks in configuration step
Summary: games-emulation/dolphin USE="-wxwidgets" does not disable wxwidgets checks in...
Status: RESOLVED DUPLICATE of bug 598625
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2017-11-23 19:32 UTC by S. David Beniquez
Modified: 2018-07-22 21:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch to correctly disable wxwidgets dependency in games-emulation/dolphin-9999 (wxwidgets-use.patch,428 bytes, patch)
2017-11-23 19:32 UTC, S. David Beniquez
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description S. David Beniquez 2017-11-23 19:32:54 UTC
Created attachment 506210 [details, diff]
ebuild patch to correctly disable wxwidgets dependency in games-emulation/dolphin-9999

I noticed that due to several bugs, games-emulation/dolphin-9999 does not currently build. I understand it's a bit complicated with LLVM, but I believe there's a rather small bug in the ebuild itself and how it interprets USE Flags and passes parameters to cmake. 

Situation:
I've been attempting to compile games-emulation/dolphin-99999 without wxwidgets, since the version of wxwidgets it relies upon (3.10) is not in the tree yet. 

However, when I attempt to build it with USE="-wxwidgets", I get the following in my build:

-----
- Could NOT find wxWidgets: Found unsuitable version "3.0.2", but required is at least "3.1.0" (found -L/usr/lib64;-pthread;;;-lwx_gtk2u_core-3.0;-lwx_gtk2u_aui-3.0;-lwx_gtk2u_adv-3.0;-lwx_baseu-3.0)
-- Using static wxWidgets from Externals
CMake Error at CMakeLists.txt:755 (add_subdirectory):
  add_subdirectory given source "Externals/wxWidgets3" which is not an
  existing directory.
------

From looking at my build logs, I can see that portage is adding -DDISABLE_WX=ON to the cmake invocation:
---
cmake --no-warn-unused-cli -C /var/tmp/portage/games-emulation/dolphin-9999/work/dolphin-9999_build/gentoo_common_config.cmake -G Unix Makefiles -DCMAKE_INSTALL_PREFIX=/usr -DUSE_SHARED_ENET=ON -DENCODE_FRAMEDUMPS=ON -DFASTLOG=OFF -DOPROFILING=OFF -DDISABLE_WX=ON 
---

In reading through the CMakeList.txt file in the work tree, I found the following:

---
option(ENABLE_WX "Enable wxWidgets (Default)" ON)
---

Imo, the DISABLE_WX=ON flag *should* disable the dependency, but I'm no cmake expert. 

In looking through the cmake.eclass documentation, and doing some experimentation, I believe the following patch should be applied to games-emulation/dolphin-9999 and games-emulation/dolphon-5.0 to get the desired behavior:

---
--- /usr/portage/games-emulation/dolphin/dolphin-9999.ebuild    2017-02-28 14:50:50.000000000 -0500
+++ /usr/local/portage/local-fixes/games-emulation/dolphin/dolphin-9999.ebuild       2017-11-23 14:13:53.629758536 -0500
@@ -119,2 +119,3 @@
 
+
        # Remove ALL the bundled libraries, aside from:
@@ -158,3 +159,3 @@
                $( cmake-utils_use profile OPROFILING )
-               $( cmake-utils_use_disable wxwidgets WX )
+               $( cmake-utils_use_enable wxwidgets WX )
                $( cmake-utils_use_enable evdev EVDEV )

---

Initial testing on my configuration shows that it gets rid of the WX dependency, but it bombs out due to the other issues listed in bug 594940.
Comment 1 Jason Oliveira 2017-12-30 21:31:02 UTC
It seems that the WXWidgets frontend is being phased-out, which is why the dependency is set to a version that doesn't exist (even in git). Despite the error thrown, it actually _does_ build the WXWidgets frontend without further complaint.

The actual flag should be -DENABLE_WX=OFF to only build the Qt5 frontend.

Haven't built from the -9999 ebuild yet, but building straight from git requires the following extra packages:
net-libs/mbedtls
media-libs/libsfml
dev-libs/hidapi

I used "cmake .. -DCMAKE_INSTALL_PREFIX:PATH=/usr -DENABLE_QT2=true -DDISABLE_WX=ON" and make didn't complain once. Built without any issues.
Comment 2 Scall 2018-07-02 16:43:00 UTC
I think this can be closed since dolphin-wx has been removed:
https://github.com/dolphin-emu/dolphin/commit/e22c5333ab50c3e84774ce831eaeba48bcea5901
Comment 3 Sergei Trofimovich (RETIRED) gentoo-dev 2018-07-22 21:18:45 UTC
Was handled in bug #598625.

Thanks all!

*** This bug has been marked as a duplicate of bug 598625 ***