Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 635222 - app-emulation/wine-* ebuilds with empty PATCHES_BIN: Unnecessary dependency on dev-util/patchbin
Summary: app-emulation/wine-* ebuilds with empty PATCHES_BIN: Unnecessary dependency o...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Wine Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-23 20:19 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2017-11-07 02:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2017-10-23 20:19:55 UTC
Please disable dependency on dev-util/patchbin in these app-emulation/wine-* ebuilds which set empty PATCHES_BIN.

It can be implemented by moving definition of PATCHES_BIN to global scope and using:

if [[ ${#PATCHES_BIN[@]} -ge 1 ]]; then
    DEPEND+=" dev-util/patchbin"
fi
Comment 1 Adam Feldman gentoo-dev 2017-10-23 21:06:55 UTC
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #0)
> Please disable dependency on dev-util/patchbin in these app-emulation/wine-*
> ebuilds which set empty PATCHES_BIN.
> 
> It can be implemented by moving definition of PATCHES_BIN to global scope
> and using:
> 
> if [[ ${#PATCHES_BIN[@]} -ge 1 ]]; then
>     DEPEND+=" dev-util/patchbin"
> fi

SGTM.  Thanks.  I'll make it include that conditional as well as 9999, as I'd like to eventually add the ability to pick patches on the fly from the patch tarball for live ebuilds (allowing easier use for older releases)

Planning on sitting down to it this evening, so I'll update the bug when I make the change.
Comment 2 Larry the Git Cow gentoo-dev 2017-11-05 05:53:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=66f821f2e7070911693cadb92cdf88e2101abb86

commit 66f821f2e7070911693cadb92cdf88e2101abb86
Author:     NP-Hardass <NP-Hardass@gentoo.org>
AuthorDate: 2017-11-05 05:37:27 +0000
Commit:     NP-Hardass <NP-Hardass@gentoo.org>
CommitDate: 2017-11-05 05:53:13 +0000

    app-emulation/wine-any: Refactor to dynamically add patchbin dep
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=635222
    Package-Manager: Portage-2.3.13, Repoman-2.3.4

 app-emulation/wine-any/wine-any-2.0-r1.ebuild  | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.1-r1.ebuild  | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.10-r1.ebuild | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.11-r1.ebuild | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.12-r1.ebuild | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.13-r1.ebuild | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.14-r1.ebuild | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.15-r1.ebuild | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.16-r1.ebuild | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.17-r1.ebuild | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.2-r1.ebuild  | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.3-r1.ebuild  | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.4-r1.ebuild  | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.5-r1.ebuild  | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.6-r1.ebuild  | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.7-r1.ebuild  | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.8-r1.ebuild  | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-2.9-r1.ebuild  | 30 +++++++++++++++-----------
 app-emulation/wine-any/wine-any-9999.ebuild    | 23 ++++++++++++--------
 19 files changed, 338 insertions(+), 225 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=74628047b7bc8e62cd634bd518484330412489f6

commit 74628047b7bc8e62cd634bd518484330412489f6
Author:     NP-Hardass <NP-Hardass@gentoo.org>
AuthorDate: 2017-11-05 05:27:23 +0000
Commit:     NP-Hardass <NP-Hardass@gentoo.org>
CommitDate: 2017-11-05 05:53:07 +0000

    app-emulation/wine-d3d9: Refactor to dynamically add patchbin dep
    
    Bug: https://bugs.gentoo.org/show_bug.cgi?id=635222
    Package-Manager: Portage-2.3.13, Repoman-2.3.4

 app-emulation/wine-d3d9/wine-d3d9-2.0-r1.ebuild  | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.1-r1.ebuild  | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.10-r1.ebuild | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.11-r1.ebuild | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.12-r1.ebuild | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.13-r1.ebuild | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.14-r1.ebuild | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.15-r1.ebuild | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.16-r1.ebuild | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.17-r1.ebuild | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.2-r1.ebuild  | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.3-r1.ebuild  | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.4-r1.ebuild  | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.5-r1.ebuild  | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.6-r1.ebuild  | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.7-r1.ebuild  | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.8-r1.ebuild  | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-2.9-r1.ebuild  | 30 ++++++++++++++----------
 app-emulation/wine-d3d9/wine-d3d9-9999.ebuild    | 23 +++++++++++-------
 19 files changed, 338 insertions(+), 225 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=039fcf5b81122e14fa915eb4755fc2271ffcec80

commit 039fcf5b81122e14fa915eb4755fc2271ffcec80
Author:     NP-Hardass <NP-Hardass@gentoo.org>
AuthorDate: 2017-11-05 05:06:58 +0000
Commit:     NP-Hardass <NP-Hardass@gentoo.org>
CommitDate: 2017-11-05 05:53:03 +0000

    app-emulation/wine-staging: Refactor to dynamically add patchbin dep
    
    Bug: https://bugs.gentoo.org/show_bug.cgi?id=635222
    Package-Manager: Portage-2.3.13, Repoman-2.3.4

 .../wine-staging/wine-staging-2.0-r1.ebuild        | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.1-r1.ebuild        | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.10-r1.ebuild       | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.11-r1.ebuild       | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.12-r1.ebuild       | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.13-r1.ebuild       | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.14-r1.ebuild       | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.15-r1.ebuild       | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.16-r1.ebuild       | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.17-r1.ebuild       | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.18.ebuild          | 23 ++++++++++-------
 .../wine-staging/wine-staging-2.2-r1.ebuild        | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.3-r1.ebuild        | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.4-r1.ebuild        | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.5-r1.ebuild        | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.6-r1.ebuild        | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.7-r1.ebuild        | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.8-r1.ebuild        | 30 +++++++++++++---------
 .../wine-staging/wine-staging-2.9-r1.ebuild        | 30 +++++++++++++---------
 .../wine-staging/wine-staging-9999.ebuild          | 23 ++++++++++-------
 20 files changed, 352 insertions(+), 234 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5b6d00017644283b5d199787b9603928ef8fa13e

commit 5b6d00017644283b5d199787b9603928ef8fa13e
Author:     NP-Hardass <NP-Hardass@gentoo.org>
AuthorDate: 2017-11-03 16:56:15 +0000
Commit:     NP-Hardass <NP-Hardass@gentoo.org>
CommitDate: 2017-11-05 05:52:58 +0000

    app-emulation/wine-vanilla: Refactor to dynamically add patchbin dep
    
    Bug: https://bugs.gentoo.org/show_bug.cgi?id=635222
    Package-Manager: Portage-2.3.13, Repoman-2.3.4

 .../wine-vanilla/wine-vanilla-2.0-r1.ebuild        | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.0.1-r1.ebuild      | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.0.2-r1.ebuild      | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.1-r1.ebuild        | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.10-r1.ebuild       | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.11-r1.ebuild       | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.12-r1.ebuild       | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.13-r1.ebuild       | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.14-r1.ebuild       | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.15-r1.ebuild       | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.16-r1.ebuild       | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.17-r1.ebuild       | 29 +++++++++++++---------
 ...-2.18-r1.ebuild => wine-vanilla-2.18-r2.ebuild} | 22 +++++++++-------
 ...lla-2.19.ebuild => wine-vanilla-2.19-r1.ebuild} | 22 +++++++++-------
 .../wine-vanilla/wine-vanilla-2.2-r1.ebuild        | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.3-r1.ebuild        | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.4-r1.ebuild        | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.5-r1.ebuild        | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.6-r1.ebuild        | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.7-r1.ebuild        | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.8-r1.ebuild        | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-2.9-r1.ebuild        | 29 +++++++++++++---------
 .../wine-vanilla/wine-vanilla-9999.ebuild          | 22 +++++++++-------
 23 files changed, 379 insertions(+), 267 deletions(-)}
Comment 3 Arfrever Frehtes Taifersar Arahesis 2017-11-06 20:04:12 UTC
3 ebuilds mistakenly specify dev-util/patchbin twice (conditionally and unconditionally):
app-emulation/wine-vanilla-2.0.3
app-emulation/wine-vanilla-2.20
app-emulation/wine-vanilla-9999
Comment 4 Adam Feldman gentoo-dev 2017-11-07 02:36:14 UTC
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #3)
> 3 ebuilds mistakenly specify dev-util/patchbin twice (conditionally and
> unconditionally):
> app-emulation/wine-vanilla-2.0.3
> app-emulation/wine-vanilla-2.20
> app-emulation/wine-vanilla-9999

Agh, that's what I get for editing out of order and re-arranging my commits.  Uploading a fix in a minute.  Thanks for pointing it out.
Comment 5 Larry the Git Cow gentoo-dev 2017-11-07 02:39:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=adf45fad60e902afb8b9954928f6edb7c02d66a2

commit adf45fad60e902afb8b9954928f6edb7c02d66a2
Author:     NP-Hardass <NP-Hardass@gentoo.org>
AuthorDate: 2017-11-07 02:38:31 +0000
Commit:     NP-Hardass <NP-Hardass@gentoo.org>
CommitDate: 2017-11-07 02:39:36 +0000

    app-emulation/wine-vanilla: remove accidental patchbin dep
    
    Reported-by: Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com>
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=635222
    Package-Manager: Portage-2.3.13, Repoman-2.3.4

 app-emulation/wine-vanilla/wine-vanilla-2.0.3.ebuild | 1 -
 app-emulation/wine-vanilla/wine-vanilla-2.20.ebuild  | 1 -
 app-emulation/wine-vanilla/wine-vanilla-9999.ebuild  | 1 -
 3 files changed, 3 deletions(-)