635144 – =net-libs/webkit-gtk-2.18.1 fails with missing gst/gl/egl/gstgldisplay_egl.h

Bug 635144 - =net-libs/webkit-gtk-2.18.1 fails with missing gst/gl/egl/gstgldisplay_egl.h

Summary: =net-libs/webkit-gtk-2.18.1 fails with missing gst/gl/egl/gstgldisplay_egl.h

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Linux Gnome Desktop Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	CVE-2017-7081, CVE-2017-7087, CVE-2017-7089, CVE-2017-7090, CVE-2017-7091, CVE-2017-7092, CVE-2017-7093, CVE-2017-7094, CVE-2017-7095, CVE-2017-7096, CVE-2017-7098, CVE-2017-7099, CVE-2017-7100, CVE-2017-7102, CVE-2017-7104, CVE-2017-7107, CVE-2017-7109, CVE-2017-7111, CVE-2017-7117, CVE-2017-7120, CVE-2017-7142, WSA-2017-0008
	Show dependency tree

Reported:	2017-10-23 09:16 UTC by Branko Grubic
Modified:	2017-10-26 12:59 UTC (History)
CC List:	9 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Branko Grubic 2017-10-23 09:16:08 UTC

Latest net-libs/webkit-gtk-2.18.1 fails to build on my ~amd64 box:

 * Package:    net-libs/webkit-gtk-2.18.1
 * Repository: gentoo
 * Maintainer: gnome@gentoo.org
 * USE:        X abi_x86_64 amd64 egl elibc_glibc geolocation gstreamer introspection jit kernel_linux libnotify opengl spell userland_GNU webgl
 * FEATURES:   compressdebug preserve-libs sandbox splitdebug userpriv usersandbox

...


MediaPlayerPrivateGStreamerBase.cpp.o -MF Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp.o.d -o Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp.o -c /var/tmp/portage/net-libs/webkit-gtk-2.18.1/work/webkitgtk-2.18.1/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
/var/tmp/portage/net-libs/webkit-gtk-2.18.1/work/webkitgtk-2.18.1/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:80:41: fatal error: gst/gl/egl/gstgldisplay_egl.h: No such file or directory
 #include <gst/gl/egl/gstgldisplay_egl.h>
                                         ^
compilation terminated.
...


The following header file is indeed missing on my system, and it seems it can be provided by media-libs/gst-plugins-bad when built with USE="egl"

I'm test building with media-libs/gst-plugins-bad built with 'egl' support. I'm sorry I cannot provide complete build log at the moment

Comment 1 Branko Grubic 2017-10-23 11:18:41 UTC

Small update, now with media-libs/gst-plugins-bad rebuilt with USE="egl", net-libs/webkit-gtk-2.18.1 builds fine for me.

net-libs/webkit-gtk-2.18.1 (X egl geolocation gstreamer introspection jit libnotify opengl spell webgl)
media-libs/gst-plugins-bad-1.12.3 (X abi_x86_64 bzip2 egl gtk introspection nls opengl orc)

Comment 2 Joakim Tjernlund 2017-10-23 14:34:49 UTC

me too, same build error and same fix(gst-bad egl) for me

Comment 3 Fred Krogh 2017-10-23 16:14:36 UTC

I too went from failure to success by adding egl to the use flags for gst-plugins-bad.
Thanks for the suggestion.

Comment 4 Larry the Git Cow gentoo-dev

2017-10-24 19:45:31 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=16fca2dd392910b7a773caace8126b4293695ed0

commit 16fca2dd392910b7a773caace8126b4293695ed0
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2017-10-24 19:45:11 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2017-10-24 19:45:11 +0000

    net-libs/webkit-gtk: USE=gstreamer,egl requires gst-plugins-bad[egl] now
    
    If EGL is enabled, then the gstreamer code (only compiled with USE=gstreamer) will
    want to include gstreamer egl headers, in addition to gst gl headers
    
    Bug: https://bugs.gentoo.org/635144
    Package-Manager: Portage-2.3.8, Repoman-2.3.2

 net-libs/webkit-gtk/webkit-gtk-2.18.1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)}

Comment 5 Mart Raudsepp gentoo-dev

2017-10-24 19:47:42 UTC

As seen, I've added the necessary depend. But now we have the problem of webkit-gtk having IUSE=+egl, while gst-plugins-bad doesn't. Need to think how to approach that, before I feel comfortable stabilizing webkit-gtk-2.18.1 for security.. overnight ideas welcome (I need to hit the bed for now)

Comment 6 Mart Raudsepp gentoo-dev

2017-10-26 12:59:35 UTC

I've default enabled USE=egl,opengl on gst-plugins-bad to accommodate. Hope that doesn't have too much fallout.
webkit-gtk needing this will probably go stable due to security before the gst-plugins-bad version with IUSE default changes does; but the stabilization of that gst-plugins-bad will probably be filed later today as well, just it won't have a security high priority.