Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 632678 - app-text/coolreader should install only user lang selected dictionaries
Summary: app-text/coolreader should install only user lang selected dictionaries
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andrey Grozin
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-02 08:15 UTC by Sergey S. Starikoff
Modified: 2017-10-31 16:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey S. Starikoff 2017-10-02 08:15:22 UTC
In my system I have only one user selected custom language:
$ grep L10N /etc/portage/make.conf 
L10N="ru"

But [I] app-text/coolreader (3.1.2.71-r1@11.09.2017) has installed all provided hyphenation dictionaries:
$ qlist app-text/coolreader
…
/usr/share/cr3/hyph/Hungarian_hyphen_(Alan).pdb
/usr/share/cr3/hyph/French_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Irish_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Russian_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Slovak_hyphen_(Alan).pdb
/usr/share/cr3/hyph/German_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Ukrain_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Finnish_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Czech_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Dutch.pattern
/usr/share/cr3/hyph/Portuguese_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Italian_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Bulgarian_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Icelandic_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Slovenian_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Greek.pattern
/usr/share/cr3/hyph/Danish_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Swedish_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Russian_EnUS_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Spanish_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Polish_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Catalan.pattern
/usr/share/cr3/hyph/English_US_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Roman_hyphen_(Alan).pdb
/usr/share/cr3/hyph/Russian_EnGB_hyphen_(Alan).pdb
/usr/share/cr3/hyph/English_GB_hyphen_(Alan).pdb
…

In my case it is strange to see installed Finnish, Portuguese, Italian and others dictionaries.
But I'm not enough familiar with portage to provide patch to fix it.

P.S. Default USE set for app-text/coolreader doesn't match any buildable configuration.
AFAIR for now default GUI is qt4, so instead current
> IUSE="qt4 qt5 wxwidgets corefonts liberation-fonts"
we should follow upstream's default:
> IUSE="+qt4 qt5 wxwidgets corefonts liberation-fonts"

wxwidgets for years is poorly supported, with updates just to keep it buildable.
So, warning when it is selected also should be welcomed.

Following bug #631802 (dropping qt4 USE) the default GUI should be set to qt5.
Comment 1 Andreas Sturmlechner gentoo-dev 2017-10-19 11:23:14 UTC
3.1.2.71-r1 (and several flags) was removed from tree long ago, please update to -r2 and report if any of your findings still apply.
Comment 2 Sergey S. Starikoff 2017-10-19 12:37:55 UTC
(In reply to Andreas Sturmlechner from comment #1)
> 3.1.2.71-r1 (and several flags) was removed from tree long ago, please
> update to -r2 and report if any of your findings still apply.

Almost up to date [I] app-text/coolreader (3.1.2.71-r2@10/10/17) also installs all these dictionaries.
Comment 3 Andrey Grozin gentoo-dev 2017-10-20 12:38:00 UTC
I agree that we can save a tiny amount of space by not installing all .qm files in /usr/share/cr3/i18n/ - they are translations of the UI, and should be controlled by $LINGUAS. But hyphenation tables?? Any user with any selected UI translation may want to read ebooks in foreign languages, and expects words to be hyphenated according to the rules of the corresponding foreign languages. I'm Russian; I often read English ebooks with fbreader, and expect hyphenations to be correct according to English language rules. So, I'm definitely against removing any files from /usr/share/cr3/hyph/.
Comment 4 Sergey S. Starikoff 2017-10-31 14:54:48 UTC
(In reply to Andrey Grozin from comment #3)
> I agree that we can save a tiny amount of space by not installing all .qm
> files in /usr/share/cr3/i18n/ - they are translations of the UI, and should
> be controlled by $LINGUAS. But hyphenation tables?? Any user with any
> selected UI translation may want to read ebooks in foreign languages, and
> expects words to be hyphenated according to the rules of the corresponding
> foreign languages. I'm Russian; I often read English ebooks with fbreader,
> and expect hyphenations to be correct according to English language rules.
> So, I'm definitely against removing any files from /usr/share/cr3/hyph/.

English is *very* bad example, because it is core language, which is free of any compatibility and encodings issues.

Except English user usually need to make a study and perform some pre-requested actions to read a book.
Simple installation of hyphenation tables may be insuffcient.
For example, my favourite font (Terminus) is unsufficient to read classic Russian books (36-letters alphabet).
I know some issues with display some representations of Greek texts.

Incomplete and possibly inoperable installation is a wrong thing.
Comment 5 Andrey Grozin gentoo-dev 2017-10-31 16:13:31 UTC
What I say is: the language a user prefers to see in his/her UI and the set of languages in which this users wants to read ebooks are two absolutely independent parameters. They must not be controlled by the same $LINGUAS setting.
One possible solution: let's introduce a bunch of USE flags for languages the user might want to read ebooks in, by default all of them on. Then, if you are sure you'll never want to read a Finnish ebook, just switch the corresponding USE flag off.