Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 631128 - media-plugins/gst-plugins-mad:1.0 removal
Summary: media-plugins/gst-plugins-mad:1.0 removal
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: GStreamer package maintainers
URL:
Whiteboard:
Keywords: PMASKED
Depends on: 635466 645874
Blocks:
  Show dependency tree
 
Reported: 2017-09-16 15:43 UTC by Mart Raudsepp
Modified: 2018-05-26 10:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2017-09-16 15:43:50 UTC
gst-plugins-ugly 1.12 set has removed the mad plugin completely, with the following commit:

commit 2f767fb24ac8ee001bde7e1452b46a4f8fe3a719
Author: Tim-Philipp Müller
Date:   Wed Dec 28 10:42:15 2016 +0000

    mad: remove plugin
    
    We have better replacements such as the mpg123 plugin.
    The main reason to keep around mad was for 'freeform'
    mp3 support, but mpg123 can handle those too nowadays.
    Also, mad is GPL and has been unmaintained for years.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=776140


As such, we should bring keyword visibility up to parity for media-plugins/gst-plugins-mpg123 and then once 1.12 set is stable, last rite gst-plugins-mad (I guess some pkgmove tricks onto -mpg123 would be inappropriate here)
Comment 1 Joakim Tjernlund 2017-09-19 12:59:49 UTC
I this bug holding back media-plugins/gst-plugins-meta-1.12.3 ?
Can we not have a unstable gst-plugins-meta-1.12.3 while we wait?
Comment 2 Mart Raudsepp gentoo-dev 2017-09-19 13:11:02 UTC
Just upgrade things with --deep (-D)?
But I'm not sure, I haven't checked; might involve de-keywording indeed. I'll try to look soon, finished 1.12.3 yesterday just before sleep and forgot about gnome@ maintained meta by the end of it.
Comment 3 Joakim Tjernlund 2017-09-19 21:39:08 UTC
(In reply to Mart Raudsepp from comment #2)
> Just upgrade things with --deep (-D)?

Nope, does not work :(

> But I'm not sure, I haven't checked; might involve de-keywording indeed.
> I'll try to look soon, finished 1.12.3 yesterday just before sleep and
> forgot about gnome@ maintained meta by the end of it.

Thanks
Comment 4 Joakim Tjernlund 2017-09-23 14:20:58 UTC
(In reply to Mart Raudsepp from comment #2)
> Just upgrade things with --deep (-D)?
> But I'm not sure, I haven't checked; might involve de-keywording indeed.
> I'll try to look soon, finished 1.12.3 yesterday just before sleep and
> forgot about gnome@ maintained meta by the end of it.

Pretty please ? :)
Comment 5 Mart Raudsepp gentoo-dev 2017-09-23 15:44:10 UTC
I fail to understand what's the problem with using the previous version for this. If you don't see the upgrades without a 1.12.3 meta ebuild, your upgrading process is flawed and you are missing many other important package updates as well.
Comment 6 Larry the Git Cow gentoo-dev 2018-03-30 21:38:19 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b709e451c27afbbd4fdb1154316a23937ed6dc34

commit b709e451c27afbbd4fdb1154316a23937ed6dc34
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2018-03-30 21:09:35 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2018-03-30 21:37:27 +0000

    profiles: p.mask gst-plugins-mad, use gst-plugins-mpg123 instead
    
    Bug: https://bugs.gentoo.org/631128

 profiles/package.mask | 6 ++++++
 1 file changed, 6 insertions(+)}
Comment 7 Larry the Git Cow gentoo-dev 2018-05-26 10:41:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=05811804f13a67d2aa0e34dc50f481c425a107da

commit 05811804f13a67d2aa0e34dc50f481c425a107da
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2018-05-26 10:35:55 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2018-05-26 10:37:35 +0000

    media-plugins/gst-plugins-mad: Remove last rited 1.0 SLOT
    
    Update p.mask for that accordingly, but keep it around for longer for
    informational purposes to slow upgraders, as if it hasn't been removed,
    the mad plugin priority rank is high and it might get used instead of
    mpg123 until removed from users system.
    
    Closes: https://bugs.gentoo.org/631128
    Package-Manager: Portage-2.3.28, Repoman-2.3.9

 media-plugins/gst-plugins-mad/Manifest                     |  1 -
 .../gst-plugins-mad/gst-plugins-mad-1.10.5.ebuild          | 14 --------------
 profiles/package.mask                                      |  3 ++-
 3 files changed, 2 insertions(+), 16 deletions(-)