Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 630556 - media-video/mpv-0.27.0: version bump
Summary: media-video/mpv-0.27.0: version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Coacher
URL: https://github.com/gentoo/gentoo/pull...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-10 06:41 UTC by sul
Modified: 2017-09-28 09:43 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sul 2017-09-10 06:41:44 UTC
Hello,

Since the release of youtube-dl v2017.08.06, embed lua script to use youtube-dl in mpv doesn't work on some streaming video providers like Vimeo.

According to this issue on github (https://github.com/mpv-player/mpv/issues/4728#issuecomment-320725058), there is an fixed script available on master branch.

I tried locally this fix as describe in github comment. I edited my ~/mpv/config. Now it works fine on website like Vimeo. Maybe this fix should be distributed globally with mpv-0.26.0 ?

On my system, I use both mpv ~amd64 and youtube-dl ~amd64.
Comment 1 Coacher 2017-09-11 19:20:57 UTC
(In reply to tipiak from comment #0)
> Hello,
> 
> Since the release of youtube-dl v2017.08.06, embed lua script to use
> youtube-dl in mpv doesn't work on some streaming video providers like Vimeo.
> 
> According to this issue on github
> (https://github.com/mpv-player/mpv/issues/4728#issuecomment-320725058),
> there is an fixed script available on master branch.
> 
> I tried locally this fix as describe in github comment. I edited my
> ~/mpv/config. Now it works fine on website like Vimeo. Maybe this fix should
> be distributed globally with mpv-0.26.0 ?
> 
> On my system, I use both mpv ~amd64 and youtube-dl ~amd64.
Could you please give an example of a link that fails with recent youtube-dl and mpv-0.26.0?
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-09-11 20:22:18 UTC
I think it's the same issue, so:

$ mpv https://www.youtube.com/watch?v=oWrX_pjo75Q
Playing: https://www.youtube.com/watch?v=oWrX_pjo75Q
[ytdl_hook] 
[ytdl_hook] stack traceback:
[ytdl_hook] 	@ytdl_hook.lua:71: in function 'edl_escape'
[ytdl_hook] 	@ytdl_hook.lua:139: in function 'edl_track_joined'
[ytdl_hook] 	@ytdl_hook.lua:171: in function 'add_single_video'
[ytdl_hook] 	@ytdl_hook.lua:454: in function 'fn'
[ytdl_hook] 	mp.defaults:518: in function 'handler'
[ytdl_hook] 	mp.defaults:339: in function 'handler'
[ytdl_hook] 	mp.defaults:458: in function 'call_event_handlers'
[ytdl_hook] 	mp.defaults:495: in function 'dispatch_events'
[ytdl_hook] 	mp.defaults:451: in function <mp.defaults:450>
[ytdl_hook] 	[C]: at 0x0047e770
[ytdl_hook] 	[C]: at 0x0047fe80
[ytdl_hook] Lua error: @ytdl_hook.lua:71: bad argument #1 to 'len' (string expected, got nil)
[ffmpeg] tls: The TLS connection was non-properly terminated.
Failed to recognize file format.


Exiting... (Errors when loading file)
Comment 3 sul 2017-09-12 05:55:15 UTC
(In reply to Coacher from comment #1)
> Could you please give an example of a link that fails with recent youtube-dl
> and mpv-0.26.0?
Any videos from vimeo should failed. eg: https://vimeo.com/231737519

$ mpv https://vimeo.com/231737519
Playing: https://vimeo.com/231737519
[ytdl_hook] 
[ytdl_hook] stack traceback:
[ytdl_hook] 	[C]: in function 'len'
[ytdl_hook] 	@ytdl_hook.lua:71: in function 'edl_escape'
[ytdl_hook] 	@ytdl_hook.lua:139: in function 'edl_track_joined'
[ytdl_hook] 	@ytdl_hook.lua:171: in function 'add_single_video'
[ytdl_hook] 	@ytdl_hook.lua:454: in function 'fn'
[ytdl_hook] 	mp.defaults:518: in function 'handler'
[ytdl_hook] 	mp.defaults:339: in function 'handler'
[ytdl_hook] 	mp.defaults:458: in function 'call_event_handlers'
[ytdl_hook] 	mp.defaults:495: in function 'dispatch_events'
[ytdl_hook] 	mp.defaults:451: in function <mp.defaults:450>
[ytdl_hook] 	[C]: ?
[ytdl_hook] 	[C]: ?
[ytdl_hook] Lua error: @ytdl_hook.lua:71: bad argument #1 to 'len' (string expected, got nil)
Failed to recognize file format.

Exiting... (Errors when loading file)

$ mpv --version
mpv 0.26.0 (C) 2000-2017 mpv/MPlayer/mplayer2 projects
 built on UNKNOWN
ffmpeg library versions:
   libavutil       55.58.100
   libavcodec      57.89.100
   libavformat     57.71.100
   libswscale      4.6.100
   libavfilter     6.82.100
   libswresample   2.7.100
ffmpeg version: 3.3.3

$ youtube-dl --version
2017.09.02


(In reply to Michał Górny from comment #2)
> I think it's the same issue, so:
I don't know, but at least, using the latest lua script from master branch fixes this case too.
Comment 4 Coacher 2017-09-13 20:04:50 UTC
Should be fixed in the 0.27.0, for which I'm going to prepare ebuild tomorrow.
Comment 5 Coacher 2017-09-17 13:53:39 UTC
Sorry, v0.27.0 bump delayed due to problems with raspberry-pi builds:
https://github.com/mpv-player/mpv/pull/4883
Since upstream dropped sane raspberry-pi detection via pkg-config and reverted back to the hardcoded way.
Comment 6 Coacher 2017-09-24 18:34:17 UTC
It seems raspberry-pi support is more broken than I anticipated:
https://github.com/mpv-player/mpv/pull/4883
https://github.com/mpv-player/mpv/pull/4869
https://github.com/mpv-player/mpv/issues/4919

The first two can be solved downstream in Gentoo with patches (I have the patches ready), but the last one needs to be resolved upstream first. We'll bump to 0.27.0 and have raspberry-pi support masked in newer mpv versions for now.
Comment 7 Larry the Git Cow gentoo-dev 2017-09-28 09:43:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b576e37305f28fd5e3c363c98d1ffcbdf1fae54e

commit b576e37305f28fd5e3c363c98d1ffcbdf1fae54e
Author:     Ilya Tumaykin <itumaykin@gmail.com>
AuthorDate: 2017-09-24 18:13:56 +0000
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: 2017-09-28 09:42:56 +0000

    media-video/mpv: verbump to 0.27.0
    
    Closes: https://bugs.gentoo.org/630556
    Closes: https://github.com/gentoo/gentoo/pull/5787
    Package-Manager: Portage-2.3.10, Repoman-2.3.3

 media-video/mpv/Manifest                           |   1 +
 .../0.27.0/mpv-0.27.0-fix-hwdec-autoprobing.patch  |  50 +++
 .../mpv-0.27.0-fix-wrong-colors-with-hwdec.patch   |  44 +++
 ...pv-0.27.0-remove-duplicate-android-option.patch |  27 ++
 media-video/mpv/mpv-0.27.0.ebuild                  | 370 +++++++++++++++++++++
 5 files changed, 492 insertions(+)